From 076e01adbb9a62977fce173084f82d3c689a3ee5 Mon Sep 17 00:00:00 2001 From: Hare Date: Thu, 16 Jul 2026 08:00:28 +0900 Subject: [PATCH] ticket: close knowledge removal work --- .yoi/tickets/00001KXKP2A71/item.md | 4 +- .yoi/tickets/00001KXKP2A71/resolution.md | 41 +++++++++ .yoi/tickets/00001KXKP2A71/thread.md | 108 +++++++++++++++++++++++ 3 files changed, 151 insertions(+), 2 deletions(-) create mode 100644 .yoi/tickets/00001KXKP2A71/resolution.md diff --git a/.yoi/tickets/00001KXKP2A71/item.md b/.yoi/tickets/00001KXKP2A71/item.md index 01cf7b08..65173bb4 100644 --- a/.yoi/tickets/00001KXKP2A71/item.md +++ b/.yoi/tickets/00001KXKP2A71/item.md @@ -1,8 +1,8 @@ --- title: 'Remove Knowledge support' -state: 'inprogress' +state: 'closed' created_at: '2026-07-15T20:04:08Z' -updated_at: '2026-07-15T22:56:59Z' +updated_at: '2026-07-15T23:00:18Z' assignee: null queued_by: 'workspace-panel' queued_at: '2026-07-15T20:27:02Z' diff --git a/.yoi/tickets/00001KXKP2A71/resolution.md b/.yoi/tickets/00001KXKP2A71/resolution.md new file mode 100644 index 00000000..fd111d4f --- /dev/null +++ b/.yoi/tickets/00001KXKP2A71/resolution.md @@ -0,0 +1,41 @@ +Knowledge support removal を実装・レビュー・merge・検証した。 + +実装内容: +- active `KnowledgeQuery` tool registration/schema exposure を削除。 +- Memory tools から `kind = knowledge` support と descriptions を削除。 +- Memory crate の Knowledge frontmatter/schema/lint/query/resident-context handling を削除。 +- Worker resident Knowledge injection と Knowledge completion state を削除。 +- protocol / TUI / web の active `#` Knowledge reference/completion path を削除。 +- Web Console の `#` completion sigil を削除し、`#...` は completion token ではなく plain/unsupported text になった。 +- old persisted `kind: "knowledge"` SystemItem は `LegacyKnowledgeIgnored` として bounded compatibility にし、model context へ replay しない。 +- `.yoi/knowledge/` は active workspace authority ではなく ignored/manual archive material として docs 更新。 +- prompts/docs/tool descriptions から active Knowledge guidance を削除。 +- Memory summary/decision/request behavior は維持。 +- Agent Skills support はこの Ticket では実装していない。 + +Review: +- 初回 review は model-visible Ticket tool description と active design docs の stale Knowledge guidance で `request_changes`。 +- 2回目 review は Web Console `#` completion が active のまま残っていた blocker で `request_changes`。 +- 3回目 review は docs/report に active Knowledge wording が残っていた blocker で `request_changes`。 +- `9f527f5e fix: remove stale report knowledge wording` 後の focused re-review は `approve`。 + +Merge / validation: +- Merge commit: `f279eb11 merge: remove knowledge support`。 +- Final validation passed: + - Focused Knowledge removal grep with only explicit legacy/manual `.yoi/knowledge` note remaining。 + - `git diff --check` + - `cargo test -p memory --lib --tests` + - `cargo test -p worker --lib --tests` + - `cargo test -p session-store --lib --tests` + - `cargo test -p tui --lib --tests` + - `cargo test -p yoi --tests` + - `cd web/workspace && deno task check` + - `cd web/workspace && deno task test` + - `cargo check -p yoi` + - `yoi ticket doctor` + - `nix build .#yoi --no-link` +- Validation log: `/run/user/1000/yoi/yoi-orchestrator/bash-output/knowledge-removal-final-validation-1784156249.txt` + +Cleanup: +- Implementation worktree/branch cleanup will be performed after close commit。 +- Per user instruction, `StopPod` is not used。 \ No newline at end of file diff --git a/.yoi/tickets/00001KXKP2A71/thread.md b/.yoi/tickets/00001KXKP2A71/thread.md index 67b2a32e..613613a7 100644 --- a/.yoi/tickets/00001KXKP2A71/thread.md +++ b/.yoi/tickets/00001KXKP2A71/thread.md @@ -390,3 +390,111 @@ Evidence: Blockers: none。 --- + + + +## Implementation report + +Merge / final validation report: + +- Reviewer approved the implementation after final docs/report wording fix。 +- Merged branch `work/00001KXKP2A71-remove-knowledge-support` into orchestration branch with merge commit `f279eb11 merge: remove knowledge support`。 +- Final validation was rerun in `/home/hare/Projects/yoi/.worktree/orchestration` after merge。 + +Validation passed: +- Focused grep for `KnowledgeQuery|kind = knowledge|kind: knowledge|ResidentKnowledge|model_invokation|\\.yoi/knowledge|#|#` with only the explicit legacy/manual `.yoi/knowledge` note remaining。 +- `git diff --check` +- `cargo test -p memory --lib --tests` +- `cargo test -p worker --lib --tests` +- `cargo test -p session-store --lib --tests` +- `cargo test -p tui --lib --tests` +- `cargo test -p yoi --tests` +- `cd web/workspace && deno task check` +- `cd web/workspace && deno task test` +- `cargo check -p yoi` +- `yoi ticket doctor` +- `nix build .#yoi --no-link` + +Validation log: +- `/run/user/1000/yoi/yoi-orchestrator/bash-output/knowledge-removal-final-validation-1784156249.txt` + +Reviewed/merged implementation commits: +- `f786e019 feat: remove active knowledge support` +- `ad666503 fix: remove stale knowledge guidance` +- `20654f9c fix: disable hash console completions` +- `9f527f5e fix: remove stale report knowledge wording` + +Notes: +- Active Knowledge tools/kind/schema/resident context/reference/completion paths were removed。 +- Old `.yoi/knowledge` data is ignored/manual archive material only。 +- Legacy Knowledge SystemItems are ignored/drop to empty history text。 +- Memory summary/decision/request behavior remains intact。 +- Agent Skills support was intentionally not implemented in this Ticket。 +- Per user instruction, no `StopPod` cleanup was performed。 + +--- + + + +## State changed + +Implementation was reviewed, merged into orchestration branch, and final validation passed. Moving to done before closure. + +--- + + + +## State changed + +Ticket を closed にしました。 + + +--- + + + +## 完了 + +Knowledge support removal を実装・レビュー・merge・検証した。 + +実装内容: +- active `KnowledgeQuery` tool registration/schema exposure を削除。 +- Memory tools から `kind = knowledge` support と descriptions を削除。 +- Memory crate の Knowledge frontmatter/schema/lint/query/resident-context handling を削除。 +- Worker resident Knowledge injection と Knowledge completion state を削除。 +- protocol / TUI / web の active `#` Knowledge reference/completion path を削除。 +- Web Console の `#` completion sigil を削除し、`#...` は completion token ではなく plain/unsupported text になった。 +- old persisted `kind: "knowledge"` SystemItem は `LegacyKnowledgeIgnored` として bounded compatibility にし、model context へ replay しない。 +- `.yoi/knowledge/` は active workspace authority ではなく ignored/manual archive material として docs 更新。 +- prompts/docs/tool descriptions から active Knowledge guidance を削除。 +- Memory summary/decision/request behavior は維持。 +- Agent Skills support はこの Ticket では実装していない。 + +Review: +- 初回 review は model-visible Ticket tool description と active design docs の stale Knowledge guidance で `request_changes`。 +- 2回目 review は Web Console `#` completion が active のまま残っていた blocker で `request_changes`。 +- 3回目 review は docs/report に active Knowledge wording が残っていた blocker で `request_changes`。 +- `9f527f5e fix: remove stale report knowledge wording` 後の focused re-review は `approve`。 + +Merge / validation: +- Merge commit: `f279eb11 merge: remove knowledge support`。 +- Final validation passed: + - Focused Knowledge removal grep with only explicit legacy/manual `.yoi/knowledge` note remaining。 + - `git diff --check` + - `cargo test -p memory --lib --tests` + - `cargo test -p worker --lib --tests` + - `cargo test -p session-store --lib --tests` + - `cargo test -p tui --lib --tests` + - `cargo test -p yoi --tests` + - `cd web/workspace && deno task check` + - `cd web/workspace && deno task test` + - `cargo check -p yoi` + - `yoi ticket doctor` + - `nix build .#yoi --no-link` +- Validation log: `/run/user/1000/yoi/yoi-orchestrator/bash-output/knowledge-removal-final-validation-1784156249.txt` + +Cleanup: +- Implementation worktree/branch cleanup will be performed after close commit。 +- Per user instruction, `StopPod` is not used。 + +---