From 084f051a4a2d855c63c78310b8bd88539d8d50ab Mon Sep 17 00:00:00 2001 From: Hare Date: Sun, 7 Jun 2026 16:53:50 +0900 Subject: [PATCH] ticket: review memory root marker --- .../item.md | 2 +- .../thread.md | 32 +++++++++++++++++++ 2 files changed, 33 insertions(+), 1 deletion(-) diff --git a/.yoi/tickets/open/20260607-062902-memory-root-uses-yoi-memory-marker/item.md b/.yoi/tickets/open/20260607-062902-memory-root-uses-yoi-memory-marker/item.md index 4baee2da..71230d87 100644 --- a/.yoi/tickets/open/20260607-062902-memory-root-uses-yoi-memory-marker/item.md +++ b/.yoi/tickets/open/20260607-062902-memory-root-uses-yoi-memory-marker/item.md @@ -8,7 +8,7 @@ priority: P1 labels: [memory, workspace, worktree, config] workflow_state: ready created_at: 2026-06-07T06:29:02Z -updated_at: 2026-06-07T07:45:55Z +updated_at: 2026-06-07T07:53:06Z assignee: null legacy_ticket: null --- diff --git a/.yoi/tickets/open/20260607-062902-memory-root-uses-yoi-memory-marker/thread.md b/.yoi/tickets/open/20260607-062902-memory-root-uses-yoi-memory-marker/thread.md index b540758e..a1689978 100644 --- a/.yoi/tickets/open/20260607-062902-memory-root-uses-yoi-memory-marker/thread.md +++ b/.yoi/tickets/open/20260607-062902-memory-root-uses-yoi-memory-marker/thread.md @@ -94,3 +94,35 @@ Scope: The child should commit implementation work in the child worktree and report diff/tests. Merge, review, Ticket closure, and cleanup remain with the parent/human workflow. --- + + + +## Implementation report + +## Implementation report + +Coder Pod `memory-root-marker-coder-20260607` completed implementation in `.worktree/memory-root-uses-yoi-memory-marker`. + +Commit: +- `9ed6613 memory: resolve repo memory by memory marker` + +Reported summary: +- Updated `WorkspaceLayout::resolve` to honor explicit `memory.workspace_root` exactly. +- Without explicit root, it searches `default_root` ancestors for the nearest `.yoi/memory` marker. +- `.yoi` alone is never treated as a memory root marker. +- If no marker exists, it falls back to `default_root` as documented no-marker compatibility behavior. +- Added focused tests for explicit root, ancestor marker selection, child worktree project records without memory, and `.yoi`-alone non-marker behavior. +- Updated `MemoryConfig` docs for marker-based implicit resolution. + +Reported validation: +- `cargo test -p memory workspace --lib` +- `cargo test -p pod memory --lib` +- `cargo test -p yoi memory` (reported no lib target) +- `cargo fmt --check` +- `git diff --check` +- `target/debug/yoi ticket doctor` +- `nix build .#yoi` + +External review will be delegated before merge. + +---