From 0a538380a965fd549628eb16a01e09bf52fb6d6a Mon Sep 17 00:00:00 2001 From: Hare Date: Sun, 31 May 2026 22:45:41 +0900 Subject: [PATCH] close: tui view mode state --- .../artifacts/.gitkeep | 0 .../item.md | 4 +-- .../resolution.md | 20 +++++++++++++ .../thread.md | 28 +++++++++++++++++++ 4 files changed, 50 insertions(+), 2 deletions(-) rename work-items/{open => closed}/20260531-074258-tui-move-view-mode-state/artifacts/.gitkeep (100%) rename work-items/{open => closed}/20260531-074258-tui-move-view-mode-state/item.md (97%) create mode 100644 work-items/closed/20260531-074258-tui-move-view-mode-state/resolution.md rename work-items/{open => closed}/20260531-074258-tui-move-view-mode-state/thread.md (61%) diff --git a/work-items/open/20260531-074258-tui-move-view-mode-state/artifacts/.gitkeep b/work-items/closed/20260531-074258-tui-move-view-mode-state/artifacts/.gitkeep similarity index 100% rename from work-items/open/20260531-074258-tui-move-view-mode-state/artifacts/.gitkeep rename to work-items/closed/20260531-074258-tui-move-view-mode-state/artifacts/.gitkeep diff --git a/work-items/open/20260531-074258-tui-move-view-mode-state/item.md b/work-items/closed/20260531-074258-tui-move-view-mode-state/item.md similarity index 97% rename from work-items/open/20260531-074258-tui-move-view-mode-state/item.md rename to work-items/closed/20260531-074258-tui-move-view-mode-state/item.md index 8523a95a..611c571e 100644 --- a/work-items/open/20260531-074258-tui-move-view-mode-state/item.md +++ b/work-items/closed/20260531-074258-tui-move-view-mode-state/item.md @@ -2,12 +2,12 @@ id: 20260531-074258-tui-move-view-mode-state slug: tui-move-view-mode-state title: TUI: move view mode state out of ui module -status: open +status: closed kind: task priority: P2 labels: [tui, cleanup] created_at: 2026-05-31T07:42:58Z -updated_at: 2026-05-31T13:45:04Z +updated_at: 2026-05-31T13:45:39Z assignee: null legacy_ticket: null --- diff --git a/work-items/closed/20260531-074258-tui-move-view-mode-state/resolution.md b/work-items/closed/20260531-074258-tui-move-view-mode-state/resolution.md new file mode 100644 index 00000000..a9461aef --- /dev/null +++ b/work-items/closed/20260531-074258-tui-move-view-mode-state/resolution.md @@ -0,0 +1,20 @@ +Moved single-Pod view/history mode state out of the render module. + +Implementation: +- Added `crates/tui/src/view_mode.rs`. +- Moved `Mode` from `ui.rs` to `view_mode.rs` without changing variants or methods. +- Updated `app.rs`, `ui.rs`, and `tool.rs` imports to use `crate::view_mode::Mode`. +- Removed the `app.rs -> ui.rs` dependency caused solely by `Mode`. +- Kept render/key/command behavior unchanged. + +Review: +- External reviewer `tui-view-mode-reviewer-20260531` approved implementation commit `bc31bfa`. + +Validation after merge: +- `cargo fmt --check` +- `cargo test -p tui mode` +- `cargo test -p tui` +- `cargo check -p tui` (passed with existing dead-code warnings) +- `./tickets.sh doctor` +- `git diff --check` +- `rg "crate::ui::Mode|ui::Mode" crates/tui/src || true` produced no active source hits. diff --git a/work-items/open/20260531-074258-tui-move-view-mode-state/thread.md b/work-items/closed/20260531-074258-tui-move-view-mode-state/thread.md similarity index 61% rename from work-items/open/20260531-074258-tui-move-view-mode-state/thread.md rename to work-items/closed/20260531-074258-tui-move-view-mode-state/thread.md index 45b3b35f..551f9858 100644 --- a/work-items/open/20260531-074258-tui-move-view-mode-state/thread.md +++ b/work-items/closed/20260531-074258-tui-move-view-mode-state/thread.md @@ -35,4 +35,32 @@ Validation adequacy: - Reviewer additionally performed read-only diff/reference checks and found no issues. +--- + + + +## Closed + +Moved single-Pod view/history mode state out of the render module. + +Implementation: +- Added `crates/tui/src/view_mode.rs`. +- Moved `Mode` from `ui.rs` to `view_mode.rs` without changing variants or methods. +- Updated `app.rs`, `ui.rs`, and `tool.rs` imports to use `crate::view_mode::Mode`. +- Removed the `app.rs -> ui.rs` dependency caused solely by `Mode`. +- Kept render/key/command behavior unchanged. + +Review: +- External reviewer `tui-view-mode-reviewer-20260531` approved implementation commit `bc31bfa`. + +Validation after merge: +- `cargo fmt --check` +- `cargo test -p tui mode` +- `cargo test -p tui` +- `cargo check -p tui` (passed with existing dead-code warnings) +- `./tickets.sh doctor` +- `git diff --check` +- `rg "crate::ui::Mode|ui::Mode" crates/tui/src || true` produced no active source hits. + + ---