From 0da2b5db7b9ec088e94f70251e2766aeda445140 Mon Sep 17 00:00:00 2001 From: Hare Date: Tue, 16 Jun 2026 01:40:07 +0900 Subject: [PATCH] ticket: complete plugin tool surface --- .yoi/tickets/00001KV5W3PHA/item.md | 4 +-- .yoi/tickets/00001KV5W3PHA/thread.md | 46 ++++++++++++++++++++++++++++ 2 files changed, 48 insertions(+), 2 deletions(-) diff --git a/.yoi/tickets/00001KV5W3PHA/item.md b/.yoi/tickets/00001KV5W3PHA/item.md index 391ea65d..7dd25711 100644 --- a/.yoi/tickets/00001KV5W3PHA/item.md +++ b/.yoi/tickets/00001KV5W3PHA/item.md @@ -1,8 +1,8 @@ --- title: 'Plugin: register enabled Tool surface from packages' -state: 'inprogress' +state: 'done' created_at: '2026-06-15T14:48:59Z' -updated_at: '2026-06-15T16:38:37Z' +updated_at: '2026-06-15T16:39:58Z' assignee: null readiness: 'implementation_ready' risk_flags: ['plugin', 'tool-registry', 'model-visible-schema', 'capability-boundary', 'profile-config'] diff --git a/.yoi/tickets/00001KV5W3PHA/thread.md b/.yoi/tickets/00001KV5W3PHA/thread.md index 9491f7e6..6f0aadf6 100644 --- a/.yoi/tickets/00001KV5W3PHA/thread.md +++ b/.yoi/tickets/00001KV5W3PHA/thread.md @@ -354,3 +354,49 @@ Conclusion: - Approved. No remaining blocker found. --- + + + +## Implementation report + +Integration report: + +Merged implementation branch into orchestration branch: +- branch: `impl/00001KV5W3PHA-plugin-tool-surface` +- implementation commits: + - `05a9c522 feat: register plugin tool surfaces` + - `3413bae7 fix: reject nested plugin tool schema errors` +- merge commit: `204d0d02 merge: plugin tool surface registration` + +Reviewer result: +- Initial review requested changes for nested invalid Plugin Tool schema validation. +- Second-pass review `approve` recorded from `yoi-reviewer-00001KV5W3PHA-r2`. + +Validation in Orchestrator worktree `/home/hare/Projects/yoi/.worktree/orchestration`: +- Passed: `cargo test -p pod plugin::tests --no-default-features` +- Passed: `cargo test -p manifest plugin --no-default-features` + - 15 passed +- Passed: `cargo check -p pod -p manifest -p llm-worker` +- Passed: `cargo fmt --check` +- Passed: `git diff --check` + +Notes: +- Broader `cargo test -p pod --no-default-features` was not rerun because coder had already reported existing unrelated prompt text assertion failures outside this change path. +- Plugin Tool registration is feature-gated and enablement-gated. +- Runtime execution remains an unavailable/runtime-missing stub; no Plugin code execution or WASM runtime was added. +- Recursive schema validation now rejects nested invalid schema nodes before model-visible registration. +- Orchestrator worktree is clean after validation. + +Cleanup planned: +- Stop related coder/reviewer Pods. +- Remove only child implementation worktree/branch for this Ticket. + +--- + + + +## State changed + +Reviewer approved after requested schema validation fix, implementation branch merged into the orchestration branch, and focused validation passed in the Orchestrator worktree. Marking Ticket done in the orchestration branch. + +---