fix: keep reviewer routing owned by coder

This commit is contained in:
2026-08-11 15:02:13 +09:00
parent 1d498d13c3
commit 133fbbe038
2 changed files with 15 additions and 1 deletions
+12
View File
@@ -1569,6 +1569,18 @@ mod tests {
assert!(reviewer.compaction.is_some()); assert!(reviewer.compaction.is_some());
} }
#[test]
fn orchestrator_role_keeps_review_routing_owned_by_coder() {
let prompt = include_str!("../../../resources/prompts/role/orchestrator.md");
assert!(prompt.contains("assigned Coder owns its review/fix loop"));
assert!(prompt.contains(
"Do not spawn, restore, assign, or route work to Backend/Runtime Reviewer Workers"
));
assert!(prompt.contains("never compensate by creating an independent Reviewer Worker"));
assert!(!prompt.contains("sibling Coder/Reviewer Workers"));
}
#[test] #[test]
fn profile_resolution_requires_runtime_worker_name() { fn profile_resolution_requires_runtime_worker_name() {
let tmp = TempDir::new().unwrap(); let tmp = TempDir::new().unwrap();
+3 -1
View File
@@ -1,6 +1,8 @@
You are the Ticket Orchestrator role. You are the Ticket Orchestrator role.
Keep durable orchestration behavior here and treat the first committed user message as concrete Ticket/action context only. Use typed Ticket tools and current repository state as authority. Record `inprogress` before implementation side effects, route concrete work to sibling Coder/Reviewer Workers when appropriate, and stop for human authority when merge/closure is not explicitly delegated. Keep durable orchestration behavior here and treat the first committed user message as concrete Ticket/action context only. Use typed Ticket tools and current repository state as authority. Record `inprogress` before implementation side effects, route implementation work to sibling Coder Workers, and stop for human authority when merge/closure is not explicitly delegated.
The assigned Coder owns its review/fix loop and launches Reviewer SubWorkers itself. Do not spawn, restore, assign, or route work to Backend/Runtime Reviewer Workers, and do not select a Reviewer profile through the generic WorkerSpawn path. If current-revision durable review evidence is missing, indeterminate, or requests changes, keep the Ticket in progress and return the requirement to the same assigned Coder; never compensate by creating an independent Reviewer Worker.
Do not create or delegate an implementation worktree/branch until the Ticket records enough agreed intent, requirements, and acceptance criteria to bound the work. Do not create or delegate an implementation worktree/branch until the Ticket records enough agreed intent, requirements, and acceptance criteria to bound the work.