From 1838865507a6dab0e21803ee6bd308fbb657a44f Mon Sep 17 00:00:00 2001 From: Hare Date: Sun, 7 Jun 2026 16:58:25 +0900 Subject: [PATCH] ticket: approve memory root marker --- .../item.md | 2 +- .../thread.md | 27 +++++++++++++++++++ 2 files changed, 28 insertions(+), 1 deletion(-) diff --git a/.yoi/tickets/open/20260607-062902-memory-root-uses-yoi-memory-marker/item.md b/.yoi/tickets/open/20260607-062902-memory-root-uses-yoi-memory-marker/item.md index 71230d87..80de4ca6 100644 --- a/.yoi/tickets/open/20260607-062902-memory-root-uses-yoi-memory-marker/item.md +++ b/.yoi/tickets/open/20260607-062902-memory-root-uses-yoi-memory-marker/item.md @@ -8,7 +8,7 @@ priority: P1 labels: [memory, workspace, worktree, config] workflow_state: ready created_at: 2026-06-07T06:29:02Z -updated_at: 2026-06-07T07:53:06Z +updated_at: 2026-06-07T07:58:15Z assignee: null legacy_ticket: null --- diff --git a/.yoi/tickets/open/20260607-062902-memory-root-uses-yoi-memory-marker/thread.md b/.yoi/tickets/open/20260607-062902-memory-root-uses-yoi-memory-marker/thread.md index a1689978..0b4cf419 100644 --- a/.yoi/tickets/open/20260607-062902-memory-root-uses-yoi-memory-marker/thread.md +++ b/.yoi/tickets/open/20260607-062902-memory-root-uses-yoi-memory-marker/thread.md @@ -126,3 +126,30 @@ Reported validation: External review will be delegated before merge. --- + + + +## Review: approve + +Approved. + +Evidence: +- Explicit `memory.workspace_root` behavior is preserved: `WorkspaceLayout::resolve` returns the explicit root before marker search. +- Implicit resolution now searches ancestors for `.yoi/memory` only, using nearest-ancestor order. +- `.yoi` alone is not treated as a memory marker; the resolver never checks `.yoi` by itself, and test coverage verifies project records alone do not define the memory marker root. +- Child worktree behavior is covered: a child `.yoi/tickets` / `.yoi/workflow` without child `.yoi/memory` resolves to the ancestor workspace that has `.yoi/memory`. +- No-marker fallback to `default_root` is acceptable for this slice as documented compatibility behavior and is not based on `.yoi` presence. A stricter no-marker-disabled behavior can be a future enable/disable redesign if desired. +- No broad memory enable/disable redesign or user-data overlay fallback was introduced. + +Reviewer validation: +- `cargo test -p memory workspace --lib` +- `cargo test -p pod memory --lib` +- `cargo fmt --check` +- `git diff --check develop...HEAD` +- `target/debug/yoi ticket doctor` +- `nix build .#yoi` +- `git merge-tree --write-tree develop HEAD` + +Merge readiness: approved; implementation worktree clean and merge-tree against current `develop` succeeded. + +---