ticket: close task domain move
This commit is contained in:
parent
61e9a18942
commit
1bf212e225
|
|
@ -2,12 +2,12 @@
|
||||||
id: 20260605-025100-task-domain-in-pod-feature
|
id: 20260605-025100-task-domain-in-pod-feature
|
||||||
slug: task-domain-in-pod-feature
|
slug: task-domain-in-pod-feature
|
||||||
title: Task: move Task domain out of tools into pod built-in feature
|
title: Task: move Task domain out of tools into pod built-in feature
|
||||||
status: open
|
status: closed
|
||||||
kind: task
|
kind: task
|
||||||
priority: P1
|
priority: P1
|
||||||
labels: [tasks, feature-registry, crate-boundary, tools]
|
labels: [tasks, feature-registry, crate-boundary, tools]
|
||||||
created_at: 2026-06-05T02:51:00Z
|
created_at: 2026-06-05T02:51:00Z
|
||||||
updated_at: 2026-06-05T03:24:54Z
|
updated_at: 2026-06-05T03:26:31Z
|
||||||
assignee: null
|
assignee: null
|
||||||
legacy_ticket: null
|
legacy_ticket: null
|
||||||
---
|
---
|
||||||
|
|
@ -0,0 +1,34 @@
|
||||||
|
Task domain consolidation into the Pod built-in Task feature is complete and merged.
|
||||||
|
|
||||||
|
Implementation commits:
|
||||||
|
|
||||||
|
- `5469335 refactor: move task feature into pod`
|
||||||
|
- `c2ed71a docs: update tui task snapshot comments`
|
||||||
|
- merge commit on `develop`: see `merge: move task domain into pod feature`
|
||||||
|
|
||||||
|
Summary:
|
||||||
|
|
||||||
|
- Moved Task domain types and store into `pod::feature::builtin::task`.
|
||||||
|
- Moved Task tool implementations into the Pod Task feature module.
|
||||||
|
- Removed production Task APIs from `tools`, including `tools::TaskStore`, Task type re-exports, `tools::task_tools`, and Task-bearing `builtin_tools(...)`.
|
||||||
|
- Kept non-Task `tools::core_builtin_tools(...)` and tracker/non-Task tool behavior intact.
|
||||||
|
- Preserved Task tool schema/output behavior, Task snapshot/replay semantics, reminder hooks/state, and snapshot/restore/rewind/compaction façade.
|
||||||
|
- Updated TUI compatibility tests to use local fixtures without adding a production dependency on `pod` or `tools`.
|
||||||
|
|
||||||
|
Review:
|
||||||
|
|
||||||
|
- External sibling reviewer approved with no blockers.
|
||||||
|
- Reviewer non-blocker about stale TUI comments was fixed before merge.
|
||||||
|
- Remaining accepted residual risk: local TUI fixtures can drift if Pod-owned Task snapshot format changes.
|
||||||
|
|
||||||
|
Post-merge validation passed on main workspace:
|
||||||
|
|
||||||
|
- `cargo test -p pod task --lib`
|
||||||
|
- `cargo test -p tools --lib`
|
||||||
|
- `cargo test -p tools --tests`
|
||||||
|
- `cargo test -p tui task --lib`
|
||||||
|
- `cargo fmt --check`
|
||||||
|
- `git diff --check`
|
||||||
|
- `./tickets.sh doctor`
|
||||||
|
- `cargo check --workspace --all-targets`
|
||||||
|
- search for remaining production `tools` Task APIs returned no matches
|
||||||
|
|
@ -314,4 +314,46 @@ External sibling reviewer approved with no blockers. The only code/comment follo
|
||||||
The remaining residual risk is TUI fixture drift if the Pod-owned Task snapshot format changes without updating local TUI compatibility fixtures. This is accepted for this ticket because it avoids an undesirable production dependency from TUI back to Pod or tools.
|
The remaining residual risk is TUI fixture drift if the Pod-owned Task snapshot format changes without updating local TUI compatibility fixtures. This is accepted for this ticket because it avoids an undesirable production dependency from TUI back to Pod or tools.
|
||||||
|
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
<!-- event: close author: hare at: 2026-06-05T03:26:31Z status: closed -->
|
||||||
|
|
||||||
|
## Closed
|
||||||
|
|
||||||
|
Task domain consolidation into the Pod built-in Task feature is complete and merged.
|
||||||
|
|
||||||
|
Implementation commits:
|
||||||
|
|
||||||
|
- `5469335 refactor: move task feature into pod`
|
||||||
|
- `c2ed71a docs: update tui task snapshot comments`
|
||||||
|
- merge commit on `develop`: see `merge: move task domain into pod feature`
|
||||||
|
|
||||||
|
Summary:
|
||||||
|
|
||||||
|
- Moved Task domain types and store into `pod::feature::builtin::task`.
|
||||||
|
- Moved Task tool implementations into the Pod Task feature module.
|
||||||
|
- Removed production Task APIs from `tools`, including `tools::TaskStore`, Task type re-exports, `tools::task_tools`, and Task-bearing `builtin_tools(...)`.
|
||||||
|
- Kept non-Task `tools::core_builtin_tools(...)` and tracker/non-Task tool behavior intact.
|
||||||
|
- Preserved Task tool schema/output behavior, Task snapshot/replay semantics, reminder hooks/state, and snapshot/restore/rewind/compaction façade.
|
||||||
|
- Updated TUI compatibility tests to use local fixtures without adding a production dependency on `pod` or `tools`.
|
||||||
|
|
||||||
|
Review:
|
||||||
|
|
||||||
|
- External sibling reviewer approved with no blockers.
|
||||||
|
- Reviewer non-blocker about stale TUI comments was fixed before merge.
|
||||||
|
- Remaining accepted residual risk: local TUI fixtures can drift if Pod-owned Task snapshot format changes.
|
||||||
|
|
||||||
|
Post-merge validation passed on main workspace:
|
||||||
|
|
||||||
|
- `cargo test -p pod task --lib`
|
||||||
|
- `cargo test -p tools --lib`
|
||||||
|
- `cargo test -p tools --tests`
|
||||||
|
- `cargo test -p tui task --lib`
|
||||||
|
- `cargo fmt --check`
|
||||||
|
- `git diff --check`
|
||||||
|
- `./tickets.sh doctor`
|
||||||
|
- `cargo check --workspace --all-targets`
|
||||||
|
- search for remaining production `tools` Task APIs returned no matches
|
||||||
|
|
||||||
|
|
||||||
---
|
---
|
||||||
Loading…
Reference in New Issue
Block a user