From 20cc77573b1b7f01dfc8f43c705f93b1cf5a7fec Mon Sep 17 00:00:00 2001 From: Hare Date: Thu, 18 Jun 2026 23:16:32 +0900 Subject: [PATCH] ticket: dispatch reviewers for implementation branches --- .yoi/tickets/00001KV5W3PJ3/item.md | 2 +- .yoi/tickets/00001KV5W3PJ3/thread.md | 27 +++++++++++++++++++++++++++ .yoi/tickets/00001KVDETSN6/item.md | 2 +- .yoi/tickets/00001KVDETSN6/thread.md | 26 ++++++++++++++++++++++++++ 4 files changed, 55 insertions(+), 2 deletions(-) diff --git a/.yoi/tickets/00001KV5W3PJ3/item.md b/.yoi/tickets/00001KV5W3PJ3/item.md index bf0cb5ae..9a0c1631 100644 --- a/.yoi/tickets/00001KV5W3PJ3/item.md +++ b/.yoi/tickets/00001KV5W3PJ3/item.md @@ -2,7 +2,7 @@ title: 'Plugin: enforce Plugin permission grants' state: 'inprogress' created_at: '2026-06-15T14:48:59Z' -updated_at: '2026-06-18T14:15:12Z' +updated_at: '2026-06-18T14:16:18Z' assignee: null readiness: 'implementation_ready' risk_flags: ['plugin', 'permission', 'grant-enforcement', 'capability-boundary', 'tool-execution'] diff --git a/.yoi/tickets/00001KV5W3PJ3/thread.md b/.yoi/tickets/00001KV5W3PJ3/thread.md index 95b2d387..2b2d6259 100644 --- a/.yoi/tickets/00001KV5W3PJ3/thread.md +++ b/.yoi/tickets/00001KV5W3PJ3/thread.md @@ -195,3 +195,30 @@ Next action: - 特に fail-closed grant enforcement、source/digest/version binding、no ambient authority、external_write/effect metadata、bounded diagnostics、existing PreToolCall path との整合性を確認する。 --- + + + +## Plan + +Review dispatch: + +Reviewer Pod `yoi-reviewer-00001KV5W3PJ3` を read-only scope で起動した。 + +Review target: +- worktree: `/home/hare/Projects/yoi/.worktree/00001KV5W3PJ3-plugin-permission-grants` +- branch: `impl/00001KV5W3PJ3-plugin-permission-grants` +- commit: `b1ba1599` + +Reviewer focus: +- recorded intent / invariants / acceptance criteria に対する適合性。 +- registration / execution の fail-closed grant enforcement。 +- source-qualified identity / digest / version binding。 +- unrelated grant / digest mismatch / missing surface/tool/external_write / unknown kind の拒否。 +- `external_write` と Tool effect / PreToolCall path の整合性。 +- future `https` / `fs` host API permission boundary が ambient authority を作っていないこと。 +- bounded safe diagnostics。 + +Next: +- Reviewer output を確認し、approve なら Ticket review に記録して merge-ready 判断へ進む。request_changes なら Coder に修正依頼する。 + +--- diff --git a/.yoi/tickets/00001KVDETSN6/item.md b/.yoi/tickets/00001KVDETSN6/item.md index 6359892c..43ea1c6c 100644 --- a/.yoi/tickets/00001KVDETSN6/item.md +++ b/.yoi/tickets/00001KVDETSN6/item.md @@ -2,7 +2,7 @@ title: 'Panel startup latency をユーザー目線の dashboard content ready 基準で計測・改善する' state: 'inprogress' created_at: '2026-06-18T13:30:51Z' -updated_at: '2026-06-18T14:15:27Z' +updated_at: '2026-06-18T14:16:26Z' assignee: null readiness: 'implementation_ready' risk_flags: ['panel', 'e2e', 'startup-latency', 'user-visible-readiness', 'dashboard-content', 'profiling'] diff --git a/.yoi/tickets/00001KVDETSN6/thread.md b/.yoi/tickets/00001KVDETSN6/thread.md index 734404be..3909756f 100644 --- a/.yoi/tickets/00001KVDETSN6/thread.md +++ b/.yoi/tickets/00001KVDETSN6/thread.md @@ -178,3 +178,29 @@ Next action: - 特に dashboard content ready が名前だけの metric ではないこと、fixture が live-like な representative dashboard content を検証していること、single-row readiness だけでは通らないこと、negative fixtures が有効であること、Panel semantics を accidental に変更していないことを確認する。 --- + + + +## Plan + +Review dispatch: + +Reviewer Pod `yoi-reviewer-00001KVDETSN6` を read-only scope で起動した。 + +Review target: +- worktree: `/home/hare/Projects/yoi/.worktree/00001KVDETSN6-panel-dashboard-content-ready` +- branch: `impl/00001KVDETSN6-panel-dashboard-content-ready` +- commit: `fc1ee5bb` + +Reviewer focus: +- recorded intent / invariants / acceptance criteria に対する適合性。 +- `dashboard_content_ready` が名前だけの metric ではなく、代表 dashboard content の expected row/content set に基づくこと。 +- first frame / single-row readiness だけでは主 E2E が通らないこと。 +- missing dashboard content / missing orchestration overlay の negative fixtures が意味を持つこと。 +- startup source breakdown が bounded で regression triage に使えること。 +- Existing Panel behavior / workflow semantics を accidental に変更していないこと。 + +Next: +- Reviewer output を確認し、approve なら Ticket review に記録して merge-ready 判断へ進む。request_changes なら Coder に修正依頼する。 + +---