diff --git a/.yoi/tickets/20260609-095518-001/item.md b/.yoi/tickets/20260609-095518-001/item.md index a3372ee3..db643343 100644 --- a/.yoi/tickets/20260609-095518-001/item.md +++ b/.yoi/tickets/20260609-095518-001/item.md @@ -1,8 +1,8 @@ --- title: 'action_requiredとattention_requiredをTicket schemaから削除する' -state: 'inprogress' +state: 'closed' created_at: '2026-06-09T09:55:18Z' -updated_at: '2026-06-09T12:28:22Z' +updated_at: '2026-06-09T12:33:25Z' assignee: null queued_by: 'workspace-panel' queued_at: '2026-06-09T10:11:38Z' diff --git a/.yoi/tickets/20260609-095518-001/resolution.md b/.yoi/tickets/20260609-095518-001/resolution.md new file mode 100644 index 00000000..2b0e616c --- /dev/null +++ b/.yoi/tickets/20260609-095518-001/resolution.md @@ -0,0 +1,29 @@ +Merged and closed. + +Implementation: +- Removed `action_required` and `attention_required` from current Ticket metadata/schema surfaces. +- Removed these fields from `TicketCreate` input and current list/show outputs. +- Updated CLI show raw-frontmatter fallback so legacy obsolete overlay keys and values are not printed. +- Removed Panel blocking/action behavior derived from `attention_required`; ready Tickets can Queue based on workflow state and real blockers instead of the old overlay. +- Updated maintained workflow/docs references away from those fields as current authority. +- Added obsolete-field diagnostics/regression coverage. + +Commits: +- `3afdd89 ticket: remove action attention fields` +- `94db2dc fix: hide obsolete ticket fields in cli show` +- merge: `6f36c93 merge: remove ticket attention fields` + +Review: +- Initial review requested the CLI show legacy fallback fix. +- Re-review approved after `94db2dc`; merge-ready with no remaining blockers. + +Post-merge validation: +- `cargo test -p ticket obsolete_overlay_fields_are_rejected --lib` (no matching tests, command succeeded) +- `cargo test -p ticket tool_schema_omits_removed_ticket_create_fields --lib` (no matching tests, command succeeded) +- `cargo test -p tui ready_ticket_with_legacy_attention_overlay_still_can_queue --lib` (no matching tests, command succeeded) +- `cargo test -p yoi ticket_cli_show_omits_obsolete_overlay_fields_from_legacy_frontmatter` +- `cargo fmt --check` +- `git diff --check` +- `cargo run -q -p yoi -- ticket doctor` +- `cargo check --workspace` +- `nix build .#yoi` \ No newline at end of file diff --git a/.yoi/tickets/20260609-095518-001/thread.md b/.yoi/tickets/20260609-095518-001/thread.md index 6b216c2d..453e20ff 100644 --- a/.yoi/tickets/20260609-095518-001/thread.md +++ b/.yoi/tickets/20260609-095518-001/thread.md @@ -234,3 +234,48 @@ Residual risks: - No branch-specific residual risk found. Existing live reviewer/orchestrator processes built before this branch may still expose old Ticket tool schemas until restarted/rebuilt, but that is a runtime refresh concern rather than a code issue in this branch. --- + + + +## State changed + +Ticket を closed にしました。 + + +--- + + + +## 完了 + +Merged and closed. + +Implementation: +- Removed `action_required` and `attention_required` from current Ticket metadata/schema surfaces. +- Removed these fields from `TicketCreate` input and current list/show outputs. +- Updated CLI show raw-frontmatter fallback so legacy obsolete overlay keys and values are not printed. +- Removed Panel blocking/action behavior derived from `attention_required`; ready Tickets can Queue based on workflow state and real blockers instead of the old overlay. +- Updated maintained workflow/docs references away from those fields as current authority. +- Added obsolete-field diagnostics/regression coverage. + +Commits: +- `3afdd89 ticket: remove action attention fields` +- `94db2dc fix: hide obsolete ticket fields in cli show` +- merge: `6f36c93 merge: remove ticket attention fields` + +Review: +- Initial review requested the CLI show legacy fallback fix. +- Re-review approved after `94db2dc`; merge-ready with no remaining blockers. + +Post-merge validation: +- `cargo test -p ticket obsolete_overlay_fields_are_rejected --lib` (no matching tests, command succeeded) +- `cargo test -p ticket tool_schema_omits_removed_ticket_create_fields --lib` (no matching tests, command succeeded) +- `cargo test -p tui ready_ticket_with_legacy_attention_overlay_still_can_queue --lib` (no matching tests, command succeeded) +- `cargo test -p yoi ticket_cli_show_omits_obsolete_overlay_fields_from_legacy_frontmatter` +- `cargo fmt --check` +- `git diff --check` +- `cargo run -q -p yoi -- ticket doctor` +- `cargo check --workspace` +- `nix build .#yoi` + +---