ticket: close remove tickets shell shim
This commit is contained in:
parent
da760e646d
commit
2eb396d22c
|
|
@ -2,12 +2,12 @@
|
||||||
id: 20260605-203006-remove-tickets-sh
|
id: 20260605-203006-remove-tickets-sh
|
||||||
slug: remove-tickets-sh
|
slug: remove-tickets-sh
|
||||||
title: Remove tickets.sh compatibility CLI
|
title: Remove tickets.sh compatibility CLI
|
||||||
status: open
|
status: closed
|
||||||
kind: task
|
kind: task
|
||||||
priority: P1
|
priority: P1
|
||||||
labels: [ticket, cleanup, cli]
|
labels: [ticket, cleanup, cli]
|
||||||
created_at: 2026-06-05T20:30:06Z
|
created_at: 2026-06-05T20:30:06Z
|
||||||
updated_at: 2026-06-05T21:52:55Z
|
updated_at: 2026-06-05T22:13:36Z
|
||||||
assignee: null
|
assignee: null
|
||||||
legacy_ticket: null
|
legacy_ticket: null
|
||||||
---
|
---
|
||||||
|
|
@ -0,0 +1,32 @@
|
||||||
|
Removed the transitional `tickets.sh` mutation path.
|
||||||
|
|
||||||
|
Changes:
|
||||||
|
- Deleted repository-root `tickets.sh`.
|
||||||
|
- Updated active docs, workflows, project instructions, and tests from `./tickets.sh` to `yoi ticket ...` / `yoi ticket doctor`.
|
||||||
|
- Removed shell compatibility tests that executed the script and kept Rust backend / `yoi ticket` coverage.
|
||||||
|
- Removed the remaining top-level `work-items/README.md` legacy notice after merge so the repository-root `work-items/` path is no longer present.
|
||||||
|
- Preserved `.yoi/tickets/` as the active Ticket storage root.
|
||||||
|
|
||||||
|
Validation after merge:
|
||||||
|
- `cargo test -p ticket`
|
||||||
|
- `cargo test -p yoi ticket`
|
||||||
|
- `cargo test -p pod ticket --lib`
|
||||||
|
- `cargo check --workspace --all-targets`
|
||||||
|
- `cargo fmt --check`
|
||||||
|
- `git diff --check HEAD~1..HEAD`
|
||||||
|
- `cargo build -p yoi`
|
||||||
|
- `target/debug/yoi ticket doctor`
|
||||||
|
- `test ! -e tickets.sh`
|
||||||
|
- active docs/code grep for `tickets.sh` / `./tickets.sh`
|
||||||
|
- `nix build .#yoi --no-link --print-out-paths`
|
||||||
|
|
||||||
|
Additional post-merge cleanup validation:
|
||||||
|
- `target/debug/yoi ticket doctor`
|
||||||
|
- `test ! -e tickets.sh`
|
||||||
|
- `test ! -e work-items`
|
||||||
|
- active docs/code grep for `tickets.sh` / `./tickets.sh`
|
||||||
|
- `git diff --check`
|
||||||
|
|
||||||
|
External review approved; a non-blocking stale "compatibility CLI" phrase was fixed before merge.
|
||||||
|
|
||||||
|
The umbrella `yoi-local-ticket-backend-migration` can be closed.
|
||||||
|
|
@ -0,0 +1,78 @@
|
||||||
|
<!-- event: create author: tickets.sh at: 2026-06-05T20:30:06Z -->
|
||||||
|
|
||||||
|
## Created
|
||||||
|
|
||||||
|
Created by tickets.sh create.
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
<!-- event: plan author: hare at: 2026-06-05T21:52:55Z -->
|
||||||
|
|
||||||
|
## Plan
|
||||||
|
|
||||||
|
Preflight result: `implementation-ready` after storage migration.
|
||||||
|
|
||||||
|
`yoi ticket` has parity and active storage has moved to `.yoi/tickets/`, so `tickets.sh` should now be removed to eliminate the temporary second mutation path. Active docs/project instructions/tests should use `yoi ticket ...`; historical closed records and old report artifacts do not need mass rewriting.
|
||||||
|
|
||||||
|
Detailed delegation intent is recorded in `artifacts/delegation-intent.md`.
|
||||||
|
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
<!-- event: review author: hare at: 2026-06-05T22:13:36Z status: approve -->
|
||||||
|
|
||||||
|
## Review: approve
|
||||||
|
|
||||||
|
External reviewer approved the implementation with one non-blocking stale phrase in `docs/development/work-items.md`.
|
||||||
|
|
||||||
|
The stale phrase was fixed before merge. After merge, the remaining top-level `work-items/README.md` legacy notice was also removed so the repository-root `work-items/` path is not present as an active or compatibility surface.
|
||||||
|
|
||||||
|
Review summary:
|
||||||
|
- `tickets.sh` is deleted.
|
||||||
|
- Active docs/project instructions/tests use `yoi ticket ...` and `yoi ticket doctor`.
|
||||||
|
- No production code or tests execute `./tickets.sh`.
|
||||||
|
- `.yoi/tickets/` remains the active Ticket storage root.
|
||||||
|
- Remaining references are historical records/spec context, not active command instructions.
|
||||||
|
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
<!-- event: close author: hare at: 2026-06-05T22:13:36Z status: closed -->
|
||||||
|
|
||||||
|
## Closed
|
||||||
|
|
||||||
|
Removed the transitional `tickets.sh` mutation path.
|
||||||
|
|
||||||
|
Changes:
|
||||||
|
- Deleted repository-root `tickets.sh`.
|
||||||
|
- Updated active docs, workflows, project instructions, and tests from `./tickets.sh` to `yoi ticket ...` / `yoi ticket doctor`.
|
||||||
|
- Removed shell compatibility tests that executed the script and kept Rust backend / `yoi ticket` coverage.
|
||||||
|
- Removed the remaining top-level `work-items/README.md` legacy notice after merge so the repository-root `work-items/` path is no longer present.
|
||||||
|
- Preserved `.yoi/tickets/` as the active Ticket storage root.
|
||||||
|
|
||||||
|
Validation after merge:
|
||||||
|
- `cargo test -p ticket`
|
||||||
|
- `cargo test -p yoi ticket`
|
||||||
|
- `cargo test -p pod ticket --lib`
|
||||||
|
- `cargo check --workspace --all-targets`
|
||||||
|
- `cargo fmt --check`
|
||||||
|
- `git diff --check HEAD~1..HEAD`
|
||||||
|
- `cargo build -p yoi`
|
||||||
|
- `target/debug/yoi ticket doctor`
|
||||||
|
- `test ! -e tickets.sh`
|
||||||
|
- active docs/code grep for `tickets.sh` / `./tickets.sh`
|
||||||
|
- `nix build .#yoi --no-link --print-out-paths`
|
||||||
|
|
||||||
|
Additional post-merge cleanup validation:
|
||||||
|
- `target/debug/yoi ticket doctor`
|
||||||
|
- `test ! -e tickets.sh`
|
||||||
|
- `test ! -e work-items`
|
||||||
|
- active docs/code grep for `tickets.sh` / `./tickets.sh`
|
||||||
|
- `git diff --check`
|
||||||
|
|
||||||
|
External review approved; a non-blocking stale "compatibility CLI" phrase was fixed before merge.
|
||||||
|
|
||||||
|
The umbrella `yoi-local-ticket-backend-migration` can be closed.
|
||||||
|
|
||||||
|
|
||||||
|
---
|
||||||
|
|
@ -1,20 +0,0 @@
|
||||||
<!-- event: create author: tickets.sh at: 2026-06-05T20:30:06Z -->
|
|
||||||
|
|
||||||
## Created
|
|
||||||
|
|
||||||
Created by tickets.sh create.
|
|
||||||
|
|
||||||
---
|
|
||||||
|
|
||||||
<!-- event: plan author: hare at: 2026-06-05T21:52:55Z -->
|
|
||||||
|
|
||||||
## Plan
|
|
||||||
|
|
||||||
Preflight result: `implementation-ready` after storage migration.
|
|
||||||
|
|
||||||
`yoi ticket` has parity and active storage has moved to `.yoi/tickets/`, so `tickets.sh` should now be removed to eliminate the temporary second mutation path. Active docs/project instructions/tests should use `yoi ticket ...`; historical closed records and old report artifacts do not need mass rewriting.
|
|
||||||
|
|
||||||
Detailed delegation intent is recorded in `artifacts/delegation-intent.md`.
|
|
||||||
|
|
||||||
|
|
||||||
---
|
|
||||||
|
|
@ -399,7 +399,7 @@ The current LocalTicketBackend stores records under:
|
||||||
resolution.md # closed Tickets only
|
resolution.md # closed Tickets only
|
||||||
```
|
```
|
||||||
|
|
||||||
Backend integrations must preserve this format until an explicit migration changes it. The repository-root `work-items/` directory is a legacy notice only, not a live mutable backend. Human users should prefer TUI role actions or Ticket tools; maintainers may use `yoi ticket ...` when working directly with repository records.
|
Backend integrations must preserve this format until an explicit migration changes it. The repository-root `work-items/` path is no longer a live mutable backend; do not recreate it for Ticket records. Human users should prefer TUI role actions or Ticket tools; maintainers may use `yoi ticket ...` when working directly with repository records.
|
||||||
|
|
||||||
## Validation
|
## Validation
|
||||||
|
|
||||||
|
|
|
||||||
|
|
@ -1,7 +0,0 @@
|
||||||
# Legacy work-items notice
|
|
||||||
|
|
||||||
Active Yoi Ticket storage has moved to `.yoi/tickets/`.
|
|
||||||
|
|
||||||
This directory is intentionally not a live mutable backend. It remains only as a compatibility notice for older references and migration history. Do not create `open/`, `pending/`, or `closed/` Ticket records here.
|
|
||||||
|
|
||||||
Use `yoi ticket ...` or Ticket tools; both operate on the active `.yoi/tickets/` storage.
|
|
||||||
Loading…
Reference in New Issue
Block a user