Hare/yoi
1
1
Fork 0
Code Actions Packages Releases Activity

fix: preserve multiple positional invocation arguments and update API schema

Browse Source
This commit is contained in:
Hare
2026-10-05 19:07:23 +09:00
parent f7783b3d2a
commit 31f7847d1f
3 changed files with 498 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
web/workspace/src/lib/workspace/console/composer-invocation.test.ts
+21
View File
@@ -65,6 +65,27 @@ Deno.test("selected invocation parsing preserves Unicode, spaces, slashes, prose
]);
});
Deno.test("multiple positional arguments advance once per value independent of descriptor order", () => {
const positional: FeatureInvocationDescriptor = {
...descriptor,
arguments: [
{ name: "enabled", position: 2, required: true, value_type: { kind: "boolean" }, completion: { kind: "none" } },
{ name: "mode", position: 0, required: true, value_type: { kind: "enum", values: ["brief", "full"] }, completion: { kind: "none" } },
{ name: "limit", position: 1, required: true, value_type: { kind: "integer" }, completion: { kind: "none" } },
{ name: "note", required: false, value_type: { kind: "string" }, completion: { kind: "none" } },
],
};
for (const input of ['/run("brief", 2, true) following prose', '/run("brief", note="資料/a b", 2, true) following prose']) {
const parsed = selectedFeatureInvocationRanges(input, [positional])[0];
assertEquals(input.slice(parsed.end), " following prose");
assertEquals(parsed.invocation.arguments.filter((argument) => argument.name !== "note"), [
{ name: "mode", value: { kind: "string", value: "brief" } },
{ name: "limit", value: { kind: "integer", value: 2 } },
{ name: "enabled", value: { kind: "boolean", value: true } },
]);
}
});
Deno.test("unselected text, URLs, paths, and paste content are never promoted", () => {
assertEquals(
finalizeSelectedFeatureInvocations(
web/workspace/src/lib/workspace/console/composer-invocation.ts
+2 -1
View File
@@ -278,7 +278,8 @@ function parseFeatureInvocation(
while (/\s/.test(text[cursor] ?? "")) cursor++;
} else {
cursor = itemStart;
argument = descriptor.arguments.find((candidate) => candidate.position === position++);
argument = descriptor.arguments.find((candidate) => candidate.position === position);
position++;
if (!argument) throw new Error("Too many positional Feature arguments.");
}
const parsed = parseRawValue(text, cursor);