From 3315fa545804582af3af67c59a22c7cf6d722768 Mon Sep 17 00:00:00 2001 From: Hare Date: Tue, 7 Jul 2026 05:45:40 +0900 Subject: [PATCH] ticket: record workspace id route review fixes --- .yoi/tickets/00001KWWE8E04/item.md | 2 +- .yoi/tickets/00001KWWE8E04/thread.md | 27 +++++++++++++++++++++++++++ 2 files changed, 28 insertions(+), 1 deletion(-) diff --git a/.yoi/tickets/00001KWWE8E04/item.md b/.yoi/tickets/00001KWWE8E04/item.md index 89f130ae..444f5dca 100644 --- a/.yoi/tickets/00001KWWE8E04/item.md +++ b/.yoi/tickets/00001KWWE8E04/item.md @@ -2,7 +2,7 @@ title: 'Scope Workspace Browser routes and API by workspace id' state: 'inprogress' created_at: '2026-07-06T19:25:08Z' -updated_at: '2026-07-06T20:36:50Z' +updated_at: '2026-07-06T20:45:34Z' assignee: null queued_by: 'workspace-panel' queued_at: '2026-07-06T19:53:14Z' diff --git a/.yoi/tickets/00001KWWE8E04/thread.md b/.yoi/tickets/00001KWWE8E04/thread.md index 051887cc..04ad53e6 100644 --- a/.yoi/tickets/00001KWWE8E04/thread.md +++ b/.yoi/tickets/00001KWWE8E04/thread.md @@ -216,3 +216,30 @@ Non-blocking follow-ups: - redirect/shared-route refactor 後、scoped settings/workers/console endpoints の direct coverage を増やすとよい。 --- + + + +## Implementation report + +Review-fix implementation report: + +- Coder Pod completed requested changes and committed follow-up `71340b89 fix: redirect unscoped workspace routes` on branch `work/00001KWWE8E04-workspace-id-routes`. +- Worktree status was clean after commit. +- Fix summary: + - `+layout.ts` now uses `/api/workspace` only as bootstrap when route `workspaceId` is absent, then redirects to `/w/...`。 + - Silent `/api${path}` fallback for workspace-scoped data was removed。 + - Unscoped root/objectives/repository/settings/worker-console routes are thin redirect/shim surfaces instead of duplicated full data/control pages。 + - Backend SPA fallback redirects unscoped Browser routes such as `/objectives?...` to `/w//objectives?...`。 + - Canonical maintained page/control logic remains under `/w/[workspaceId]/**`。 + - Added/updated focused tests for bootstrap-then-redirect behavior, no unscoped workspace API fallback, thin settings shim, backend unscoped UI redirect, and canonical worker console scoped route references。 +- Orchestrator reran validation in the implementation worktree: + - `git diff --check`: pass + - `cd web/workspace && deno task check`: pass（0 errors / 0 warnings） + - `cd web/workspace && deno task test`: pass（17 tests） + - `cargo test -p yoi-workspace-server`: pass（65 lib tests + 2 main tests） + - `cargo check -p yoi`: pass + - `yoi ticket doctor`: ok +- `nix build .#yoi --no-link` は Cargo.lock / dependency / resource packaging / Nix 変更ではないため未実行。 +- Requesting follow-up external review against `f6ad9cfc..71340b89` and full combined implementation。 + +---