ticket: close memory root marker

This commit is contained in:
Keisuke Hirata 2026-06-07 16:59:18 +09:00
parent 297b66838b
commit 383b655072
No known key found for this signature in database
4 changed files with 69 additions and 3 deletions

View File

@ -2,13 +2,13 @@
id: 20260607-062902-memory-root-uses-yoi-memory-marker id: 20260607-062902-memory-root-uses-yoi-memory-marker
slug: memory-root-uses-yoi-memory-marker slug: memory-root-uses-yoi-memory-marker
title: Use .yoi/memory marker for repo-local memory root title: Use .yoi/memory marker for repo-local memory root
status: open status: closed
kind: task kind: task
priority: P1 priority: P1
labels: [memory, workspace, worktree, config] labels: [memory, workspace, worktree, config]
workflow_state: ready workflow_state: done
created_at: 2026-06-07T06:29:02Z created_at: 2026-06-07T06:29:02Z
updated_at: 2026-06-07T07:58:15Z updated_at: 2026-06-07T07:59:04Z
assignee: null assignee: null
legacy_ticket: null legacy_ticket: null
--- ---

View File

@ -0,0 +1,25 @@
Implemented, reviewed, merged, and validated.
Summary:
- Kept `.yoi` as the Yoi project records marker while stopping `.yoi` alone from acting as the memory root marker.
- `WorkspaceLayout::resolve` still honors explicit `memory.workspace_root` exactly.
- Without explicit root, memory layout resolution now walks ancestors from the default root and selects the nearest ancestor containing `.yoi/memory`.
- Child worktrees containing `.yoi/tickets` / `.yoi/workflow` but no `.yoi/memory` do not become independent memory roots when an ancestor `.yoi/memory` exists.
- `.yoi` project records alone do not define a memory marker root.
- No-marker fallback remains `default_root` as documented compatibility behavior, without relying on `.yoi` presence.
- No broad memory enable/disable redesign or user-data overlay fallback was introduced.
- `MemoryConfig` docs were updated to describe marker-based implicit resolution.
Implementation:
- Child commit: `9ed6613 memory: resolve repo memory by memory marker`
- Merge commit: `merge: memory root marker`
Review:
- External reviewer `memory-root-marker-reviewer-20260607` approved with no blockers.
Validation after merge:
- `cargo test -p memory workspace --lib`
- `cargo test -p pod memory --lib`
- `cargo fmt --check`
- `git diff --check`
- `target/debug/yoi ticket doctor`

View File

@ -153,3 +153,44 @@ Reviewer validation:
Merge readiness: approved; implementation worktree clean and merge-tree against current `develop` succeeded. Merge readiness: approved; implementation worktree clean and merge-tree against current `develop` succeeded.
--- ---
<!-- event: state_changed author: hare at: 2026-06-07T07:59:04Z from: ready to: done reason: closed field: workflow_state -->
## State changed
Ticket closed; workflow_state set to done.
---
<!-- event: close author: hare at: 2026-06-07T07:59:04Z status: closed -->
## Closed
Implemented, reviewed, merged, and validated.
Summary:
- Kept `.yoi` as the Yoi project records marker while stopping `.yoi` alone from acting as the memory root marker.
- `WorkspaceLayout::resolve` still honors explicit `memory.workspace_root` exactly.
- Without explicit root, memory layout resolution now walks ancestors from the default root and selects the nearest ancestor containing `.yoi/memory`.
- Child worktrees containing `.yoi/tickets` / `.yoi/workflow` but no `.yoi/memory` do not become independent memory roots when an ancestor `.yoi/memory` exists.
- `.yoi` project records alone do not define a memory marker root.
- No-marker fallback remains `default_root` as documented compatibility behavior, without relying on `.yoi` presence.
- No broad memory enable/disable redesign or user-data overlay fallback was introduced.
- `MemoryConfig` docs were updated to describe marker-based implicit resolution.
Implementation:
- Child commit: `9ed6613 memory: resolve repo memory by memory marker`
- Merge commit: `merge: memory root marker`
Review:
- External reviewer `memory-root-marker-reviewer-20260607` approved with no blockers.
Validation after merge:
- `cargo test -p memory workspace --lib`
- `cargo test -p pod memory --lib`
- `cargo fmt --check`
- `git diff --check`
- `target/debug/yoi ticket doctor`
---