ticket: close language guidance
This commit is contained in:
parent
2ba97b674e
commit
3bcf677768
|
|
@ -1,8 +1,8 @@
|
||||||
---
|
---
|
||||||
title: 'Ticket language guidance must apply to all Ticket tool users'
|
title: 'Ticket language guidance must apply to all Ticket tool users'
|
||||||
state: 'done'
|
state: 'closed'
|
||||||
created_at: '2026-06-11T14:48:44Z'
|
created_at: '2026-06-11T14:48:44Z'
|
||||||
updated_at: '2026-06-12T15:19:29Z'
|
updated_at: '2026-06-12T15:20:11Z'
|
||||||
assignee: null
|
assignee: null
|
||||||
readiness: 'implementation_ready'
|
readiness: 'implementation_ready'
|
||||||
risk_flags: ['prompt-context', 'tool-description', 'feature-boundary', 'ticket-language', 'companion']
|
risk_flags: ['prompt-context', 'tool-description', 'feature-boundary', 'ticket-language', 'companion']
|
||||||
|
|
|
||||||
35
.yoi/tickets/00001KTVJGC0Y/resolution.md
Normal file
35
.yoi/tickets/00001KTVJGC0Y/resolution.md
Normal file
|
|
@ -0,0 +1,35 @@
|
||||||
|
Ticket tool users 全体に `ticket.language` guidance が届くようにした。
|
||||||
|
|
||||||
|
実装概要:
|
||||||
|
- `crates/ticket/src/tool.rs` に shared `ticket_tool_description(name, record_language)` を追加し、configured `ticket.language` がある場合は Ticket tool description に durable Ticket record / Ticket tool body language guidance を追加するようにした。
|
||||||
|
- `crates/pod/src/feature/builtin/ticket.rs` の builtin Ticket feature `ToolDeclaration` descriptions でも同じ helper を使い、read-only Companion-style context と lifecycle/Ticket-role-style context の両方に guidance が届くようにした。
|
||||||
|
- guidance は `worker.language` / `memory.language` / `ticket.language` を区別し、protocol literals、file paths、commands、logs、identifiers、quoted external text は fidelity 優先で保持することを明記した。
|
||||||
|
- guidance は Ticket tool / capability surface で model-visible であり、hidden context injection や `ticket_role` launch prompt fragment ではない。
|
||||||
|
- Companion/read-only authority や mutating tool exposure は拡大していない。
|
||||||
|
|
||||||
|
Review / integration:
|
||||||
|
- Implementation commit: `92c4dee7 ticket: guide Ticket tool language universally`
|
||||||
|
- Reviewer: `yoi-reviewer-ticket-language-guidance` が approve。
|
||||||
|
- Orchestrator merge commit: `ec66cad8 merge: ticket language guidance for tool users`
|
||||||
|
- Ticket completion commit: `2ba97b67 ticket: mark language guidance done`
|
||||||
|
|
||||||
|
Validation:
|
||||||
|
- `cargo test -p ticket ticket_record_language_guidance`: pass
|
||||||
|
- `cargo test -p pod ticket_language_guidance`: pass
|
||||||
|
- `cargo test -p client ticket_record_language_stays_out_of_first_run_text`: pass
|
||||||
|
- `cargo test -p ticket`: pass, 68 tests
|
||||||
|
- `cargo fmt --check`: pass
|
||||||
|
- `git diff --check HEAD~1..HEAD`: pass
|
||||||
|
- `./result/bin/yoi ticket doctor`: `doctor: ok`
|
||||||
|
- `nix build .#yoi`: pass
|
||||||
|
|
||||||
|
Known unrelated validation failure:
|
||||||
|
- `cargo test -p pod` still includes pre-existing failures in Pod orchestration guidance prompt assertion tests. These were verified on the Orchestrator branch before merge and reviewed as unrelated to this Ticket.
|
||||||
|
|
||||||
|
Cleanup:
|
||||||
|
- coder/reviewer Pods stopped。
|
||||||
|
- child worktree `/home/hare/Projects/yoi/.worktree/ticket-language-guidance-all-tools` removed。
|
||||||
|
- branch `ticket/ticket-language-guidance-all-tools` deleted。
|
||||||
|
|
||||||
|
Non-blocking risk:
|
||||||
|
- configured language guidance is appended to every Ticket tool description, including read-only tools. This repeats some prompt text, but it is the accepted universal capability-surface tradeoff for this Ticket.
|
||||||
|
|
@ -296,3 +296,70 @@ Remaining non-blocking risk:
|
||||||
Implementation was merged into the Orchestrator branch, reviewer approved with no blockers, and post-integration validation passed. Cleanup and closure will be recorded next.
|
Implementation was merged into the Orchestrator branch, reviewer approved with no blockers, and post-integration validation passed. Cleanup and closure will be recorded next.
|
||||||
|
|
||||||
---
|
---
|
||||||
|
|
||||||
|
<!-- event: implementation_report author: orchestrator at: 2026-06-12T15:19:54Z -->
|
||||||
|
|
||||||
|
## Implementation report
|
||||||
|
|
||||||
|
Cleanup completed.
|
||||||
|
|
||||||
|
- Stopped coder Pod: `yoi-coder-ticket-language-guidance`
|
||||||
|
- Stopped reviewer Pod: `yoi-reviewer-ticket-language-guidance`
|
||||||
|
- Removed child worktree: `/home/hare/Projects/yoi/.worktree/ticket-language-guidance-all-tools`
|
||||||
|
- Deleted implementation branch: `ticket/ticket-language-guidance-all-tools`
|
||||||
|
- Orchestrator worktree status after cleanup: clean
|
||||||
|
|
||||||
|
Cleanup was limited to child implementation worktree/branch and related child Pods. Root/original workspace was not touched.
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
<!-- event: state_changed author: hare at: 2026-06-12T15:20:11Z from: done to: closed reason: closed field: state -->
|
||||||
|
|
||||||
|
## State changed
|
||||||
|
|
||||||
|
Ticket を closed にしました。
|
||||||
|
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
<!-- event: close author: hare at: 2026-06-12T15:20:11Z status: closed -->
|
||||||
|
|
||||||
|
## 完了
|
||||||
|
|
||||||
|
Ticket tool users 全体に `ticket.language` guidance が届くようにした。
|
||||||
|
|
||||||
|
実装概要:
|
||||||
|
- `crates/ticket/src/tool.rs` に shared `ticket_tool_description(name, record_language)` を追加し、configured `ticket.language` がある場合は Ticket tool description に durable Ticket record / Ticket tool body language guidance を追加するようにした。
|
||||||
|
- `crates/pod/src/feature/builtin/ticket.rs` の builtin Ticket feature `ToolDeclaration` descriptions でも同じ helper を使い、read-only Companion-style context と lifecycle/Ticket-role-style context の両方に guidance が届くようにした。
|
||||||
|
- guidance は `worker.language` / `memory.language` / `ticket.language` を区別し、protocol literals、file paths、commands、logs、identifiers、quoted external text は fidelity 優先で保持することを明記した。
|
||||||
|
- guidance は Ticket tool / capability surface で model-visible であり、hidden context injection や `ticket_role` launch prompt fragment ではない。
|
||||||
|
- Companion/read-only authority や mutating tool exposure は拡大していない。
|
||||||
|
|
||||||
|
Review / integration:
|
||||||
|
- Implementation commit: `92c4dee7 ticket: guide Ticket tool language universally`
|
||||||
|
- Reviewer: `yoi-reviewer-ticket-language-guidance` が approve。
|
||||||
|
- Orchestrator merge commit: `ec66cad8 merge: ticket language guidance for tool users`
|
||||||
|
- Ticket completion commit: `2ba97b67 ticket: mark language guidance done`
|
||||||
|
|
||||||
|
Validation:
|
||||||
|
- `cargo test -p ticket ticket_record_language_guidance`: pass
|
||||||
|
- `cargo test -p pod ticket_language_guidance`: pass
|
||||||
|
- `cargo test -p client ticket_record_language_stays_out_of_first_run_text`: pass
|
||||||
|
- `cargo test -p ticket`: pass, 68 tests
|
||||||
|
- `cargo fmt --check`: pass
|
||||||
|
- `git diff --check HEAD~1..HEAD`: pass
|
||||||
|
- `./result/bin/yoi ticket doctor`: `doctor: ok`
|
||||||
|
- `nix build .#yoi`: pass
|
||||||
|
|
||||||
|
Known unrelated validation failure:
|
||||||
|
- `cargo test -p pod` still includes pre-existing failures in Pod orchestration guidance prompt assertion tests. These were verified on the Orchestrator branch before merge and reviewed as unrelated to this Ticket.
|
||||||
|
|
||||||
|
Cleanup:
|
||||||
|
- coder/reviewer Pods stopped。
|
||||||
|
- child worktree `/home/hare/Projects/yoi/.worktree/ticket-language-guidance-all-tools` removed。
|
||||||
|
- branch `ticket/ticket-language-guidance-all-tools` deleted。
|
||||||
|
|
||||||
|
Non-blocking risk:
|
||||||
|
- configured language guidance is appended to every Ticket tool description, including read-only tools. This repeats some prompt text, but it is the accepted universal capability-surface tradeoff for this Ticket.
|
||||||
|
|
||||||
|
---
|
||||||
|
|
|
||||||
Loading…
Reference in New Issue
Block a user