From 40bdb90243d7f7998a44875ea4b9f89cadf0949f Mon Sep 17 00:00:00 2001 From: Hare Date: Sat, 13 Jun 2026 00:40:21 +0900 Subject: [PATCH] ticket: record companion notify fix --- .yoi/tickets/00001KTTW04W2/item.md | 2 +- .yoi/tickets/00001KTTW04W2/thread.md | 42 ++++++++++++++++++++++++++++ 2 files changed, 43 insertions(+), 1 deletion(-) diff --git a/.yoi/tickets/00001KTTW04W2/item.md b/.yoi/tickets/00001KTTW04W2/item.md index 653c093d..e9d81924 100644 --- a/.yoi/tickets/00001KTTW04W2/item.md +++ b/.yoi/tickets/00001KTTW04W2/item.md @@ -2,7 +2,7 @@ title: 'Orchestrator進捗をAutoKickなしでCompanionへ通知する' state: 'inprogress' created_at: '2026-06-11T08:15:24Z' -updated_at: '2026-06-12T15:31:01Z' +updated_at: '2026-06-12T15:40:14Z' assignee: null queued_by: 'workspace-panel' queued_at: '2026-06-11T10:31:56Z' diff --git a/.yoi/tickets/00001KTTW04W2/thread.md b/.yoi/tickets/00001KTTW04W2/thread.md index 9a14589b..e29717e3 100644 --- a/.yoi/tickets/00001KTTW04W2/thread.md +++ b/.yoi/tickets/00001KTTW04W2/thread.md @@ -306,3 +306,45 @@ Status: - Reviewer verdict remains `request_changes` until coder fix and second review. --- + + + +## Implementation report + +Coder completed requested fix. + +Coder Pod: +- `yoi-coder-companion-progress-notify` + +Implementation branch/worktree: +- Branch: `ticket/orchestrator-progress-companion-notify` +- Worktree: `/home/hare/Projects/yoi/.worktree/orchestrator-progress-companion-notify` +- Original implementation commit: `a87d3154 feat: weak companion progress notify` +- Sync merge commit: `724b79f1 Merge branch 'orchestration/yoi-orchestrator' into ticket/orchestrator-progress-companion-notify` +- Fix commit: `61e6c068 fix: resource-back companion progress notice` +- Worktree status: clean + +Fix summary: +- Added `resources/prompts/panel/companion_progress_notice.md` for model-facing Companion progress notice framing. +- Removed hard-coded progress notice framing from Rust. +- Rust now builds bounded runtime values and renders the prompt resource via `minijinja`. +- Added focused test proving the notice renders from the prompt resource. +- Preserved live/reachable-only delivery, missing/stopped no-op, `auto_run:false`, bounded output, sensitive-field exclusion, and no persistent snapshot store. +- Added `minijinja` to `crates/tui/Cargo.toml`, updated `Cargo.lock`, and updated `package.nix` `cargoHash` for Nix packaging. + +Orchestrator-verified evidence from child worktree after fix: +- `git status --short --branch`: clean on `ticket/orchestrator-progress-companion-notify` +- `cargo test -p protocol`: pass, 39 tests +- `cargo test -p pod --test controller_test`: pass, 36 tests +- `cargo test -p tui companion_progress -- --nocapture`: pass, 6 tests +- `cargo test -p tui send_notify_only_can_deliver_weak_notification_without_auto_run -- --nocapture`: pass, 1 test +- `cargo check -p protocol -p pod -p tui`: pass +- `cargo fmt --check`: pass +- `git diff --check orchestration/yoi-orchestrator...HEAD`: pass +- `cargo run -p yoi -- ticket doctor`: `doctor: ok` +- `nix build .#yoi`: pass + +Next: +- Request reviewer re-review of fix commit `61e6c068`, focusing on the prompt-resource boundary blocker, retention of weak notify safety invariants, dependency/package updates, and validation evidence. + +---