ticket: record routing progress

2026-06-10 18:07:00 +09:00
parent 16ceb3e22e
commit 41f7449008
9 changed files with 96 additions and 4 deletions
@@ -56,4 +56,51 @@ Accepting implementation after workspace inspection. Expected overlap with TUI m
 Implemented directly in worktree .worktree/prompt-resource-centralization because Pod-management tools are not available in this API session.\n\nBranch/commit:\n- prompt-resource-centralization / 342d5cf refactor: move ticket role prompts to resources\n\nSummary:\n- Moved Ticket role launch guidance strings from crates/client/src/ticket_role.rs into resources/prompts/ticket_role/*.md.\n- Added workspace/user override lookup for ticket_role prompt fragments before falling back to embedded resources.\n- Kept Rust code responsible for runtime composition, bounded dynamic fields, and segment assembly.\n- Added regression coverage for workspace prompt override behavior.\n\nValidation:\n- cargo fmt\n- cargo test -p client ticket_role --lib\n- git diff --check\n- cargo check -p client\n\nPending:\n- External review/merge validation not yet performed.\n- TUI model setup wizard worktree exists but implementation has not started.


+---
+
+<!-- event: plan author: orchestrator at: 2026-06-10T09:00:04Z -->
+
+## Plan
+
+Routing update: review_needed
+
+Reason:
+- Implementation report exists for branch `prompt-resource-centralization` / commit `342d5cf8`, but independent review and merge validation are not yet recorded.
+
+Evidence checked:
+- Ticket body/thread/artifacts and relation/orchestration-plan records.
+- Worktree status for `.worktree/prompt-resource-centralization` is clean and branch has commit `342d5cf8` over `develop`.
+- Visible Pods showed no existing child reviewer.
+
+Next action:
+- Spawned branch-local reviewer Pod `reviewer-prompt-resource-centralization` with read-only scope over the worktree and this Ticket. Reviewer is asked for approve/request_changes, blockers, notes, and focused validation evidence.
+
+Boundary:
+- This is branch-local review evidence only; no main-branch Ticket approval, merge, close, or cleanup is recorded by this routing step.
+
+---
+
+<!-- event: review author: reviewer-prompt-resource-centralization at: 2026-06-10T09:06:45Z status: approve -->
+
+## Review: approve
+
+Branch-local review verdict: approve
+
+Evidence:
+- Reviewed branch diff from merge-base `76165b47d664cb02a79c16272fbb5f8377a693bb` against `develop`.
+- Verified production `crates/client/src/ticket_role.rs` no longer hardcodes the large LLM-facing Ticket role launch / intake handoff / orchestrator / coder / reviewer prompt prose; prompt fragments now live under `resources/prompts/ticket_role/*.md`.
+- Verified runtime values remain sectioned/bounded and resource lookup order is workspace `.yoi/prompts/ticket_role/*.md` -> user prompts dir -> builtin embedded resource.
+- Verified existing semantics and tests cover representative builtin prompt generation and workspace override behavior.
+
+Validation run by reviewer:
+- `cargo test -p client ticket_role --lib` passed.
+- `git diff --check $(git merge-base HEAD develop)..HEAD` passed.
+- `nix build .#yoi` passed.
+
+Non-blocking notes:
+- Dedicated user-level prompt override test could be added later, but workspace override exercises the same loader path sufficiently for this change.
+- Prompt text fragments remain in test assertions only; this is not production prompt hardcoding.
+
+This is branch-local review evidence; final main-branch approval/close still belongs to merge-completion.
+
 ---