ticket: use base32 project record ids

2026-06-09 22:10:47 +09:00
parent 0803bc3725
commit 4203988d74
798 changed files with 477 additions and 105 deletions
@@ -0,0 +1,37 @@
+---
+title: "TUI: move view mode state out of ui module"
+state: "closed"
+created_at: "2026-05-31T07:42:58Z"
+updated_at: "2026-05-31T13:45:39Z"
+---
+
+## Background
+
+A read-only investigation of `crates/tui` found that `app.rs` imports `crate::ui::Mode` while `ui.rs` imports and renders `App`. This is not a Rust module cycle, but it makes the state/render boundary conceptually circular: application state depends on a type owned by the rendering module.
+
+This ticket separates the single-Pod display/history mode state from the render module before larger module grouping work.
+
+## Requirements
+
+- Move the single-Pod display/history mode type currently owned by `ui.rs` to a state-oriented location.
+  - Acceptable destinations include `app.rs` or a focused module such as `view_mode.rs`.
+  - If renaming, prefer a clearer name such as `ViewMode` or `HistoryMode`; keep the diff small if a rename would become noisy.
+- Update `app.rs`, `ui.rs`, `tool.rs`, and tests to use the new location/name.
+- Remove the `app.rs -> ui.rs` dependency caused only by this mode type.
+- Preserve rendering behavior and keyboard/command behavior.
+- Keep visibility changes minimal; do not combine this with broad `App` field privatization.
+
+## Non-goals
+
+- Moving the whole render tree into `render/`.
+- Splitting `app.rs` broadly.
+- Reworking mode semantics or UI layout.
+- Renaming the `tui` crate/package.
+
+## Acceptance criteria
+
+- `app.rs` no longer imports `crate::ui` solely to access display/history mode state.
+- Render code still consumes the mode state from the state-oriented module/type.
+- Existing mode-related behavior is unchanged.
+- Focused tests covering mode/key/render behavior pass.
+- `cargo fmt --check`, relevant `cargo test -p tui`, `cargo check -p tui`, `./tickets.sh doctor`, and `git diff --check` pass.
@@ -0,0 +1,20 @@
+Moved single-Pod view/history mode state out of the render module.
+
+Implementation:
+- Added `crates/tui/src/view_mode.rs`.
+- Moved `Mode` from `ui.rs` to `view_mode.rs` without changing variants or methods.
+- Updated `app.rs`, `ui.rs`, and `tool.rs` imports to use `crate::view_mode::Mode`.
+- Removed the `app.rs -> ui.rs` dependency caused solely by `Mode`.
+- Kept render/key/command behavior unchanged.
+
+Review:
+- External reviewer `tui-view-mode-reviewer-20260531` approved implementation commit `bc31bfa`.
+
+Validation after merge:
+- `cargo fmt --check`
+- `cargo test -p tui mode`
+- `cargo test -p tui`
+- `cargo check -p tui` (passed with existing dead-code warnings)
+- `./tickets.sh doctor`
+- `git diff --check`
+- `rg "crate::ui::Mode|ui::Mode" crates/tui/src || true` produced no active source hits.
@@ -0,0 +1,66 @@
+<!-- event: create author: tickets.sh at: 2026-05-31T07:42:58Z -->
+
+## Created
+
+Created by tickets.sh create.
+
+---
+
+<!-- event: review author: hare at: 2026-05-31T13:45:04Z status: approve -->
+
+## Review: approve
+
+External reviewer: `tui-view-mode-reviewer-20260531`
+Reviewed implementation commit: `bc31bfa` (`tui: move view mode state`)
+Verdict: approve
+
+Summary:
+- Moved the single-Pod history display mode type from `ui.rs` to `view_mode.rs`.
+- Kept the type name `Mode` and preserved variants/methods (`Detail`, `Normal`, `Overview`, `cycle()`, `label()`).
+- Updated `app.rs`, `ui.rs`, and `tool.rs` to import `crate::view_mode::Mode`.
+- Removed the state-model dependency from `app.rs` to the render module for this type.
+
+Requirements mapping:
+- `Mode` now lives in a focused state-oriented module.
+- `app.rs -> ui.rs` dependency caused by `Mode` is removed.
+- Rendering/key/command behavior is unchanged by inspection because the enum and methods are a straight move.
+- No broad `App` privatization, render-tree move, app split, crate/package rename, or unrelated runtime extraction was introduced.
+- No active `crate::ui::Mode` / `ui::Mode` references remain under `crates/tui/src`.
+
+Blockers: none.
+Non-blocking follow-ups: none.
+
+Validation adequacy:
+- Coder validation covered fmt, focused/full TUI tests, TUI check, doctor, diff-check, and `ui::Mode` grep.
+- Reviewer additionally performed read-only diff/reference checks and found no issues.
+
+
+---
+
+<!-- event: close author: hare at: 2026-05-31T13:45:39Z status: closed -->
+
+## Closed
+
+Moved single-Pod view/history mode state out of the render module.
+
+Implementation:
+- Added `crates/tui/src/view_mode.rs`.
+- Moved `Mode` from `ui.rs` to `view_mode.rs` without changing variants or methods.
+- Updated `app.rs`, `ui.rs`, and `tool.rs` imports to use `crate::view_mode::Mode`.
+- Removed the `app.rs -> ui.rs` dependency caused solely by `Mode`.
+- Kept render/key/command behavior unchanged.
+
+Review:
+- External reviewer `tui-view-mode-reviewer-20260531` approved implementation commit `bc31bfa`.
+
+Validation after merge:
+- `cargo fmt --check`
+- `cargo test -p tui mode`
+- `cargo test -p tui`
+- `cargo check -p tui` (passed with existing dead-code warnings)
+- `./tickets.sh doctor`
+- `git diff --check`
+- `rg "crate::ui::Mode|ui::Mode" crates/tui/src || true` produced no active source hits.
+
+
+---