ticket: use base32 project record ids

2026-06-09 22:10:47 +09:00
parent 0803bc3725
commit 4203988d74
798 changed files with 477 additions and 105 deletions
@@ -0,0 +1,32 @@
+Implemented and merged conditional memory prompt guidance.
+
+Merged commits:
+
+- `03256db memory: gate prompt guidance`
+- `3a0c8e1 memory: clean prompt helper warning`
+- `bdb52b1 merge: memory prompt guidance`
+
+Review:
+
+- Review approved in `62d88d9 review: approve memory prompt guidance`.
+- Initial review requested one warning cleanup; follow-up review approved the fix.
+
+Summary:
+
+- Normal prompt memory/knowledge guidance is now gated by available tool capabilities.
+- Memory-disabled prompts do not advertise `MemoryQuery`, `KnowledgeQuery`, `MemoryRead`, or memory mutation tools.
+- Partial-capability prompts avoid naming unavailable memory vs knowledge tools.
+- Normal Pod guidance now encourages somewhat more proactive small targeted lookups when prior decisions, rationale, durable preferences, tickets, policy, workflow, or project history may matter.
+- Existing cautions remain: memory can be stale; current authoritative state lives in user instructions, repository files, tickets, git history, and session logs; memory should not be queried mechanically every turn; mutation tools remain restricted.
+- Internal memory extraction/consolidation prompts remain focused on their worker roles and do not inherit normal Pod guidance.
+
+Validation after merge:
+
+- `cargo fmt --check` — passed
+- `cargo test -p pod prompt::` — passed (`53 passed; 0 failed`)
+- `./tickets.sh doctor` — passed
+- `git diff --check` — passed
+
+Caveats:
+
+- The test run still reports an existing unrelated `llm-worker` dead-code warning; the new prompt helper warning found during review was removed.
@@ -0,0 +1,27 @@
+# Review: memory prompt conditional lookup
+
+Implementation reviewed on branch `memory-prompt-conditional-lookup`.
+
+Reviewed commits:
+
+- `03256db memory: gate prompt guidance`
+- `3a0c8e1 memory: clean prompt helper warning`
+
+Verdict: approve.
+
+Summary:
+
+- Prompt rendering now gates normal memory/knowledge guidance according to available tool capabilities.
+- Memory-disabled prompt rendering does not advertise memory tools.
+- Partial-capability rendering avoids naming unavailable memory or knowledge tools.
+- Normal Pod guidance now encourages somewhat more proactive small targeted lookup when prior decisions, rationale, durable preferences, tickets, policy, workflow, or project history may affect the response or action.
+- Existing cautions remain: memory can be stale; current authoritative state lives in user instructions, repository files, tickets, git history, and session logs; memory should not be queried mechanically every turn; mutation tools are restricted.
+- Internal memory extraction/consolidation worker prompts remain isolated from normal Pod guidance.
+
+Review notes:
+
+- Initial review requested one blocker fix because `cargo test -p pod prompt::` emitted a new unused `append_trailing_section` warning.
+- Follow-up commit `3a0c8e1` removed the warning-producing helper path and adjusted partial-capability wording.
+- Final focused review approved the follow-up. `cargo test -p pod prompt::` passed with `53 passed; 0 failed`; only an existing unrelated `llm-worker` dead-code warning remains.
+
+Merge readiness: ready to merge.