ticket: use base32 project record ids

2026-06-09 22:10:47 +09:00
parent 0803bc3725
commit 4203988d74
798 changed files with 477 additions and 105 deletions
@@ -0,0 +1,52 @@
+<!-- event: create author: tickets.sh at: 2026-06-01T02:02:02Z -->
+
+## Created
+
+Created by tickets.sh create.
+
+---
+
+<!-- event: review author: hare at: 2026-06-01T02:23:11Z status: approve -->
+
+## Review: approve
+
+## External review summary
+
+Status: approved
+
+Reviewer inspected the ticket and implementation commit `5886f6a fix: align keys UI with TUI viewport` in branch `tui-keys-inline-viewport-ui`.
+
+Findings:
+
+- The implementation aligns `insomnia keys` with the existing inline viewport convention by using `Viewport::Inline(...)`.
+- Styling and layout are closer to the existing TUI viewport/list conventions.
+- Key management semantics remain unchanged for `SecretStore::set`, `SecretStore::delete`, and `list_ids`.
+- Stored secret values are not displayed.
+- Value entry is rendered with bullets.
+- `KeysApp` / `Action::Set` debug output redacts the secret value.
+- Focused tests cover that raw editing values are not rendered.
+
+Non-blocking follow-ups:
+
+- Shared inline viewport helpers/style constants may be worth extracting if more similar screens appear.
+- Display-width-aware cursor positioning can be considered later if Unicode-width behavior becomes important.
+
+Validation reviewed:
+
+- `cargo fmt --check`
+- `cargo test -p tui keys::tests`
+- `cargo check -p insomnia`
+
+Parent decision needed: none.
+
+
+---
+
+<!-- event: close author: hare at: 2026-06-01T02:23:12Z status: closed -->
+
+## Closed
+
+Merged branch tui-keys-inline-viewport-ui via merge commit dbb47e0 after external review approval. Validation on develop passed: cargo fmt --check, cargo test -p pod, cargo test -p tui, cargo check -p insomnia, ./tickets.sh doctor.
+
+
+---