ticket: use base32 project record ids

2026-06-09 22:10:47 +09:00
parent 0803bc3725
commit 4203988d74
798 changed files with 477 additions and 105 deletions
@@ -0,0 +1,46 @@
+---
+title: "Remove bare letter shortcuts from workspace panel"
+state: 'closed'
+created_at: "2026-06-07T21:38:08Z"
+updated_at: '2026-06-09T10:20:49Z'
+queued_by: "workspace-panel"
+queued_at: "2026-06-07T22:04:20Z"
+---
+
+## Background
+
+The workspace panel keeps the composer visible, but several bare letter keys are currently handled as global panel shortcuts before they can be inserted into the composer. This makes normal text input feel broken: typing `j`, `k`, `o`, or `r` can move selection, open/attach a Pod, or refresh instead of entering text.
+
+Observed shortcuts to remove:
+
+- `j`: next row
+- `k`: previous row
+- `o`: open / attach / restore selected Pod
+- `r`: refresh
+
+The panel should prioritize composer text entry. Navigation/commands should use non-text keys or modifier-based shortcuts.
+
+## Goal
+
+Remove the bare `j` / `k` / `o` / `r` panel shortcuts so those characters are inserted into the composer as ordinary text.
+
+## Requirements
+
+- Remove bare `j` and `k` row-navigation shortcuts from workspace panel key handling.
+- Remove bare `o` open/attach shortcut from workspace panel key handling.
+- Remove bare `r` refresh shortcut from workspace panel key handling.
+- Keep non-text controls such as `↑` / `↓`, `Enter`, `Alt+Enter`, `Ctrl+T`, `Esc`, and `Ctrl+C` unless tests reveal a direct conflict.
+- Update actionbar/help text so it no longer advertises `o open` or `r refresh`.
+- Ensure `j`, `k`, `o`, and `r` are inserted into the composer for normal input.
+- Do not reintroduce selected-Pod direct-send semantics.
+- Do not change Ticket action dispatch semantics except where tests must be updated for removed shortcuts.
+
+## Acceptance criteria
+
+- Typing `j`, `k`, `o`, or `r` in the workspace panel composer appends those characters to the draft.
+- Row navigation still works with arrow keys.
+- Opening/attaching selected Pods remains reachable through the existing blank-Enter behavior where applicable.
+- Refresh remains reachable through an explicit non-text path if one already exists; otherwise do not invent a new shortcut in this ticket unless needed for tests.
+- Actionbar/help text matches the actual key behavior.
+- Focused TUI tests cover the removed shortcuts and composer insertion behavior.
+- `cargo test -p tui ... --lib`, `cargo fmt --check`, `git diff --check`, and `target/debug/yoi ticket doctor` pass.
@@ -0,0 +1,3 @@
+Closed as completed.
+
+The workspace panel bare-letter shortcut issue was implemented and the Ticket was already in `state: done`. This close records final lifecycle completion; implementation details and review history remain in `thread.md`.
@@ -0,0 +1,369 @@
+<!-- event: create author: LocalTicketBackend at: 2026-06-07T21:38:08Z -->
+
+## Created
+
+Created by LocalTicketBackend create.
+
+---
+
+<!-- event: intake_summary author: intake at: 2026-06-07T22:03:06Z -->
+
+## Intake summary
+
+Confirmed existing Ticket scope: remove bare `j`/`k`/`o`/`r` workspace panel shortcuts so normal composer input inserts those characters; keep non-text controls such as arrows, Enter/Alt+Enter, Ctrl+T, Esc, and Ctrl+C; update actionbar/help text; preserve no selected-Pod direct-send semantics; add focused TUI coverage and run the listed validation commands. Readiness: implementation_ready. needs_preflight: false. risk_flags: [].
+
+---
+
+<!-- event: state_changed author: intake at: 2026-06-07T22:03:06Z from: intake to: ready reason: intake_ready field: workflow_state -->
+
+## State changed
+
+Intake found the existing Ticket sufficiently scoped for Orchestrator routing. No duplicate Ticket was created.
+
+---
+
+<!-- event: state_changed author: workspace-panel at: 2026-06-07T22:04:20Z from: ready to: queued reason: queued field: workflow_state -->
+
+## State changed
+
+Ticket queued for Orchestrator routing.
+
+
+---
+
+<!-- event: decision author: orchestrator at: 2026-06-07T22:04:43Z -->
+
+## Decision
+
+Routing decision: blocked_action_required
+
+Reason:
+- The Ticket itself is implementation-ready: scope is narrow, requirements and acceptance criteria are observable, intake marked it ready, and no preflight risk flags are present.
+- I am not accepting `queued -> inprogress` yet because the main workspace has unrelated dirty changes that must be understood or cleaned before worktree/Pod implementation side effects.
+
+Evidence checked:
+- Ticket body, intake summary, and `ready -> queued` event.
+- Workspace state via `git status --short --branch`.
+- Existing worktrees/branches for this slug: none found.
+- Visible Pods: intake peer for this Ticket is idle; no coder/reviewer children are active.
+
+Dirty workspace observed:
+- Modified: `.yoi/profiles/_base.lua`, `.yoi/profiles/coder.lua`, `resources/models/builtin.toml`.
+- Ticket files for this Ticket are modified as part of local Ticket state.
+- Untracked: `.yoi/tickets/.ticket-backend.lock`, `.yoi/tickets/open/20260607-220225-commit-intake-claims-after-launch-success/`.
+
+Next action:
+- Human/parent should either clean or commit the unrelated workspace changes, or explicitly confirm that routing may proceed with this dirty state.
+- After that, record `queued -> inprogress` before creating `.worktree/remove-workspace-panel-bare-letter-shortcuts` or spawning coder/reviewer Pods.
+
+Escalate if:
+- The modified profile/model files belong to an active separate implementation that should not be interleaved with this Ticket.
+- The untracked follow-up Ticket or backend lock indicates an unfinished Ticket operation.
+
+---
+
+<!-- event: decision author: orchestrator at: 2026-06-07T22:06:52Z -->
+
+## Decision
+
+Routing decision: implementation_ready
+
+Reason:
+- Human explicitly authorized proceeding despite the previously recorded unrelated dirty main-workspace changes.
+- Ticket scope is narrow and observable: remove bare `j`/`k`/`o`/`r` workspace panel shortcuts, preserve non-text controls, update actionbar/help text, and add focused TUI coverage.
+- Intake already marked the Ticket implementation-ready with `needs_preflight: false` and no risk flags.
+
+Evidence checked:
+- Ticket body and acceptance criteria.
+- Intake summary and `ready -> queued` event.
+- Previous workspace state check: no existing worktree/branch for this slug; no coder/reviewer Pods active for this Ticket.
+
+IntentPacket:
+
+Intent:
+- Make workspace panel composer text entry win over bare letter shortcuts for `j`, `k`, `o`, and `r`.
+
+Requirements:
+- Remove bare `j`/`k` row navigation handling.
+- Remove bare `o` selected-Pod open/attach handling.
+- Remove bare `r` refresh handling.
+- Keep arrow-key navigation, Enter/Alt+Enter behavior, Ctrl+T, Esc, and Ctrl+C unless focused tests reveal a direct conflict.
+- Update visible actionbar/help text so removed shortcuts are not advertised.
+- Add/adjust focused TUI tests proving `j`, `k`, `o`, and `r` are inserted into the composer draft and arrow-key navigation still works.
+
+Invariants:
+- Do not reintroduce selected-Pod direct-send semantics.
+- Do not change Ticket action dispatch semantics except for tests directly affected by removed shortcuts.
+- Keep changes scoped to workspace panel key handling/help/tests unless implementation evidence shows a tightly related path must change.
+
+Non-goals:
+- Do not invent a new refresh shortcut unless an existing non-text path/test already requires it.
+- Do not redesign workspace panel navigation or Companion behavior.
+- Do not edit main-workspace `.yoi` project records, workflow docs, generated memory, local runtime/cache/lock/socket/secret-like files from the child worktree.
+
+Escalate if:
+- Removing these keys breaks a required accessibility or command path with no existing non-text alternative.
+- The implementation requires changing selected-Pod dispatch or Ticket action semantics beyond shortcut removal.
+- Tests reveal broader composer focus architecture problems outside this Ticket.
+
+Validation:
+- Focused `cargo test -p tui ... --lib` for the touched workspace panel tests.
+- `cargo fmt --check`.
+- `git diff --check`.
+- `target/debug/yoi ticket doctor`.
+- Run `nix build .#yoi` before final completion if code/package/resource changes are retained.
+
+Current code map:
+- Search under TUI workspace panel key handling, actionbar/help rendering, and existing focused tests.
+- Avoid unrelated profile/model/Ticket changes currently dirty in the main workspace.
+
+Critical risks:
+- A bare key may be handled before composer insertion in another layer.
+- Help text may advertise stale shortcuts even after behavior is removed.
+- Tests may accidentally exercise selected-Pod direct-send semantics instead of composer insertion.
+
+---
+
+<!-- event: state_changed author: orchestrator at: 2026-06-07T22:06:56Z from: queued to: inprogress reason: orchestrator_acceptance_dirty_state_authorized field: workflow_state -->
+
+## State changed
+
+Orchestrator accepted the queued Ticket for implementation after explicit human approval to proceed despite unrelated dirty main-workspace changes. Worktree and sibling coder/reviewer routing may proceed from this accepted in-progress state.
+
+---
+
+<!-- event: implementation_report author: orchestrator at: 2026-06-07T22:07:50Z -->
+
+## Implementation report
+
+Implementation setup note:
+- Child worktree was created at `.worktree/remove-workspace-panel-bare-letter-shortcuts` on branch `ticket/remove-workspace-panel-bare-letter-shortcuts`.
+- First coder Pod launch attempt failed before a socket appeared because the spawned Pod process started with main workspace `pwd` while its delegated scope only included the child worktree.
+- No coder implementation side effects occurred. Recovery is to relaunch with read access to the main workspace for startup/cwd plus write access only to the child worktree.
+
+---
+
+<!-- event: implementation_report author: orchestrator at: 2026-06-07T22:08:17Z -->
+
+## Implementation report
+
+Coder delegated:
+- Pod: `coder-remove-workspace-panel-bare-letter-shortcuts`
+- Worktree: `.worktree/remove-workspace-panel-bare-letter-shortcuts`
+- Branch: `ticket/remove-workspace-panel-bare-letter-shortcuts`
+- Scope: read access to main workspace only for startup/cwd; write access to the child worktree.
+- Instructions: implement minimal key handling/help/test changes, run focused TUI validation plus formatting/diff/ticket doctor where available, commit locally on the child branch, and report status/evidence. No merge, close, main Ticket edits, or cleanup delegated.
+
+---
+
+<!-- event: implementation_report author: orchestrator at: 2026-06-07T22:15:16Z -->
+
+## Implementation report
+
+Coder completed implementation:
+- Pod: `coder-remove-workspace-panel-bare-letter-shortcuts`
+- Branch/worktree: `ticket/remove-workspace-panel-bare-letter-shortcuts` at `.worktree/remove-workspace-panel-bare-letter-shortcuts`
+- Commit: `a5fa3d8 fix: remove panel bare letter shortcuts`
+- Files changed: `crates/tui/src/multi_pod.rs`
+- Child worktree status: clean
+
+Reported validation:
+- `cargo test -p tui multi_bare_panel_letters_append_to_composer_and_arrows_select --lib` — passed
+- `cargo test -p tui multi_empty_enter_on_non_openable_row_reports_open_diagnostic --lib` — passed
+- `cargo fmt --check` — passed
+- `git diff --check` — passed
+- `target/debug/yoi ticket doctor` — unavailable in child because `target/debug/yoi` did not exist
+- `nix build .#yoi` — passed (`result -> /nix/store/g9yryl61wb5yxcfrdip4ygh89bf787si-yoi-0.1.0`)
+
+Next action:
+- Delegate independent read-only reviewer inspection of commit `a5fa3d8` against the Ticket intent and acceptance criteria before preparing a merge-ready dossier.
+
+---
+
+<!-- event: implementation_report author: orchestrator at: 2026-06-07T22:15:43Z -->
+
+## Implementation report
+
+Reviewer delegated:
+- Pod: `reviewer-remove-workspace-panel-bare-letter-shortcuts`
+- Review target: commit `a5fa3d8` on branch `ticket/remove-workspace-panel-bare-letter-shortcuts`
+- Scope: read-only child worktree plus git metadata needed to inspect the branch.
+- Instructions: inspect diff/tests against Ticket intent and return `approve` or `request_changes` with blocker/non-blocker separation. No file edits, Ticket writes, merge, close, or cleanup delegated.
+
+---
+
+<!-- event: implementation_report author: orchestrator at: 2026-06-07T22:19:50Z -->
+
+## Implementation report
+
+Merge-ready dossier for `orchestrator-merge-completion`
+
+Ticket:
+- Id: `20260607-213808-remove-workspace-panel-bare-letter-shortcuts`
+- Slug: `remove-workspace-panel-bare-letter-shortcuts`
+- Workflow state: `inprogress`
+
+Branch/worktree:
+- Branch: `ticket/remove-workspace-panel-bare-letter-shortcuts`
+- Worktree: `.worktree/remove-workspace-panel-bare-letter-shortcuts`
+- Child worktree status: clean (`## ticket/remove-workspace-panel-bare-letter-shortcuts`)
+
+Commits:
+- `a5fa3d8 fix: remove panel bare letter shortcuts`
+- Diff vs `develop`: `crates/tui/src/multi_pod.rs` only; 81 lines changed, 45 insertions, 36 deletions.
+
+Intent/invariant check:
+- Intent satisfied: bare `j`, `k`, `o`, and `r` now pass through to composer insertion instead of workspace panel shortcuts.
+- Preserved non-text controls: arrow-key navigation remains; blank Enter open/attach flow remains.
+- Preserved boundary: selected-Pod direct-send semantics were not reintroduced; non-empty Enter still routes through Companion send logic.
+- Scope stayed narrow: only workspace panel key handling/help/tests in `crates/tui/src/multi_pod.rs` changed.
+
+Implementation summary:
+- Removed bare `j`/`k` selection handlers.
+- Removed bare `o` open and bare `r` refresh handlers.
+- Removed now-unreachable `MultiPodAction::Refresh` dispatch branch.
+- Updated title/actionbar/open diagnostic text so removed shortcuts are no longer advertised.
+- Added focused coverage proving bare `jkor` appends to composer while arrow keys still move selection.
+- Updated non-openable-row diagnostic test to use Enter-only behavior after `o` removal.
+
+Coder evidence:
+- Pod: `coder-remove-workspace-panel-bare-letter-shortcuts`
+- Coder commit: `a5fa3d8`
+- Coder-reported status: child worktree clean.
+- Coder-reported validation:
+  - `cargo test -p tui multi_bare_panel_letters_append_to_composer_and_arrows_select --lib` — passed
+  - `cargo test -p tui multi_empty_enter_on_non_openable_row_reports_open_diagnostic --lib` — passed
+  - `cargo fmt --check` — passed
+  - `git diff --check` — passed
+  - `target/debug/yoi ticket doctor` — unavailable in child because `target/debug/yoi` did not exist
+  - `nix build .#yoi` — passed (`result -> /nix/store/g9yryl61wb5yxcfrdip4ygh89bf787si-yoi-0.1.0`)
+
+Reviewer evidence:
+- Pod: `reviewer-remove-workspace-panel-bare-letter-shortcuts`
+- Branch-local verdict: approve.
+- Evidence inspected by reviewer: commit state, clean status, diff path/stat, whitespace check, key-handler diff, help/actionbar strings, focused tests, and existing Enter/open tests.
+- Reviewer confirmed acceptance criteria satisfied and no selected-Pod direct-send regression.
+- Reviewer did not rerun cargo/nix independently because review scope was read-only; reviewer judged coder validation sufficient for this narrow change.
+
+Blockers / findings:
+- No reviewer blockers.
+- No non-blocker changes required.
+- Earlier setup issue was recovered: first coder launch failed due cwd scope readability; relaunch succeeded with main workspace read-only for startup and child worktree write scope.
+
+Validation performed by orchestrator:
+- Confirmed child branch HEAD and clean status.
+- Confirmed diff stat/name-status against `develop`.
+- Ran typed `TicketDoctor`: 0 errors; existing repository-wide warnings remain unrelated/truncated.
+
+Residual risks:
+- Manual refresh via bare `r` is intentionally removed; users rely on existing polling/other reload paths. This matches the Ticket intent.
+- Focused test covers the shared key handler through the no-Ticket test app; reviewer considered this adequate because the removed bare-key handling is panel-mode independent.
+
+Current main workspace dirty state:
+- Main branch: `develop...origin/develop [ahead 8]`
+- Modified by this orchestration Ticket state: `.yoi/tickets/open/20260607-213808-remove-workspace-panel-bare-letter-shortcuts/item.md`, `.yoi/tickets/open/20260607-213808-remove-workspace-panel-bare-letter-shortcuts/thread.md`
+- Untracked: `.yoi/tickets/.ticket-backend.lock`
+- Previously observed unrelated profile/model dirty files are no longer present in current `git status` output.
+
+Pods / cleanup state:
+- Coder Pod is idle/reachable.
+- Reviewer Pod is idle/reachable.
+- Worktree and branch are retained for merge-completion.
+- No merge, final main-branch approval, close, or cleanup has been performed.
+
+Parent/human decision needed:
+- Authorize merge-completion if desired. Without explicit merge authority, stop here with this dossier.
+- Merge-completion should independently verify branch/worktree/commit identity, main workspace safety, and validation requirements before merge/close/cleanup.
+
+---
+
+<!-- event: review author: orchestrator at: 2026-06-07T22:25:34Z status: approve -->
+
+## Review: approve
+
+Final merge-completion review: approved after merging `ticket/remove-workspace-panel-bare-letter-shortcuts` with `--no-ff`, verifying the merged diff stayed scoped to `crates/tui/src/multi_pod.rs`, and running post-merge validation.
+
+Validation:
+- `cargo test -p tui multi_bare_panel_letters_append_to_composer_and_arrows_select --lib` — passed
+- `cargo test -p tui multi_empty_enter_on_non_openable_row_reports_open_diagnostic --lib` — passed
+- `cargo fmt --check` — passed
+- `git diff --check` — passed
+- `target/debug/yoi ticket doctor` — passed (`doctor: ok`)
+- `nix build .#yoi` — passed (with expected dirty-tree warning due local Ticket/thread state)
+
+No blockers remain. This review records the main-workspace merge-completion approval; the earlier reviewer Pod verdict remains branch-local evidence.
+
+---
+
+<!-- event: implementation_report author: orchestrator at: 2026-06-07T22:25:34Z -->
+
+## Implementation report
+
+Merge-completion implementation report:
+
+Merged:
+- Branch: `ticket/remove-workspace-panel-bare-letter-shortcuts`
+- Method: `git merge --no-ff ticket/remove-workspace-panel-bare-letter-shortcuts -m "merge: remove workspace panel bare letter shortcuts"`
+- Merge commit: created on `develop` after verifying branch/worktree identity and reviewer approval.
+- Delegated Pods were stopped before merge and their scopes reclaimed.
+
+Post-merge validation:
+- `cargo test -p tui multi_bare_panel_letters_append_to_composer_and_arrows_select --lib` — passed
+- `cargo test -p tui multi_empty_enter_on_non_openable_row_reports_open_diagnostic --lib` — passed
+- `cargo fmt --check` — passed
+- `git diff --check` — passed
+- `target/debug/yoi ticket doctor` — passed (`doctor: ok`)
+- `nix build .#yoi` — passed; Nix reported the expected dirty Git tree warning because Ticket/thread state is still locally modified.
+
+Cleanup status:
+- Coder Pod stopped and scope reclaimed.
+- Reviewer Pod stopped and scope reclaimed.
+- Worktree/branch cleanup follows this validation report.
+
+No merge blockers remain.
+
+---
+
+<!-- event: state_changed author: orchestrator at: 2026-06-07T22:25:43Z from: inprogress to: done reason: merge_completed_validated field: workflow_state -->
+
+## State changed
+
+Merge-completion finished: branch was merged into `develop`, post-merge validation passed, main-workspace approval was recorded, and delegated Pods were stopped. Local status is left open because this request authorized merge-completion, not Ticket close/resolution.
+
+---
+
+<!-- event: implementation_report author: orchestrator at: 2026-06-07T22:26:19Z -->
+
+## Implementation report
+
+Merge-completion cleanup completed:
+- Merge commit: `b633319 merge: remove workspace panel bare letter shortcuts`
+- Ticket record commit: `8302cbb ticket: record bare shortcut merge completion`
+- Removed child worktree: `.worktree/remove-workspace-panel-bare-letter-shortcuts`
+- Deleted merged branch: `ticket/remove-workspace-panel-bare-letter-shortcuts`
+- Stopped delegated Pods: `coder-remove-workspace-panel-bare-letter-shortcuts`, `reviewer-remove-workspace-panel-bare-letter-shortcuts`
+- Final workflow state: `done`
+- Final local status: left open; no `TicketClose` was performed because the user authorized merge, not close/resolution.
+
+Final workspace status after cleanup/record commit was clean apart from being ahead of `origin/develop`.
+
+---
+
+<!-- event: state_changed author: hare at: 2026-06-09T10:20:49Z from: done to: closed reason: closed field: state -->
+
+## State changed
+
+Ticket を closed にしました。
+
+
+---
+
+<!-- event: close author: hare at: 2026-06-09T10:20:49Z status: closed -->
+
+## 完了
+
+Closed as completed.
+
+The workspace panel bare-letter shortcut issue was implemented and the Ticket was already in `state: done`. This close records final lifecycle completion; implementation details and review history remain in `thread.md`.
+
+---