diff --git a/work-items/open/20260601-013132-tui-new-session-first-message-missing/artifacts/.gitkeep b/work-items/closed/20260601-013132-tui-new-session-first-message-missing/artifacts/.gitkeep similarity index 100% rename from work-items/open/20260601-013132-tui-new-session-first-message-missing/artifacts/.gitkeep rename to work-items/closed/20260601-013132-tui-new-session-first-message-missing/artifacts/.gitkeep diff --git a/work-items/open/20260601-013132-tui-new-session-first-message-missing/artifacts/investigation-20260601.md b/work-items/closed/20260601-013132-tui-new-session-first-message-missing/artifacts/investigation-20260601.md similarity index 100% rename from work-items/open/20260601-013132-tui-new-session-first-message-missing/artifacts/investigation-20260601.md rename to work-items/closed/20260601-013132-tui-new-session-first-message-missing/artifacts/investigation-20260601.md diff --git a/work-items/closed/20260601-013132-tui-new-session-first-message-missing/artifacts/review-20260601.md b/work-items/closed/20260601-013132-tui-new-session-first-message-missing/artifacts/review-20260601.md new file mode 100644 index 00000000..09ccb0cb --- /dev/null +++ b/work-items/closed/20260601-013132-tui-new-session-first-message-missing/artifacts/review-20260601.md @@ -0,0 +1,23 @@ +## External review summary + +Status: approved + +Reviewer inspected the ticket, investigation artifact, and implementation commit `501dcc9 fix: show initial TUI user message` in branch `tui-new-session-first-message-missing`. + +Findings: + +- The implementation matches the ticket intent and investigation result. +- The controller-side pre-run optimistic `Event::UserMessage` broadcast is removed from the authoritative path. +- Live `Event::UserMessage` emission is tied to persisted `LogEntry::UserInput` / session-log-derived ordering. +- Fresh sessions should now see initial `SegmentRotated` before the committed user message event, preserving the first message in the TUI view. +- The fix does not use a TUI-only fake/pending message. +- No unnecessary protocol/schema expansion was found. +- Existing snapshot restore, later sends, queued input, and composer input history did not show obvious regressions from the diff. + +Validation reviewed: + +- `cargo fmt` +- `cargo test -p pod` +- `cargo test -p tui` + +Parent decision needed: none. diff --git a/work-items/open/20260601-013132-tui-new-session-first-message-missing/item.md b/work-items/closed/20260601-013132-tui-new-session-first-message-missing/item.md similarity index 97% rename from work-items/open/20260601-013132-tui-new-session-first-message-missing/item.md rename to work-items/closed/20260601-013132-tui-new-session-first-message-missing/item.md index bb81bf2a..ca836b75 100644 --- a/work-items/open/20260601-013132-tui-new-session-first-message-missing/item.md +++ b/work-items/closed/20260601-013132-tui-new-session-first-message-missing/item.md @@ -2,12 +2,12 @@ id: 20260601-013132-tui-new-session-first-message-missing slug: tui-new-session-first-message-missing title: TUI: first message missing when starting a new session -status: open +status: closed kind: bug priority: P1 labels: [tui, session, display] created_at: 2026-06-01T01:31:32Z -updated_at: 2026-06-01T02:00:33Z +updated_at: 2026-06-01T02:23:11Z assignee: null legacy_ticket: null --- diff --git a/work-items/closed/20260601-013132-tui-new-session-first-message-missing/resolution.md b/work-items/closed/20260601-013132-tui-new-session-first-message-missing/resolution.md new file mode 100644 index 00000000..91b2ec1a --- /dev/null +++ b/work-items/closed/20260601-013132-tui-new-session-first-message-missing/resolution.md @@ -0,0 +1 @@ +Merged branch tui-new-session-first-message-missing via merge commit ff27917 after external review approval. Validation on develop passed: cargo fmt --check, cargo test -p pod, cargo test -p tui, cargo check -p insomnia, ./tickets.sh doctor. diff --git a/work-items/open/20260601-013132-tui-new-session-first-message-missing/thread.md b/work-items/closed/20260601-013132-tui-new-session-first-message-missing/thread.md similarity index 72% rename from work-items/open/20260601-013132-tui-new-session-first-message-missing/thread.md rename to work-items/closed/20260601-013132-tui-new-session-first-message-missing/thread.md index 7394664e..2033520f 100644 --- a/work-items/open/20260601-013132-tui-new-session-first-message-missing/thread.md +++ b/work-items/closed/20260601-013132-tui-new-session-first-message-missing/thread.md @@ -75,4 +75,44 @@ This should make a fresh session produce `SegmentRotated` first and then `UserMe - Run focused tests for `pod` / `tui` crates as appropriate, plus formatting/checks that are reasonably scoped to the touched code. +--- + + + +## Review: approve + +## External review summary + +Status: approved + +Reviewer inspected the ticket, investigation artifact, and implementation commit `501dcc9 fix: show initial TUI user message` in branch `tui-new-session-first-message-missing`. + +Findings: + +- The implementation matches the ticket intent and investigation result. +- The controller-side pre-run optimistic `Event::UserMessage` broadcast is removed from the authoritative path. +- Live `Event::UserMessage` emission is tied to persisted `LogEntry::UserInput` / session-log-derived ordering. +- Fresh sessions should now see initial `SegmentRotated` before the committed user message event, preserving the first message in the TUI view. +- The fix does not use a TUI-only fake/pending message. +- No unnecessary protocol/schema expansion was found. +- Existing snapshot restore, later sends, queued input, and composer input history did not show obvious regressions from the diff. + +Validation reviewed: + +- `cargo fmt` +- `cargo test -p pod` +- `cargo test -p tui` + +Parent decision needed: none. + + +--- + + + +## Closed + +Merged branch tui-new-session-first-message-missing via merge commit ff27917 after external review approval. Validation on develop passed: cargo fmt --check, cargo test -p pod, cargo test -p tui, cargo check -p insomnia, ./tickets.sh doctor. + + --- diff --git a/work-items/open/20260601-020202-tui-keys-inline-viewport-ui/artifacts/.gitkeep b/work-items/closed/20260601-020202-tui-keys-inline-viewport-ui/artifacts/.gitkeep similarity index 100% rename from work-items/open/20260601-020202-tui-keys-inline-viewport-ui/artifacts/.gitkeep rename to work-items/closed/20260601-020202-tui-keys-inline-viewport-ui/artifacts/.gitkeep diff --git a/work-items/closed/20260601-020202-tui-keys-inline-viewport-ui/artifacts/review-20260601.md b/work-items/closed/20260601-020202-tui-keys-inline-viewport-ui/artifacts/review-20260601.md new file mode 100644 index 00000000..68116b7d --- /dev/null +++ b/work-items/closed/20260601-020202-tui-keys-inline-viewport-ui/artifacts/review-20260601.md @@ -0,0 +1,28 @@ +## External review summary + +Status: approved + +Reviewer inspected the ticket and implementation commit `5886f6a fix: align keys UI with TUI viewport` in branch `tui-keys-inline-viewport-ui`. + +Findings: + +- The implementation aligns `insomnia keys` with the existing inline viewport convention by using `Viewport::Inline(...)`. +- Styling and layout are closer to the existing TUI viewport/list conventions. +- Key management semantics remain unchanged for `SecretStore::set`, `SecretStore::delete`, and `list_ids`. +- Stored secret values are not displayed. +- Value entry is rendered with bullets. +- `KeysApp` / `Action::Set` debug output redacts the secret value. +- Focused tests cover that raw editing values are not rendered. + +Non-blocking follow-ups: + +- Shared inline viewport helpers/style constants may be worth extracting if more similar screens appear. +- Display-width-aware cursor positioning can be considered later if Unicode-width behavior becomes important. + +Validation reviewed: + +- `cargo fmt --check` +- `cargo test -p tui keys::tests` +- `cargo check -p insomnia` + +Parent decision needed: none. diff --git a/work-items/open/20260601-020202-tui-keys-inline-viewport-ui/item.md b/work-items/closed/20260601-020202-tui-keys-inline-viewport-ui/item.md similarity index 98% rename from work-items/open/20260601-020202-tui-keys-inline-viewport-ui/item.md rename to work-items/closed/20260601-020202-tui-keys-inline-viewport-ui/item.md index 0d0c95ff..cbba571e 100644 --- a/work-items/open/20260601-020202-tui-keys-inline-viewport-ui/item.md +++ b/work-items/closed/20260601-020202-tui-keys-inline-viewport-ui/item.md @@ -2,12 +2,12 @@ id: 20260601-020202-tui-keys-inline-viewport-ui slug: tui-keys-inline-viewport-ui title: TUI: align insomnia keys UI with inline viewport style -status: open +status: closed kind: task priority: P2 labels: [tui, keys, ui] created_at: 2026-06-01T02:02:02Z -updated_at: 2026-06-01T02:02:02Z +updated_at: 2026-06-01T02:23:12Z assignee: null legacy_ticket: null --- diff --git a/work-items/closed/20260601-020202-tui-keys-inline-viewport-ui/resolution.md b/work-items/closed/20260601-020202-tui-keys-inline-viewport-ui/resolution.md new file mode 100644 index 00000000..894df603 --- /dev/null +++ b/work-items/closed/20260601-020202-tui-keys-inline-viewport-ui/resolution.md @@ -0,0 +1 @@ +Merged branch tui-keys-inline-viewport-ui via merge commit dbb47e0 after external review approval. Validation on develop passed: cargo fmt --check, cargo test -p pod, cargo test -p tui, cargo check -p insomnia, ./tickets.sh doctor. diff --git a/work-items/closed/20260601-020202-tui-keys-inline-viewport-ui/thread.md b/work-items/closed/20260601-020202-tui-keys-inline-viewport-ui/thread.md new file mode 100644 index 00000000..63b3317e --- /dev/null +++ b/work-items/closed/20260601-020202-tui-keys-inline-viewport-ui/thread.md @@ -0,0 +1,52 @@ + + +## Created + +Created by tickets.sh create. + +--- + + + +## Review: approve + +## External review summary + +Status: approved + +Reviewer inspected the ticket and implementation commit `5886f6a fix: align keys UI with TUI viewport` in branch `tui-keys-inline-viewport-ui`. + +Findings: + +- The implementation aligns `insomnia keys` with the existing inline viewport convention by using `Viewport::Inline(...)`. +- Styling and layout are closer to the existing TUI viewport/list conventions. +- Key management semantics remain unchanged for `SecretStore::set`, `SecretStore::delete`, and `list_ids`. +- Stored secret values are not displayed. +- Value entry is rendered with bullets. +- `KeysApp` / `Action::Set` debug output redacts the secret value. +- Focused tests cover that raw editing values are not rendered. + +Non-blocking follow-ups: + +- Shared inline viewport helpers/style constants may be worth extracting if more similar screens appear. +- Display-width-aware cursor positioning can be considered later if Unicode-width behavior becomes important. + +Validation reviewed: + +- `cargo fmt --check` +- `cargo test -p tui keys::tests` +- `cargo check -p insomnia` + +Parent decision needed: none. + + +--- + + + +## Closed + +Merged branch tui-keys-inline-viewport-ui via merge commit dbb47e0 after external review approval. Validation on develop passed: cargo fmt --check, cargo test -p pod, cargo test -p tui, cargo check -p insomnia, ./tickets.sh doctor. + + +--- diff --git a/work-items/open/20260601-020202-tui-keys-inline-viewport-ui/thread.md b/work-items/open/20260601-020202-tui-keys-inline-viewport-ui/thread.md deleted file mode 100644 index c2a350f8..00000000 --- a/work-items/open/20260601-020202-tui-keys-inline-viewport-ui/thread.md +++ /dev/null @@ -1,7 +0,0 @@ - - -## Created - -Created by tickets.sh create. - ----