From 45ee5d4feebabbce2a0c587295052eb0e3d311be Mon Sep 17 00:00:00 2001 From: Hare Date: Mon, 8 Jun 2026 11:21:26 +0900 Subject: [PATCH] ticket: record workflow template merge-ready dossier --- .../item.md | 2 +- .../thread.md | 67 +++++++++++++++++++ 2 files changed, 68 insertions(+), 1 deletion(-) diff --git a/.yoi/tickets/open/20260608-014602-remove-non-goals-from-workflow-templates/item.md b/.yoi/tickets/open/20260608-014602-remove-non-goals-from-workflow-templates/item.md index 2eb012aa..581ac7ae 100644 --- a/.yoi/tickets/open/20260608-014602-remove-non-goals-from-workflow-templates/item.md +++ b/.yoi/tickets/open/20260608-014602-remove-non-goals-from-workflow-templates/item.md @@ -8,7 +8,7 @@ priority: 'P2' labels: ['workflow', 'prompt', 'ticket', 'orchestration', 'cleanup'] workflow_state: 'inprogress' created_at: '2026-06-08T01:46:02Z' -updated_at: '2026-06-08T02:05:05Z' +updated_at: '2026-06-08T02:21:20Z' assignee: null legacy_ticket: null queued_by: 'workspace-panel' diff --git a/.yoi/tickets/open/20260608-014602-remove-non-goals-from-workflow-templates/thread.md b/.yoi/tickets/open/20260608-014602-remove-non-goals-from-workflow-templates/thread.md index 570190ab..719a3e09 100644 --- a/.yoi/tickets/open/20260608-014602-remove-non-goals-from-workflow-templates/thread.md +++ b/.yoi/tickets/open/20260608-014602-remove-non-goals-from-workflow-templates/thread.md @@ -186,3 +186,70 @@ Pending: - No merge, close, final approval, or cleanup has occurred for this Ticket. --- + + + +## Implementation report + +Merge-ready dossier: workflow template non-goals cleanup + +Ticket id/slug: +- `20260608-014602-remove-non-goals-from-workflow-templates` / `remove-non-goals-from-workflow-templates` + +Branch/worktree: +- Branch: `remove-non-goals-workflow-templates` +- Worktree: `.worktree/remove-non-goals-workflow-templates` +- Current branch commit: + - `783cd42 workflow: replace non-goals template language` + +Intent / invariant check: +- Maintained workflow templates and role guidance no longer use generic `Non-goals` / `Non-goals / constraints` buckets or the broad `やらないことは何か。` prompt. +- Concrete exclusions remain expressible as binding decisions, invariants, authority boundaries, implementation latitude, and escalation conditions. +- Historical Ticket records/artifacts were not rewritten. +- Ticket workflow/state model, validation guidance, reviewer basis, and escalation guidance were preserved. + +Implementation summary: +- Rewrote maintained workflow templates to replace generic non-goals language with `Binding decisions / invariants`, `Implementation latitude`, and concrete boundary wording. +- Updated Ticket role prompt guidance in `crates/client/src/ticket_role.rs` so reviewer/coder basis no longer includes broad non-goals buckets. +- Updated development work-item documentation to match the maintained workflow language. + +Files touched: +- `.yoi/workflow/ticket-intake-workflow.md` +- `.yoi/workflow/ticket-orchestrator-routing.md` +- `.yoi/workflow/ticket-preflight-workflow.md` +- `.yoi/workflow/multi-agent-workflow.md` +- `crates/client/src/ticket_role.rs` +- `docs/development/work-items.md` + +Coder / reviewer Pods: +- Coder: `coder-remove-non-goals-workflow` +- Reviewer: `reviewer-remove-non-goals-workflow` + +Review evidence: +- Reviewer verdict: `approve`. +- Reviewer confirmed maintained templates/examples remove old `Non-goals` wording and replace it with binding decisions/invariants, implementation latitude, and escalation-focused language. +- Reviewer confirmed Intake no longer asks the broad `やらないことは何か。` prompt. +- Reviewer confirmed no historic Ticket artifacts were touched. + +Validation performed by coder and/or reviewer: +- `cargo fmt --check` +- `cargo test -p client ticket_role` +- maintained old-term search excluding historic Tickets and generated paths +- `git diff --check develop...HEAD` +- `cargo run -q -p yoi -- ticket doctor` +- `nix build .#yoi --no-link` + +Blockers fixed or rejected findings: +- No reviewer blockers. + +Residual risks: +- Some Japanese role/scope sections still say a workflow does not do or handle specific things. Reviewer judged these as concrete role/authority/scope boundaries, not generic optional non-goals buckets. + +Dirty state: +- Child worktree is clean at `783cd42`. +- Main workspace has unrelated Ticket-record changes for other active/new Tickets; they are outside this branch's touched paths and are understood. + +Parent/human decision needs: +- User has authorized merge-completion and cleanup after approved work. Proceeding to merge-completion unless validation fails. + +---