fix: complete Repository access management contracts

This commit is contained in:
2026-08-26 11:38:23 +09:00
parent d1f47e5a22
commit 46f6e2c58b
3 changed files with 86 additions and 6 deletions
@@ -63,12 +63,12 @@
credentials = [...credentials, created].sort((a, b) => a.credential_id.localeCompare(b.credential_id));
credentialId = '';
credentialName = '';
privateKey = '';
passphrase = '';
message = `Credential ${created.credential_id} created. Pasted secret fields were cleared.`;
} catch (error) {
message = error instanceof Error ? error.message : 'Credential creation failed';
} finally {
privateKey = '';
passphrase = '';
pending = false;
}
}
@@ -88,13 +88,13 @@
}
);
credentials = credentials.map((entry) => entry.credential_id === rotated.credential_id ? rotated : entry);
rotatePrivateKey = '';
rotatePassphrase = '';
rotateCredentialId = null;
message = `Credential ${rotated.credential_id} rotated to revision ${rotated.current_revision}. Pasted secret fields were cleared.`;
} catch (error) {
message = error instanceof Error ? error.message : 'Credential rotation failed';
} finally {
rotatePrivateKey = '';
rotatePassphrase = '';
pending = false;
}
}
@@ -0,0 +1,46 @@
type TestRegistrar = (name: string, body: () => void | Promise<void>) => void;
const test =
(globalThis as unknown as { Deno: { test: TestRegistrar } }).Deno.test;
function assert(condition: boolean, message: string): asserts condition {
if (!condition) throw new Error(message);
}
const source = await Deno.readTextFile(
new URL(
"../../src/routes/w/[workspaceId]/settings/repository-access/+page.svelte",
import.meta.url,
),
);
test("Repository credential submissions clear write-only fields in finally blocks", () => {
const createStart = source.indexOf("async function createCredential()");
const rotateStart = source.indexOf("async function rotateCredential(");
const deleteStart = source.indexOf("async function deleteCredential(");
assert(
createStart >= 0 && rotateStart > createStart && deleteStart > rotateStart,
"credential handlers should appear in source order",
);
const createBody = source.slice(createStart, rotateStart);
const rotateBody = source.slice(rotateStart, deleteStart);
for (const token of ["finally", "privateKey = ''", "passphrase = ''"]) {
assert(
createBody.includes(token),
`create handler should contain ${token}`,
);
}
for (
const token of [
"finally",
"rotatePrivateKey = ''",
"rotatePassphrase = ''",
]
) {
assert(
rotateBody.includes(token),
`rotate handler should contain ${token}`,
);
}
});