workspace: remove input readiness capability

This commit is contained in:
2026-07-12 23:43:44 +09:00
parent c948b669c1
commit 4a90267ebc
5 changed files with 31 additions and 57 deletions
@@ -35,7 +35,6 @@ export type RuntimeCapabilities = {
can_get_worker: boolean;
can_spawn_worker: boolean;
can_stop_worker: boolean;
can_accept_input: boolean;
has_workspace_fs: boolean;
has_shell: boolean;
has_git: boolean;
@@ -70,7 +69,6 @@ export type Host = {
};
export type WorkerCapabilities = {
can_accept_input: boolean;
can_stop: boolean;
can_spawn_followup: boolean;
};
@@ -29,7 +29,6 @@ function worker(overrides: Partial<Worker>): Worker {
display_hint: "Runtime Worker",
},
capabilities: {
can_accept_input: true,
can_stop: true,
can_spawn_followup: false,
},
@@ -47,7 +46,6 @@ Deno.test("registry-only workers are not sidebar targets or console targets", ()
display_hint: "Missing Worker",
},
capabilities: {
can_accept_input: false,
can_stop: false,
can_spawn_followup: false,
},
@@ -10,7 +10,8 @@
ClientWorkerEventWsFrame,
Diagnostic,
Worker,
WorkerInputResult
WorkerInputResult,
PodProtocolEvent
} from '$lib/workspace-sidebar/types';
type Props = {
@@ -32,6 +33,7 @@
}
let worker = $state<Worker | null>(null);
let liveWorkerState = $state<string | null>(null);
let workerError = $state<string | null>(null);
let draft = $state('');
let sending = $state(false);
@@ -59,7 +61,9 @@
);
const lines = $derived(projection.lines);
const diagnostics = $derived(mergeDiagnostics(worker?.diagnostics ?? [], streamDiagnostics));
const canSend = $derived(Boolean(worker?.capabilities.can_accept_input) && draft.trim().length > 0 && !sending);
const workerState = $derived(liveWorkerState ?? worker?.state ?? 'loading');
const inputReady = $derived(workerState === 'idle');
const canSend = $derived(inputReady && draft.trim().length > 0 && !sending);
async function getJson<T>(path: string): Promise<T> {
const response = await fetch(path);
@@ -97,12 +101,15 @@
async function loadWorker(target: ConsoleTarget) {
workerError = null;
try {
worker = await getJson<Worker>(
const payload = await getJson<Worker>(
workerApiPath(`/runtimes/${encodeURIComponent(target.runtimeId)}/workers/${encodeURIComponent(target.workerId)}`)
);
worker = payload;
liveWorkerState = payload.state;
} catch (error) {
workerError = error instanceof Error ? error.message : String(error);
worker = null;
liveWorkerState = null;
}
}
@@ -132,7 +139,7 @@
async function sendMessage(event: SubmitEvent) {
event.preventDefault();
const content = draft.trim();
if (!content || sending || !worker?.capabilities.can_accept_input) {
if (!content || sending || !inputReady) {
return;
}
@@ -145,6 +152,7 @@
);
if (result.state === 'accepted') {
draft = '';
liveWorkerState = 'running';
} else {
sendError = diagnosticsToText(result.diagnostics) || `Input was ${result.state}.`;
}
@@ -155,6 +163,18 @@
}
}
function workerStateFromProtocolEvent(event: PodProtocolEvent): string | null {
switch (event.event) {
case 'snapshot':
case 'status':
return event.data.status;
case 'shutdown':
return 'shutdown';
default:
return null;
}
}
function connectObservation(targetWorker: Worker | null, token: number, target: ConsoleTarget) {
if (!targetWorker) {
streamState = 'closed';
@@ -182,6 +202,10 @@
if (!rememberObservationEvent(frame.envelope.event_id)) {
return;
}
const observedState = workerStateFromProtocolEvent(frame.envelope.payload);
if (observedState) {
liveWorkerState = observedState;
}
observedEvents = [
...observedEvents,
{
@@ -304,6 +328,7 @@
$effect(() => {
const target = consoleTarget;
resetObservedEvents();
liveWorkerState = null;
streamDiagnostics = [];
advanceReloadToken();
void loadConsoleData(target);
@@ -324,7 +349,7 @@
</div>
<div class="console-header-actions">
<div class="console-status-pill" class:warn={streamState !== 'open'}>
{worker?.state ?? 'loading'} · stream {streamState}
{workerState} · stream {streamState}
</div>
<button type="button" class="secondary-button" aria-expanded={workerDetailsOpen} onclick={() => workerDetailsOpen = !workerDetailsOpen}>
Details
@@ -430,7 +455,6 @@
<details class="metadata-details">
<summary>Capabilities</summary>
<ul>
<li>input: {worker.capabilities.can_accept_input ? 'available' : 'unsupported'}</li>
<li>stop: {worker.capabilities.can_stop ? 'available' : 'unsupported'}</li>
<li>follow-up spawn: {worker.capabilities.can_spawn_followup ? 'available' : 'unsupported'}</li>
</ul>
@@ -461,7 +485,7 @@
id="worker-console-message"
aria-label="Console input"
bind:value={draft}
disabled={!worker?.capabilities.can_accept_input || sending}
disabled={!inputReady || sending}
></textarea>
<div class="composer-actions">
<button type="submit" disabled={!canSend}>{sending ? 'Sending…' : 'Send'}</button>