From 4f5cc1e884ba91b12fca2d6e0a8661fd0a263e13 Mon Sep 17 00:00:00 2001 From: Hare Date: Thu, 16 Jul 2026 07:41:31 +0900 Subject: [PATCH] ticket: record knowledge guidance fix --- .yoi/tickets/00001KXKP2A71/item.md | 2 +- .yoi/tickets/00001KXKP2A71/thread.md | 28 ++++++++++++++++++++++++++++ 2 files changed, 29 insertions(+), 1 deletion(-) diff --git a/.yoi/tickets/00001KXKP2A71/item.md b/.yoi/tickets/00001KXKP2A71/item.md index b04b1b37..0c2354ca 100644 --- a/.yoi/tickets/00001KXKP2A71/item.md +++ b/.yoi/tickets/00001KXKP2A71/item.md @@ -2,7 +2,7 @@ title: 'Remove Knowledge support' state: 'inprogress' created_at: '2026-07-15T20:04:08Z' -updated_at: '2026-07-15T22:35:41Z' +updated_at: '2026-07-15T22:41:26Z' assignee: null queued_by: 'workspace-panel' queued_at: '2026-07-15T20:27:02Z' diff --git a/.yoi/tickets/00001KXKP2A71/thread.md b/.yoi/tickets/00001KXKP2A71/thread.md index 742dc6fe..5e98838f 100644 --- a/.yoi/tickets/00001KXKP2A71/thread.md +++ b/.yoi/tickets/00001KXKP2A71/thread.md @@ -237,3 +237,31 @@ Non-blocking cleanup: - `crates/tui/src/input.rs:237-269` has stale comments mentioning `#`, though code only triggers `@` file completion。 --- + + + +## Implementation report + +Follow-up implementation progress report after request_changes: + +- Coder Pod `yoi-coder-00001KXKP2A71-knowledge-removal` completed the stale Knowledge guidance fix。 +- Follow-up commit: `ad666503 fix: remove stale knowledge guidance`。 +- Orchestrator inspected worktree status, branch log, commit stats, and `git diff --check f2106407..HEAD`; worktree was clean and diff check passed。 + +Fix summary: +- Updated model-visible Ticket tool description in `crates/ticket/src/tool.rs`: replaced `Memory/Knowledge` language guidance with `Memory`。 +- Updated active design overview in `docs/design/overview.md`: `memory` crate now owns generated Memory summary/decision/request records, not Knowledge records。 +- Updated stale TUI comment in `crates/tui/src/input.rs`: removed `#` from file-completion chip comment。 +- Removed stale “Knowledge records” wording from historical test-validity report text in `docs/report/test-validity-20260612/yoi.md`。 + +Coder-reported validation passed: +- Focused active guidance grep for `Memory/Knowledge|Knowledge records|#` in relevant active files: no hits。 +- Required Knowledge-removal grep for `KnowledgeQuery|kind = knowledge|kind: knowledge|ResidentKnowledge|model_invokation|\\.yoi/knowledge|#`: only remaining hit is `docs/design/memory-knowledge.md:13`, an explicit historical/legacy note saying old `.yoi/knowledge/` is no longer active and current tooling ignores it。 +- `git diff --check` +- `cargo check -p yoi` +- `yoi ticket doctor` +- `nix build .#yoi --no-link` + +No focused behavior tests were re-run for this follow-up because changes were docs/comments/model-visible text only。 + +---