Hare/yoi
1
1
Fork 0
Code Actions Packages Releases Activity

ticket: approve base32 id migration

Browse Source
This commit is contained in:
Keisuke Hirata 2026-06-09 22:24:40 +09:00
parent bd9651bddd
commit 52c5c3afec
No known key found for this signature in database
2 changed files with 32 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.yoi/tickets/20260609-073047-001/item.md
View File

@ -2,7 +2,7 @@
title: 'Ticket と Objective の ID を base32 timestamp 形式に統一する' title: 'Ticket と Objective の ID を base32 timestamp 形式に統一する'
state: 'inprogress' state: 'inprogress'
created_at: '2026-06-09T07:30:47Z' created_at: '2026-06-09T07:30:47Z'
updated_at: '2026-06-09T13:12:25Z' updated_at: '2026-06-09T13:24:34Z'
assignee: null assignee: null
queued_by: 'workspace-panel' queued_by: 'workspace-panel'
queued_at: '2026-06-09T10:31:17Z' queued_at: '2026-06-09T10:31:17Z'

31
.yoi/tickets/20260609-073047-001/thread.md
View File

@ -198,3 +198,34 @@ Reported validation:
Reviewer should verify migration/reference correctness and whether the committed mapping artifact under the migrated current Ticket is the right durable location. Reviewer should verify migration/reference correctness and whether the committed mapping artifact under the migrated current Ticket is the right durable location.
--- ---
<!-- event: review author: reviewer-base32-record-ids at: 2026-06-09T13:24:34Z status: approve -->
## Review: approve
Approved after external review of implementation commit `4203988 feat: unify project record ids`.
Findings:
- Shared `crates/project-record` helper is used by both Ticket and Objective creation paths.
- Fixed-width 13-char base32 Unix epoch millisecond IDs preserve lexicographic chronological order.
- Collision handling uses bounded `+1ms` retry with no suffix/counter/random tail.
- `created_at` / `updated_at` remain human-readable frontmatter and are not silently replaced by collision-adjusted ID timestamps.
- Ticket and Objective current validation/list/show/doctor paths use canonical record IDs.
- Repository migration is coherent across Ticket dirs, Objective dirs, relation artifacts, orchestration-plan artifacts, linked tickets, docs, and tests.
- `id-migration-map.txt` under the migrated Ticket artifact is acceptable audit evidence and does not pollute schema/list/doctor behavior.
Validation run by reviewer and passed:
- `git diff --check HEAD^..HEAD`
- `cargo test -q -p project-record`
- `cargo test -q -p ticket`
- `cargo test -q -p yoi objective_cli`
- `cargo fmt --check`
- `cargo run -q -p yoi -- ticket doctor`
- `cargo run -q -p yoi -- objective doctor`
- `cargo check --workspace`
- `nix build .#yoi`
- `git status --short --untracked-files=all`
Result: approve, merge-ready. Residual risk: migration map intentionally retains old ID strings for audit; not a blocker.
---