diff --git a/work-items/open/20260531-124040-dev-pod-runtime-command-env/artifacts/.gitkeep b/work-items/closed/20260531-124040-dev-pod-runtime-command-env/artifacts/.gitkeep similarity index 100% rename from work-items/open/20260531-124040-dev-pod-runtime-command-env/artifacts/.gitkeep rename to work-items/closed/20260531-124040-dev-pod-runtime-command-env/artifacts/.gitkeep diff --git a/work-items/open/20260531-124040-dev-pod-runtime-command-env/item.md b/work-items/closed/20260531-124040-dev-pod-runtime-command-env/item.md similarity index 98% rename from work-items/open/20260531-124040-dev-pod-runtime-command-env/item.md rename to work-items/closed/20260531-124040-dev-pod-runtime-command-env/item.md index 5f743682..64d79466 100644 --- a/work-items/open/20260531-124040-dev-pod-runtime-command-env/item.md +++ b/work-items/closed/20260531-124040-dev-pod-runtime-command-env/item.md @@ -2,12 +2,12 @@ id: 20260531-124040-dev-pod-runtime-command-env slug: dev-pod-runtime-command-env title: Dev: add Pod runtime executable override env -status: open +status: closed kind: task priority: P2 labels: [cli, pod, env, dev] created_at: 2026-05-31T12:40:40Z -updated_at: 2026-05-31T20:41:28Z +updated_at: 2026-05-31T20:41:56Z assignee: null legacy_ticket: null --- diff --git a/work-items/closed/20260531-124040-dev-pod-runtime-command-env/resolution.md b/work-items/closed/20260531-124040-dev-pod-runtime-command-env/resolution.md new file mode 100644 index 00000000..2d17b8af --- /dev/null +++ b/work-items/closed/20260531-124040-dev-pod-runtime-command-env/resolution.md @@ -0,0 +1,23 @@ +Added `INSOMNIA_POD_RUNTIME_COMMAND` as a narrow development escape hatch for dogfooding/self-rebuild cases where `current_exe()` can point at a deleted debug binary. + +Implementation: +- Added the override in `client::PodRuntimeCommand`. +- Unset/empty values preserve the default `current_exe() + ["pod"]` behavior. +- Non-empty values replace only the executable path and still automatically receive the `pod` prefix argument. +- The value is not shell-parsed and is not argument-split. +- Spawn/restore failure diagnostics include the resolved runtime command. +- Documented the variable in `docs/environment.md` as development-only, not normal user configuration. +- Did not reintroduce `INSOMNIA_POD_COMMAND` or old executable-without-prefix semantics. + +Review: +- External reviewer `dev-pod-runtime-env-reviewer-20260531` approved implementation commit `0031953ed352ba7fae9e798b6aeee1e8ea080816`. +- Reviewer noted a non-blocking future improvement: display formatting for runtime commands could quote argv pieces with spaces more clearly. + +Validation after merge: +- `cargo fmt --check` +- `cargo test -p client runtime_command` +- `cargo test -p client` +- `cargo check -p client -p pod -p tui -p insomnia` (passed with existing dead-code warnings) +- `./tickets.sh doctor` +- `git diff --check` +- `git grep -n "INSOMNIA_POD_COMMAND" -- ':!work-items' || true` produced no active references. diff --git a/work-items/open/20260531-124040-dev-pod-runtime-command-env/thread.md b/work-items/closed/20260531-124040-dev-pod-runtime-command-env/thread.md similarity index 56% rename from work-items/open/20260531-124040-dev-pod-runtime-command-env/thread.md rename to work-items/closed/20260531-124040-dev-pod-runtime-command-env/thread.md index 911143e1..b0e55bdc 100644 --- a/work-items/open/20260531-124040-dev-pod-runtime-command-env/thread.md +++ b/work-items/closed/20260531-124040-dev-pod-runtime-command-env/thread.md @@ -38,4 +38,35 @@ Validation adequacy: - Reviewer performed read-only diff/source/docs/grep review and did not rerun Cargo tests. +--- + + + +## Closed + +Added `INSOMNIA_POD_RUNTIME_COMMAND` as a narrow development escape hatch for dogfooding/self-rebuild cases where `current_exe()` can point at a deleted debug binary. + +Implementation: +- Added the override in `client::PodRuntimeCommand`. +- Unset/empty values preserve the default `current_exe() + ["pod"]` behavior. +- Non-empty values replace only the executable path and still automatically receive the `pod` prefix argument. +- The value is not shell-parsed and is not argument-split. +- Spawn/restore failure diagnostics include the resolved runtime command. +- Documented the variable in `docs/environment.md` as development-only, not normal user configuration. +- Did not reintroduce `INSOMNIA_POD_COMMAND` or old executable-without-prefix semantics. + +Review: +- External reviewer `dev-pod-runtime-env-reviewer-20260531` approved implementation commit `0031953ed352ba7fae9e798b6aeee1e8ea080816`. +- Reviewer noted a non-blocking future improvement: display formatting for runtime commands could quote argv pieces with spaces more clearly. + +Validation after merge: +- `cargo fmt --check` +- `cargo test -p client runtime_command` +- `cargo test -p client` +- `cargo check -p client -p pod -p tui -p insomnia` (passed with existing dead-code warnings) +- `./tickets.sh doctor` +- `git diff --check` +- `git grep -n "INSOMNIA_POD_COMMAND" -- ':!work-items' || true` produced no active references. + + ---