ticket: close hook context sink

This commit is contained in:
Keisuke Hirata 2026-06-05 10:26:09 +09:00
parent 7d71507688
commit 52fa401725
No known key found for this signature in database
7 changed files with 12 additions and 2 deletions

View File

@ -2,12 +2,12 @@
id: 20260605-004807-hook-context-system-item-sink id: 20260605-004807-hook-context-system-item-sink
slug: hook-context-system-item-sink slug: hook-context-system-item-sink
title: Hook: add context handles for host-mediated SystemItem append title: Hook: add context handles for host-mediated SystemItem append
status: open status: closed
kind: feature kind: feature
priority: P1 priority: P1
labels: [hooks, feature-registry, history, task-reminder] labels: [hooks, feature-registry, history, task-reminder]
created_at: 2026-06-05T00:48:07Z created_at: 2026-06-05T00:48:07Z
updated_at: 2026-06-05T01:25:03Z updated_at: 2026-06-05T01:26:06Z
assignee: null assignee: null
legacy_ticket: null legacy_ticket: null
--- ---

View File

@ -0,0 +1 @@
Added PreRequestContext and host-mediated SystemItemAppendHandle for pre-request hooks. Hook returns remain per-hook-point flow-control actions; the append handle has host-private construction and a narrow task-reminder request surface; queued system items commit through the existing LogEntry::SystemItem / Event::SystemItem path only on successful continue. Existing Task reminder ownership remains unchanged for the follow-up ticket. External review approved. Merge validation passed: cargo test -p pod hook --lib, cargo test -p pod --lib, cargo test -p llm-worker --lib, cargo fmt --check, cargo check --workspace --all-targets, ./tickets.sh doctor, git diff --check, nix build .#yoi, ./result/bin/yoi pod --help.

View File

@ -194,4 +194,13 @@ Not rerun:
The remaining risk is in future authority granularity, not this prerequisite implementation: today the handle is present for pre-request hooks when a log writer exists, rather than being selected per installed feature/hook. That should be tightened before exposing hooks to untrusted external plugins. The existing `SystemItemCommitter` API also logs and drops commit failures rather than returning a result; this is pre-existing behavior shared by other SystemItem lanes, but it means disk-write failure handling is not made stronger by this ticket. The remaining risk is in future authority granularity, not this prerequisite implementation: today the handle is present for pre-request hooks when a log writer exists, rather than being selected per installed feature/hook. That should be tightened before exposing hooks to untrusted external plugins. The existing `SystemItemCommitter` API also logs and drops commit failures rather than returning a result; this is pre-existing behavior shared by other SystemItem lanes, but it means disk-write failure handling is not made stronger by this ticket.
---
<!-- event: close author: hare at: 2026-06-05T01:26:06Z status: closed -->
## Closed
Added PreRequestContext and host-mediated SystemItemAppendHandle for pre-request hooks. Hook returns remain per-hook-point flow-control actions; the append handle has host-private construction and a narrow task-reminder request surface; queued system items commit through the existing LogEntry::SystemItem / Event::SystemItem path only on successful continue. Existing Task reminder ownership remains unchanged for the follow-up ticket. External review approved. Merge validation passed: cargo test -p pod hook --lib, cargo test -p pod --lib, cargo test -p llm-worker --lib, cargo fmt --check, cargo check --workspace --all-targets, ./tickets.sh doctor, git diff --check, nix build .#yoi, ./result/bin/yoi pod --help.
--- ---