From 530c14e4b825caf9dd0908bd392cd86d958142a6 Mon Sep 17 00:00:00 2001 From: Hare Date: Sun, 31 May 2026 20:58:30 +0900 Subject: [PATCH] close: remove resource_dir --- .../artifacts/.gitkeep | 0 .../item.md | 4 +- .../resolution.md | 31 +++++++++++++++ .../thread.md | 39 +++++++++++++++++++ 4 files changed, 72 insertions(+), 2 deletions(-) rename work-items/{open => closed}/20260531-110818-remove-resource-dir/artifacts/.gitkeep (100%) rename work-items/{open => closed}/20260531-110818-remove-resource-dir/item.md (98%) create mode 100644 work-items/closed/20260531-110818-remove-resource-dir/resolution.md rename work-items/{open => closed}/20260531-110818-remove-resource-dir/thread.md (79%) diff --git a/work-items/open/20260531-110818-remove-resource-dir/artifacts/.gitkeep b/work-items/closed/20260531-110818-remove-resource-dir/artifacts/.gitkeep similarity index 100% rename from work-items/open/20260531-110818-remove-resource-dir/artifacts/.gitkeep rename to work-items/closed/20260531-110818-remove-resource-dir/artifacts/.gitkeep diff --git a/work-items/open/20260531-110818-remove-resource-dir/item.md b/work-items/closed/20260531-110818-remove-resource-dir/item.md similarity index 98% rename from work-items/open/20260531-110818-remove-resource-dir/item.md rename to work-items/closed/20260531-110818-remove-resource-dir/item.md index 796d7dd7..9b2d73ca 100644 --- a/work-items/open/20260531-110818-remove-resource-dir/item.md +++ b/work-items/closed/20260531-110818-remove-resource-dir/item.md @@ -2,12 +2,12 @@ id: 20260531-110818-remove-resource-dir slug: remove-resource-dir title: Manifest: remove filesystem resource_dir dependency -status: open +status: closed kind: task priority: P2 labels: [manifest, profile, nix, env, cleanup] created_at: 2026-05-31T11:08:18Z -updated_at: 2026-05-31T11:54:28Z +updated_at: 2026-05-31T11:58:28Z assignee: null legacy_ticket: null --- diff --git a/work-items/closed/20260531-110818-remove-resource-dir/resolution.md b/work-items/closed/20260531-110818-remove-resource-dir/resolution.md new file mode 100644 index 00000000..5b99bc86 --- /dev/null +++ b/work-items/closed/20260531-110818-remove-resource-dir/resolution.md @@ -0,0 +1,31 @@ +Removed runtime filesystem resource discovery for bundled assets and removed `INSOMNIA_RESOURCE_DIR` as an active configuration surface. + +Implementation: +- Removed `RESOURCE_DIR_ENV`, `resource_dir()`, and `builtin_profiles_dir()` from `manifest::paths`. +- Embedded builtin Lua profile source (`default.lua`) and exposed builtin profile metadata without fake filesystem paths. +- Preserved user/project registry profile and explicit path profile filesystem semantics. +- Replaced manifest-side builtin model context lookup with an embedded `resources/models/builtin.toml` source, avoiding a `manifest -> provider` dependency. +- Removed installed runtime `share/insomnia/resources` packaging and checks from Nix package output. +- Updated environment/Nix/pod-factory docs so runtime resource directory and `INSOMNIA_RESOURCE_DIR` are no longer supported/documented surfaces. + +Review: +- External reviewer `remove-resource-dir-reviewer-20260531` approved implementation commit `365ec8b7fad008ab36bdc4de3adadb3696739a07`. +- Reviewer found no blockers. A suggested non-blocking future regression test for embedded profile local `require` diagnostics was recorded in the review thread. + +Validation after merge: +- `cargo fmt --check` +- `cargo test -p manifest profile` +- `cargo test -p provider catalog` +- `cargo test -p pod prompt` +- `cargo check -p manifest -p provider -p pod -p tui` +- `./tickets.sh doctor` +- `git diff --check` +- `rg -n 'INSOMNIA_RESOURCE_DIR|RESOURCE_DIR_ENV|resource_dir\(|builtin_profiles_dir\(' crates docs package.nix || true` produced no active hits. +- `nix build .#insomnia` +- `test -x result/bin/insomnia` +- `test ! -e result/bin/insomnia-pod` +- `test ! -e result/share/insomnia/resources` +- `result/bin/insomnia pod --help` + +Note: +- Initial post-merge validation hit `No space left on device` while linking. `cargo clean` freed build artifacts, after which Rust and Nix validation passed. diff --git a/work-items/open/20260531-110818-remove-resource-dir/thread.md b/work-items/closed/20260531-110818-remove-resource-dir/thread.md similarity index 79% rename from work-items/open/20260531-110818-remove-resource-dir/thread.md rename to work-items/closed/20260531-110818-remove-resource-dir/thread.md index 00aaf82a..556b982e 100644 --- a/work-items/open/20260531-110818-remove-resource-dir/thread.md +++ b/work-items/closed/20260531-110818-remove-resource-dir/thread.md @@ -137,4 +137,43 @@ Validation adequacy: - Final Nix validation remains pending due to `No space left on device`, not due to a code review finding. +--- + + + +## Closed + +Removed runtime filesystem resource discovery for bundled assets and removed `INSOMNIA_RESOURCE_DIR` as an active configuration surface. + +Implementation: +- Removed `RESOURCE_DIR_ENV`, `resource_dir()`, and `builtin_profiles_dir()` from `manifest::paths`. +- Embedded builtin Lua profile source (`default.lua`) and exposed builtin profile metadata without fake filesystem paths. +- Preserved user/project registry profile and explicit path profile filesystem semantics. +- Replaced manifest-side builtin model context lookup with an embedded `resources/models/builtin.toml` source, avoiding a `manifest -> provider` dependency. +- Removed installed runtime `share/insomnia/resources` packaging and checks from Nix package output. +- Updated environment/Nix/pod-factory docs so runtime resource directory and `INSOMNIA_RESOURCE_DIR` are no longer supported/documented surfaces. + +Review: +- External reviewer `remove-resource-dir-reviewer-20260531` approved implementation commit `365ec8b7fad008ab36bdc4de3adadb3696739a07`. +- Reviewer found no blockers. A suggested non-blocking future regression test for embedded profile local `require` diagnostics was recorded in the review thread. + +Validation after merge: +- `cargo fmt --check` +- `cargo test -p manifest profile` +- `cargo test -p provider catalog` +- `cargo test -p pod prompt` +- `cargo check -p manifest -p provider -p pod -p tui` +- `./tickets.sh doctor` +- `git diff --check` +- `rg -n 'INSOMNIA_RESOURCE_DIR|RESOURCE_DIR_ENV|resource_dir\(|builtin_profiles_dir\(' crates docs package.nix || true` produced no active hits. +- `nix build .#insomnia` +- `test -x result/bin/insomnia` +- `test ! -e result/bin/insomnia-pod` +- `test ! -e result/share/insomnia/resources` +- `result/bin/insomnia pod --help` + +Note: +- Initial post-merge validation hit `No space left on device` while linking. `cargo clean` freed build artifacts, after which Rust and Nix validation passed. + + ---