feat: authenticate Workspace API requests

This commit is contained in:
2026-08-24 13:32:55 +09:00
parent 3c2664c3ce
commit 53edaadc3a
3 changed files with 756 additions and 70 deletions
+636 -58
View File
@@ -323,6 +323,12 @@ impl ServerConfig {
const ORCHESTRATOR_ATTENTION_TICKET_LIMIT: usize = 20; const ORCHESTRATOR_ATTENTION_TICKET_LIMIT: usize = 20;
const ORCHESTRATOR_ATTENTION_PROMPT_NAME: &str = "internal.workspace_orchestrator_queue_attention"; const ORCHESTRATOR_ATTENTION_PROMPT_NAME: &str = "internal.workspace_orchestrator_queue_attention";
static EMBEDDED_RUNTIME_REQUEST_IDENTITY: std::sync::LazyLock<
worker_runtime::auth::RuntimeIdentityMaterial,
> = std::sync::LazyLock::new(|| {
worker_runtime::auth::RuntimeIdentityMaterial::generate(EMBEDDED_RUNTIME_ID)
.expect("embedded Runtime request identity generation must succeed")
});
#[derive(Clone)] #[derive(Clone)]
pub struct WorkspaceApi { pub struct WorkspaceApi {
@@ -786,7 +792,7 @@ impl WorkspaceServerApi {
.for_catalog_workspace(&workspace, repositories)?; .for_catalog_workspace(&workspace, repositories)?;
let api = WorkspaceApi::new(config, self.store.clone()).await?; let api = WorkspaceApi::new(config, self.store.clone()).await?;
tokio::spawn(run_orchestrator_turn_end_hook(api.clone())); tokio::spawn(run_orchestrator_turn_end_hook(api.clone()));
let router = build_router(api); let router = build_inner_router(api);
routers.insert(workspace_id.to_string(), router.clone()); routers.insert(workspace_id.to_string(), router.clone());
Ok(Some(router)) Ok(Some(router))
} }
@@ -886,12 +892,173 @@ async fn resolve_server_actor(
resolve_request_actor(api.store.as_ref(), headers, &cookie_name).await resolve_request_actor(api.store.as_ref(), headers, &cookie_name).await
} }
async fn authorize_scoped_workspace_request(
api: &WorkspaceServerApi,
workspace_id: &str,
request: &mut Request,
) -> std::result::Result<(), Response> {
let proof = request
.headers()
.get(worker_runtime::auth::RUNTIME_REQUEST_SOURCE_PROOF_HEADER)
.and_then(|value| value.to_str().ok())
.map(str::to_owned);
if let Some(proof) = proof {
let method = request.method().as_str().to_owned();
let path = request.uri().path().to_owned();
let body = std::mem::take(request.body_mut());
let body = axum::body::to_bytes(body, 16 * 1024 * 1024)
.await
.map_err(|_| StatusCode::BAD_REQUEST.into_response())?;
let digest = worker_runtime::auth::request_body_digest(&body);
*request.body_mut() = axum::body::Body::from(body);
let permission = if path.starts_with("/api/runtime/v1/workspaces/")
|| path.contains("/profile-source-archive/")
{
worker_runtime::auth::BACKEND_RESOURCE_FETCH_PERMISSION
} else {
worker_runtime::auth::WORKSPACE_REQUEST_PERMISSION
};
let source = crate::worker_source::verify_runtime_request_source_proof_with_store(
api.store.as_ref(),
api.template.as_ref(),
&proof,
workspace_id,
permission,
&method,
&path,
&digest,
)
.await
.map_err(|_| StatusCode::UNAUTHORIZED.into_response())?;
request.extensions_mut().insert(source);
return Ok(());
}
let actor = resolve_server_actor(api, request.headers())
.await
.map_err(server_error_response)?;
if actor.is_none() {
return Err(StatusCode::UNAUTHORIZED.into_response());
}
let cookie_authenticated = request
.headers()
.get(axum::http::header::AUTHORIZATION)
.is_none();
let mutating = !matches!(
*request.method(),
Method::GET | Method::HEAD | Method::OPTIONS
);
if cookie_authenticated && mutating {
let AuthConfig::Passkey { origin, .. } = &api.template.auth;
if origin
!= request
.headers()
.get(ORIGIN)
.and_then(|value| value.to_str().ok())
.unwrap_or_default()
{
return Err(StatusCode::FORBIDDEN.into_response());
}
}
Ok(())
}
async fn authorize_workspace_api_request(
State(api): State<WorkspaceApi>,
mut request: Request,
next: axum::middleware::Next,
) -> Response {
if !request.uri().path().starts_with("/api/w/") {
return next.run(request).await;
}
let workspace_id = api.workspace_id().to_owned();
let proof = request
.headers()
.get(worker_runtime::auth::RUNTIME_REQUEST_SOURCE_PROOF_HEADER)
.and_then(|value| value.to_str().ok())
.map(str::to_owned);
if let Some(proof) = proof {
let method = request.method().as_str().to_owned();
let path = request.uri().path().to_owned();
let body = std::mem::take(request.body_mut());
let Ok(body) = axum::body::to_bytes(body, 16 * 1024 * 1024).await else {
return StatusCode::BAD_REQUEST.into_response();
};
let digest = worker_runtime::auth::request_body_digest(&body);
*request.body_mut() = axum::body::Body::from(body);
let permission = if path.contains("/profile-source-archive/") {
worker_runtime::auth::BACKEND_RESOURCE_FETCH_PERMISSION
} else {
worker_runtime::auth::WORKSPACE_REQUEST_PERMISSION
};
let Ok(source) = crate::worker_source::verify_runtime_request_source_proof(
&api,
&proof,
&workspace_id,
permission,
&method,
&path,
&digest,
)
.await
else {
return StatusCode::UNAUTHORIZED.into_response();
};
request.extensions_mut().insert(source);
return next.run(request).await;
}
let AuthConfig::Passkey { cookie_name, .. } = &api.config.auth;
let actor = match crate::auth::resolve_request_actor(
api.store.as_ref(),
request.headers(),
cookie_name,
)
.await
{
Ok(actor) => actor,
Err(_) => return StatusCode::UNAUTHORIZED.into_response(),
};
if actor.is_none() {
return StatusCode::UNAUTHORIZED.into_response();
}
let cookie_authenticated = request
.headers()
.get(axum::http::header::AUTHORIZATION)
.is_none();
let mutating = !matches!(
*request.method(),
Method::GET | Method::HEAD | Method::OPTIONS
);
if cookie_authenticated && mutating {
let AuthConfig::Passkey { origin, .. } = &api.config.auth;
if origin
!= request
.headers()
.get(ORIGIN)
.and_then(|value| value.to_str().ok())
.unwrap_or_default()
{
return StatusCode::FORBIDDEN.into_response();
}
}
next.run(request).await
}
async fn dispatch_workspace_request( async fn dispatch_workspace_request(
State(api): State<WorkspaceServerApi>, State(api): State<WorkspaceServerApi>,
request: Request, mut request: Request,
) -> Response { ) -> Response {
let path = request.uri().path(); let path = request.uri().path().to_owned();
let workspace_id = scoped_workspace_id(path); let workspace_id = scoped_workspace_id(&path);
if let Some(workspace_id) = workspace_id
&& (path.starts_with("/api/w/") || path.starts_with("/api/runtime/v1/workspaces/"))
&& let Err(response) =
authorize_scoped_workspace_request(&api, workspace_id, &mut request).await
{
return response;
}
let router = if let Some(workspace_id) = workspace_id { let router = if let Some(workspace_id) = workspace_id {
match api.router_for_workspace(workspace_id).await { match api.router_for_workspace(workspace_id).await {
Ok(Some(router)) => Some(router), Ok(Some(router)) => Some(router),
@@ -903,10 +1070,10 @@ async fn dispatch_workspace_request(
Ok(workspaces) => workspaces, Ok(workspaces) => workspaces,
Err(error) => return server_error_response(error), Err(error) => return server_error_response(error),
}; };
if workspaces.is_empty() && is_server_static_forward(path) { if workspaces.is_empty() && is_server_static_forward(&path) {
return serve_server_static_shell(&api, path).await; return serve_server_static_shell(&api, &path).await;
} }
if workspaces.len() == 1 || is_server_global_forward(path) { if workspaces.len() == 1 || is_server_global_forward(&path) {
match workspaces.first() { match workspaces.first() {
Some(workspace) => match api.router_for_workspace(&workspace.workspace_id).await { Some(workspace) => match api.router_for_workspace(&workspace.workspace_id).await {
Ok(router) => router, Ok(router) => router,
@@ -948,6 +1115,12 @@ async fn serve_server_static_shell(api: &WorkspaceServerApi, path: &str) -> Resp
} }
fn scoped_workspace_id(path: &str) -> Option<&str> { fn scoped_workspace_id(path: &str) -> Option<&str> {
if let Some(rest) = path.strip_prefix("/api/runtime/v1/workspaces/") {
return rest
.split('/')
.next()
.filter(|workspace_id| !workspace_id.is_empty());
}
let mut segments = path.trim_start_matches('/').split('/'); let mut segments = path.trim_start_matches('/').split('/');
match (segments.next(), segments.next(), segments.next()) { match (segments.next(), segments.next(), segments.next()) {
(Some("api"), Some("w"), Some(workspace_id)) (Some("api"), Some("w"), Some(workspace_id))
@@ -992,6 +1165,20 @@ impl WorkspaceApi {
pub async fn new(config: ServerConfig, store: Arc<dyn ControlPlaneStore>) -> Result<Self> { pub async fn new(config: ServerConfig, store: Arc<dyn ControlPlaneStore>) -> Result<Self> {
let resource_broker = BackendResourceBroker::default(); let resource_broker = BackendResourceBroker::default();
let embedded_identity = (*EMBEDDED_RUNTIME_REQUEST_IDENTITY).clone();
store
.upsert_trusted_runtime_record(&crate::store::TrustedRuntimeRecord {
runtime_id: EMBEDDED_RUNTIME_ID.to_owned(),
workspace_id: None,
display_name: "Embedded Runtime".to_owned(),
base_url: "in-process://embedded".to_owned(),
public_key: embedded_identity.public_key.clone(),
created_at: config.workspace_created_at.clone(),
updated_at: config.workspace_created_at.clone(),
revoked_at: None,
})
.await?;
let embedded_audience = format!("embedded:{}", config.workspace_id);
let worker_remove_dispatcher = Arc::new( let worker_remove_dispatcher = Arc::new(
crate::worker_source::EmbeddedServerWorkerMutationDispatcher::new( crate::worker_source::EmbeddedServerWorkerMutationDispatcher::new(
config.clone(), config.clone(),
@@ -1004,6 +1191,7 @@ impl WorkspaceApi {
EMBEDDED_RUNTIME_ID, EMBEDDED_RUNTIME_ID,
worker_remove_dispatcher.clone(), worker_remove_dispatcher.clone(),
) )
.with_runtime_request_identity(embedded_identity, embedded_audience)
.with_runtime_store_dir(config.embedded_runtime_store_root.clone()) .with_runtime_store_dir(config.embedded_runtime_store_root.clone())
.with_controller_transport(worker::WorkerControllerTransport::InProcess) .with_controller_transport(worker::WorkerControllerTransport::InProcess)
.with_resource_client(Arc::new(resource_broker.clone())), .with_resource_client(Arc::new(resource_broker.clone())),
@@ -1603,7 +1791,7 @@ fn build_server_auth_router(api: ServerAuthApi) -> Router {
.with_state(api) .with_state(api)
} }
pub fn build_router(api: WorkspaceApi) -> Router { fn build_inner_router(api: WorkspaceApi) -> Router {
let auth = build_server_auth_router(ServerAuthApi::from(&api)); let auth = build_server_auth_router(ServerAuthApi::from(&api));
let scoped_ticket_relations_query_path = let scoped_ticket_relations_query_path =
format!("/api/w/{{workspace_id}}{TICKET_RELATIONS_QUERY_PATH}"); format!("/api/w/{{workspace_id}}{TICKET_RELATIONS_QUERY_PATH}");
@@ -2019,7 +2207,7 @@ pub fn build_router(api: WorkspaceApi) -> Router {
post(scoped_test_remote_runtime_connection), post(scoped_test_remote_runtime_connection),
) )
.route( .route(
"/internal/w/{workspace_id}/runtime/resources/fetch", "/api/runtime/v1/workspaces/{workspace_id}/resources/fetch",
post(scoped_post_internal_runtime_resource_fetch), post(scoped_post_internal_runtime_resource_fetch),
) )
.route("/api/companion/status", get(get_companion_status)) .route("/api/companion/status", get(get_companion_status))
@@ -2215,6 +2403,13 @@ pub async fn serve_workspace_catalog(
Ok(()) Ok(())
} }
pub fn build_router(api: WorkspaceApi) -> Router {
build_inner_router(api.clone()).layer(axum::middleware::from_fn_with_state(
api,
authorize_workspace_api_request,
))
}
pub async fn serve( pub async fn serve(
config: ServerConfig, config: ServerConfig,
store: Arc<dyn ControlPlaneStore>, store: Arc<dyn ControlPlaneStore>,
@@ -10271,7 +10466,8 @@ fn browser_worker_response_from_summary(
async fn scoped_post_internal_runtime_resource_fetch( async fn scoped_post_internal_runtime_resource_fetch(
State(api): State<WorkspaceApi>, State(api): State<WorkspaceApi>,
AxumPath(workspace_id): AxumPath<String>, AxumPath(workspace_id): AxumPath<String>,
Json(request): Json<BackendResourceFetchRequest>, headers: HeaderMap,
request: Request,
) -> std::result::Result< ) -> std::result::Result<
Json<worker_runtime::resource::BackendResourceFetchResponse>, Json<worker_runtime::resource::BackendResourceFetchResponse>,
(StatusCode, Json<BackendResourceError>), (StatusCode, Json<BackendResourceError>),
@@ -10282,6 +10478,80 @@ async fn scoped_post_internal_runtime_resource_fetch(
Json(BackendResourceError::MissingResource), Json(BackendResourceError::MissingResource),
)); ));
} }
let proof = headers
.get(worker_runtime::auth::RUNTIME_REQUEST_SOURCE_PROOF_HEADER)
.and_then(|value| value.to_str().ok())
.filter(|value| !value.trim().is_empty())
.ok_or_else(|| {
(
StatusCode::UNAUTHORIZED,
Json(BackendResourceError::Unauthorized {
message: "Runtime request proof is required".to_owned(),
}),
)
})?;
let verified_source = request
.extensions()
.get::<crate::worker_source::VerifiedRuntimeRequestSource>()
.cloned();
let method = request.method().as_str().to_owned();
let path = request.uri().path().to_owned();
let body = axum::body::to_bytes(request.into_body(), 16 * 1024 * 1024)
.await
.map_err(|error| {
(
StatusCode::BAD_REQUEST,
Json(BackendResourceError::InvalidResponse {
message: error.to_string(),
}),
)
})?;
let source = if let Some(source) = verified_source {
source
} else {
crate::worker_source::verify_runtime_request_source_proof(
&api,
proof,
&workspace_id,
worker_runtime::auth::BACKEND_RESOURCE_FETCH_PERMISSION,
&method,
&path,
&worker_runtime::auth::request_body_digest(&body),
)
.await
.map_err(|_| {
(
StatusCode::UNAUTHORIZED,
Json(BackendResourceError::Unauthorized {
message: "Runtime request proof is invalid".to_owned(),
}),
)
})?
};
if source.worker_id.is_some() {
return Err((
StatusCode::UNAUTHORIZED,
Json(BackendResourceError::Unauthorized {
message: "Worker-scoped proof cannot fetch Runtime resources".to_owned(),
}),
));
}
let request: BackendResourceFetchRequest = serde_json::from_slice(&body).map_err(|error| {
(
StatusCode::BAD_REQUEST,
Json(BackendResourceError::InvalidResponse {
message: error.to_string(),
}),
)
})?;
if request.runtime_id != source.runtime_id {
return Err((
StatusCode::UNAUTHORIZED,
Json(BackendResourceError::Unauthorized {
message: "Runtime request proof subject does not match the request".to_owned(),
}),
));
}
api.resource_broker api.resource_broker
.fetch_profile_source_archive(request) .fetch_profile_source_archive(request)
.map(Json) .map(Json)
@@ -13399,10 +13669,133 @@ mod tests {
WorkerOperationState, WorkerSpawnAcceptanceRequirement, WorkerSpawnIntent, WorkerOperationState, WorkerSpawnAcceptanceRequirement, WorkerSpawnIntent,
}; };
use crate::store::{ use crate::store::{
MemoryDocumentRecord, MemoryStagingRecord, ObjectiveRecord, ObjectiveResourceRecord, AccountRecord, ApiTokenRecord, BrowserSessionRecord, MemoryDocumentRecord,
ObjectiveTicketLinkRecord, SqliteWorkspaceStore, WorkspaceRecord, MemoryStagingRecord, ObjectiveRecord, ObjectiveResourceRecord, ObjectiveTicketLinkRecord,
SqliteWorkspaceStore, TrustedRuntimeRecord, UserRecord, WorkspaceRecord,
}; };
fn seed_test_api_token(store: &dyn ControlPlaneStore, suffix: &str) -> String {
let account_id = format!("account-{suffix}");
let user_id = format!("user-{suffix}");
let token = format!("api-token-{suffix}");
store
.upsert_account(&AccountRecord {
account_id: account_id.clone(),
kind: "user".to_owned(),
handle: format!("user-{suffix}"),
display_name: "Test User".to_owned(),
created_at: "2026-01-01T00:00:00Z".to_owned(),
updated_at: "2026-01-01T00:00:00Z".to_owned(),
})
.unwrap();
store
.upsert_user(&UserRecord {
user_id: user_id.clone(),
account_id,
handle: format!("user-{suffix}"),
display_name: "Test User".to_owned(),
created_at: "2026-01-01T00:00:00Z".to_owned(),
updated_at: "2026-01-01T00:00:00Z".to_owned(),
})
.unwrap();
store
.create_api_token(&ApiTokenRecord {
token_hash: crate::auth::token_hash(&token),
token_id: format!("token-{suffix}"),
user_id,
label: "test".to_owned(),
created_at: "2026-01-01T00:00:00Z".to_owned(),
expires_at: None,
last_used_at: None,
revoked_at: None,
})
.unwrap();
token
}
fn configure_runtime_request_auth(
api: &mut WorkspaceApi,
identity: &worker_runtime::auth::RuntimeIdentityMaterial,
runtime_id: &str,
) {
api.config.remote_runtime_sources.push(RemoteRuntimeConfig {
runtime_id: runtime_id.to_owned(),
workspace_id: Some(api.workspace_id().to_owned()),
display_name: runtime_id.to_owned(),
base_url: "https://runtime.test".to_owned(),
bearer_token: None,
auth: Some(RemoteRuntimeAuthConfig {
server_id: "server-test".to_owned(),
server_private_key: "unused".to_owned(),
}),
cached_capabilities: RuntimeCapabilitySummary {
can_list_hosts: true,
can_list_workers: true,
can_get_worker: true,
can_spawn_worker: true,
can_stop_worker: true,
has_workspace_fs: false,
has_shell: false,
has_git: false,
supports_worktrees: false,
supports_backend_internal_tools: false,
workspace_scope: api.workspace_id().to_owned(),
max_workers: 1,
os: "test".to_owned(),
arch: "test".to_owned(),
},
cached_status: "connected".to_owned(),
timeout: std::time::Duration::from_secs(1),
});
SqliteWorkspaceStore::open(&api.config.database_path)
.unwrap()
.upsert_trusted_runtime(&TrustedRuntimeRecord {
runtime_id: runtime_id.to_owned(),
workspace_id: Some(api.workspace_id().to_owned()),
display_name: runtime_id.to_owned(),
base_url: "https://runtime.test".to_owned(),
public_key: identity.public_key.clone(),
created_at: "2026-01-01T00:00:00Z".to_owned(),
updated_at: "2026-01-01T00:00:00Z".to_owned(),
revoked_at: None,
})
.unwrap();
}
fn runtime_resource_fetch_request(
api: &WorkspaceApi,
identity: &worker_runtime::auth::RuntimeIdentityMaterial,
body: Vec<u8>,
) -> Request<Body> {
let path = format!(
"/api/runtime/v1/workspaces/{}/resources/fetch",
api.workspace_id()
);
let proof = worker_runtime::auth::RuntimeRequestSourceSigner::from_identity(identity)
.issue(
"server-test",
api.workspace_id(),
None,
worker_runtime::auth::BACKEND_RESOURCE_FETCH_PERMISSION,
"POST",
&path,
&body,
i64::try_from(worker_runtime::auth::unix_now_seconds()).unwrap_or(i64::MAX),
30,
)
.unwrap();
Request::builder()
.method("POST")
.uri(path)
.header(CONTENT_TYPE, "application/json")
.header(
worker_runtime::auth::RUNTIME_REQUEST_SOURCE_PROOF_HEADER,
proof,
)
.body(Body::from(body))
.unwrap()
}
fn test_create_binding() -> WorkerCreateBinding { fn test_create_binding() -> WorkerCreateBinding {
WorkerCreateBinding { WorkerCreateBinding {
worker_id: WorkerId::now_v7(), worker_id: WorkerId::now_v7(),
@@ -15127,6 +15520,167 @@ mod tests {
assert!(auth["cookie_name"].is_string()); assert!(auth["cookie_name"].is_string());
} }
#[tokio::test]
async fn workspace_server_router_requires_identity_for_scoped_rest() {
let temp = tempfile::tempdir().unwrap();
let config = test_server_config(temp.path());
let AuthConfig::Passkey {
origin: expected_origin,
..
} = &config.auth;
let expected_origin = expected_origin.clone();
let store = Arc::new(SqliteWorkspaceStore::open(&config.database_path).unwrap());
let catalog = WorkspaceCatalogService::new(store.clone());
let repository = temp.path().join("repository");
std::fs::create_dir_all(&repository).unwrap();
assert!(
std::process::Command::new("git")
.args(["init", "-q"])
.current_dir(&repository)
.status()
.unwrap()
.success()
);
let workspace = catalog
.create(
WorkspaceCreateRequest {
operation_key: "create-auth".to_owned(),
display_name: "Auth Workspace".to_owned(),
repository: crate::workspace_catalog::InitialRepositoryIntent {
uri: repository.display().to_string(),
display_name: None,
default_ref: None,
},
},
None,
)
.unwrap();
store
.upsert_account(&AccountRecord {
account_id: "account-auth".to_owned(),
kind: "user".to_owned(),
handle: "auth-user".to_owned(),
display_name: "Auth User".to_owned(),
created_at: "2026-01-01T00:00:00Z".to_owned(),
updated_at: "2026-01-01T00:00:00Z".to_owned(),
})
.unwrap();
store
.upsert_user(&UserRecord {
user_id: "user-auth".to_owned(),
account_id: "account-auth".to_owned(),
handle: "auth-user".to_owned(),
display_name: "Auth User".to_owned(),
created_at: "2026-01-01T00:00:00Z".to_owned(),
updated_at: "2026-01-01T00:00:00Z".to_owned(),
})
.unwrap();
store
.create_api_token(&ApiTokenRecord {
token_hash: crate::auth::token_hash("api-token-auth"),
token_id: "token-auth".to_owned(),
user_id: "user-auth".to_owned(),
label: "test".to_owned(),
created_at: "2026-01-01T00:00:00Z".to_owned(),
expires_at: None,
last_used_at: None,
revoked_at: None,
})
.unwrap();
store
.create_browser_session(&BrowserSessionRecord {
token_hash: crate::auth::token_hash("browser-session-auth"),
session_id: "session-auth".to_owned(),
user_id: "user-auth".to_owned(),
created_at: "2026-01-01T00:00:00Z".to_owned(),
expires_at: "2099-01-01T00:00:00Z".to_owned(),
revoked_at: None,
})
.unwrap();
let app = build_workspace_server_router(config, store).await.unwrap();
let uri = format!("/api/w/{}/workspace", workspace.workspace.workspace_id);
let anonymous = app
.clone()
.oneshot(Request::builder().uri(&uri).body(Body::empty()).unwrap())
.await
.unwrap();
assert_eq!(anonymous.status(), StatusCode::UNAUTHORIZED);
let ws_uri = format!("/api/w/{}/protocol/ws", workspace.workspace.workspace_id);
let anonymous_ws = app
.clone()
.oneshot(Request::builder().uri(&ws_uri).body(Body::empty()).unwrap())
.await
.unwrap();
assert_eq!(anonymous_ws.status(), StatusCode::UNAUTHORIZED);
let authenticated_ws = app
.clone()
.oneshot(
Request::builder()
.uri(ws_uri)
.header(axum::http::header::AUTHORIZATION, "Bearer api-token-auth")
.body(Body::empty())
.unwrap(),
)
.await
.unwrap();
assert_ne!(authenticated_ws.status(), StatusCode::UNAUTHORIZED);
let authenticated = app
.clone()
.oneshot(
Request::builder()
.uri(&uri)
.header(axum::http::header::AUTHORIZATION, "Bearer api-token-auth")
.body(Body::empty())
.unwrap(),
)
.await
.unwrap();
assert_eq!(authenticated.status(), StatusCode::OK);
let settings_uri = format!(
"/api/w/{}/settings/workspace",
workspace.workspace.workspace_id
);
let csrf_rejected = app
.clone()
.oneshot(
Request::builder()
.method(Method::PUT)
.uri(&settings_uri)
.header(
axum::http::header::COOKIE,
"yoi_workspace_session=browser-session-auth",
)
.header(CONTENT_TYPE, "application/json")
.body(Body::from(r#"{"display_name":"Renamed"}"#))
.unwrap(),
)
.await
.unwrap();
assert_eq!(csrf_rejected.status(), StatusCode::FORBIDDEN);
let csrf_accepted = app
.oneshot(
Request::builder()
.method(Method::PUT)
.uri(settings_uri)
.header(
axum::http::header::COOKIE,
"yoi_workspace_session=browser-session-auth",
)
.header(ORIGIN, expected_origin)
.header(CONTENT_TYPE, "application/json")
.body(Body::from(r#"{"display_name":"Renamed"}"#))
.unwrap(),
)
.await
.unwrap();
assert_ne!(csrf_accepted.status(), StatusCode::FORBIDDEN);
}
#[tokio::test] #[tokio::test]
async fn server_router_dispatches_two_workspace_contexts_without_state_leakage() { async fn server_router_dispatches_two_workspace_contexts_without_state_leakage() {
let dir = tempfile::tempdir().unwrap(); let dir = tempfile::tempdir().unwrap();
@@ -15178,13 +15732,17 @@ mod tests {
None, None,
) )
.unwrap(); .unwrap();
let token = seed_test_api_token(store.as_ref(), "two-workspaces");
let app = build_workspace_server_router(template, store) let app = build_workspace_server_router(template, store)
.await .await
.unwrap(); .unwrap();
let uri_a = format!("/api/w/{}/workspace", workspace_a.workspace.workspace_id); let uri_a = format!("/api/w/{}/workspace", workspace_a.workspace.workspace_id);
let uri_b = format!("/api/w/{}/workspace", workspace_b.workspace.workspace_id); let uri_b = format!("/api/w/{}/workspace", workspace_b.workspace.workspace_id);
let (a, b) = tokio::join!(get_json(app.clone(), &uri_a), get_json(app.clone(), &uri_b)); let (a, b) = tokio::join!(
get_json_authenticated(app.clone(), &uri_a, &token),
get_json_authenticated(app.clone(), &uri_b, &token)
);
assert_eq!(a["workspace_id"], workspace_a.workspace.workspace_id); assert_eq!(a["workspace_id"], workspace_a.workspace.workspace_id);
assert_eq!(a["display_name"], "Workspace A"); assert_eq!(a["display_name"], "Workspace A");
assert_eq!(b["workspace_id"], workspace_b.workspace.workspace_id); assert_eq!(b["workspace_id"], workspace_b.workspace.workspace_id);
@@ -15242,7 +15800,7 @@ mod tests {
.clone() .clone()
.oneshot( .oneshot(
Request::post(format!( Request::post(format!(
"/internal/w/{}/runtime/resources/fetch", "/api/runtime/v1/workspaces/{}/resources/fetch",
workspace_b.workspace.workspace_id workspace_b.workspace.workspace_id
)) ))
.header(axum::http::header::CONTENT_TYPE, "application/json") .header(axum::http::header::CONTENT_TYPE, "application/json")
@@ -15259,19 +15817,13 @@ mod tests {
) )
.await .await
.unwrap(); .unwrap();
assert_eq!(resource_response.status(), StatusCode::NOT_FOUND); assert_eq!(resource_response.status(), StatusCode::UNAUTHORIZED);
let resource_error: BackendResourceError = serde_json::from_slice(
&to_bytes(resource_response.into_body(), usize::MAX)
.await
.unwrap(),
)
.unwrap();
assert_eq!(resource_error, BackendResourceError::MissingResource);
let missing = app let missing = app
.oneshot( .oneshot(
Request::builder() Request::builder()
.uri("/api/w/00000000-0000-0000-0000-000000000001/workspace") .uri("/api/w/00000000-0000-0000-0000-000000000001/workspace")
.header(axum::http::header::AUTHORIZATION, format!("Bearer {token}"))
.body(Body::empty()) .body(Body::empty())
.unwrap(), .unwrap(),
) )
@@ -15287,6 +15839,7 @@ mod tests {
std::fs::create_dir_all(repository.join(".git")).unwrap(); std::fs::create_dir_all(repository.join(".git")).unwrap();
let template = test_server_config(dir.path()).with_local_workspace_bootstrap(true); let template = test_server_config(dir.path()).with_local_workspace_bootstrap(true);
let store = Arc::new(SqliteWorkspaceStore::open(&template.database_path).unwrap()); let store = Arc::new(SqliteWorkspaceStore::open(&template.database_path).unwrap());
let token = seed_test_api_token(store.as_ref(), "bootstrap");
let app = build_workspace_server_router(template, store) let app = build_workspace_server_router(template, store)
.await .await
.unwrap(); .unwrap();
@@ -15317,7 +15870,12 @@ mod tests {
let body: Value = serde_json::from_slice(&body).unwrap(); let body: Value = serde_json::from_slice(&body).unwrap();
let workspace_id = body["workspace"]["workspace_id"].as_str().unwrap(); let workspace_id = body["workspace"]["workspace_id"].as_str().unwrap();
let workspace = get_json(app.clone(), &format!("/api/w/{workspace_id}/workspace")).await; let workspace = get_json_authenticated(
app.clone(),
&format!("/api/w/{workspace_id}/workspace"),
&token,
)
.await;
assert_eq!(workspace["display_name"], "Created Workspace"); assert_eq!(workspace["display_name"], "Created Workspace");
let replayed = app let replayed = app
@@ -16105,7 +16663,7 @@ mod tests {
"x-yoi-worker-id", "x-yoi-worker-id",
axum::http::HeaderValue::from_str(&source_worker.worker.worker_id).unwrap(), axum::http::HeaderValue::from_str(&source_worker.worker.worker_id).unwrap(),
); );
let response = build_router(api.clone()) let response = build_inner_router(api.clone())
.oneshot( .oneshot(
Request::builder() Request::builder()
.method("POST") .method("POST")
@@ -17532,7 +18090,7 @@ mod tests {
)); ));
let temp = tempfile::tempdir().unwrap(); let temp = tempfile::tempdir().unwrap();
let app = build_router(test_api(temp.path()).await); let app = build_inner_router(test_api(temp.path()).await);
let body = r#"{"target_runtime_id":"runtime-target","target_worker_id":"target-worker","reason":"retire target Worker"}"#; let body = r#"{"target_runtime_id":"runtime-target","target_worker_id":"target-worker","reason":"retire target Worker"}"#;
let browser = app let browser = app
.clone() .clone()
@@ -18017,7 +18575,7 @@ mod tests {
60, 60,
) )
.unwrap(); .unwrap();
let route_response = build_router(api.clone()) let route_response = build_inner_router(api.clone())
.oneshot( .oneshot(
Request::builder() Request::builder()
.method("POST") .method("POST")
@@ -18227,7 +18785,7 @@ mod tests {
let workspace = tempfile::tempdir().unwrap(); let workspace = tempfile::tempdir().unwrap();
init_clean_git_workspace(workspace.path()); init_clean_git_workspace(workspace.path());
let api = test_api(workspace.path()).await; let api = test_api(workspace.path()).await;
let response = build_router(api) let response = build_inner_router(api)
.oneshot( .oneshot(
Request::builder() Request::builder()
.method("POST") .method("POST")
@@ -18486,7 +19044,7 @@ mod tests {
} }
async fn test_app(workspace_root: impl Into<PathBuf>) -> Router { async fn test_app(workspace_root: impl Into<PathBuf>) -> Router {
build_router(test_api(workspace_root).await) build_inner_router(test_api(workspace_root).await)
} }
fn test_profile_archive() -> worker_runtime::profile_archive::ProfileSourceArchive { fn test_profile_archive() -> worker_runtime::profile_archive::ProfileSourceArchive {
@@ -18548,25 +19106,21 @@ mod tests {
async fn internal_resource_fetch_rest_returns_typed_missing_resource() { async fn internal_resource_fetch_rest_returns_typed_missing_resource() {
let workspace = tempfile::tempdir().unwrap(); let workspace = tempfile::tempdir().unwrap();
init_clean_git_workspace(workspace.path()); init_clean_git_workspace(workspace.path());
let app = test_app(workspace.path()).await; let mut api = test_api(workspace.path()).await;
let identity =
worker_runtime::auth::RuntimeIdentityMaterial::generate("runtime-test").unwrap();
configure_runtime_request_auth(&mut api, &identity, "runtime-test");
let app = build_inner_router(api.clone());
let handle = missing_resource_handle(); let handle = missing_resource_handle();
let response = app let body = serde_json::to_vec(&worker_runtime::resource::BackendResourceFetchRequest {
.oneshot(
Request::post(format!(
"/internal/w/{TEST_WORKSPACE_ID}/runtime/resources/fetch"
))
.header("content-type", "application/json")
.body(Body::from(
serde_json::to_vec(&worker_runtime::resource::BackendResourceFetchRequest {
audit_correlation_id: handle.audit_correlation_id.clone(), audit_correlation_id: handle.audit_correlation_id.clone(),
runtime_id: "runtime-test".to_string(), runtime_id: "runtime-test".to_string(),
worker_id: None, worker_id: None,
handle, handle,
}) })
.unwrap(), .unwrap();
)) let response = app
.unwrap(), .oneshot(runtime_resource_fetch_request(&api, &identity, body))
)
.await .await
.unwrap(); .unwrap();
assert_eq!(response.status(), StatusCode::NOT_FOUND); assert_eq!(response.status(), StatusCode::NOT_FOUND);
@@ -18583,7 +19137,10 @@ mod tests {
async fn remote_http_resource_fetch_uses_backend_resource_contract() { async fn remote_http_resource_fetch_uses_backend_resource_contract() {
let workspace = tempfile::tempdir().unwrap(); let workspace = tempfile::tempdir().unwrap();
init_clean_git_workspace(workspace.path()); init_clean_git_workspace(workspace.path());
let api = test_api(workspace.path()).await; let mut api = test_api(workspace.path()).await;
let identity =
worker_runtime::auth::RuntimeIdentityMaterial::generate("runtime-test").unwrap();
configure_runtime_request_auth(&mut api, &identity, "runtime-test");
let broker = api.resource_broker.clone(); let broker = api.resource_broker.clone();
let archive = test_profile_archive(); let archive = test_profile_archive();
let runtime_id = "runtime-test"; let runtime_id = "runtime-test";
@@ -18592,14 +19149,15 @@ mod tests {
crate::resource_broker::BackendResourceTarget::Runtime(runtime_id), crate::resource_broker::BackendResourceTarget::Runtime(runtime_id),
archive, archive,
); );
let app = build_router(api); let app = build_inner_router(api);
let listener = tokio::net::TcpListener::bind("127.0.0.1:0").await.unwrap(); let listener = tokio::net::TcpListener::bind("127.0.0.1:0").await.unwrap();
let addr = listener.local_addr().unwrap(); let addr = listener.local_addr().unwrap();
let server = tokio::spawn(async move { axum::serve(listener, app).await.unwrap() }); let server = tokio::spawn(async move { axum::serve(listener, app).await.unwrap() });
let client = worker_runtime::resource::HttpBackendResourceClient::new( let client = worker_runtime::resource::HttpBackendResourceClient::new(
format!("http://{addr}/internal/w/{TEST_WORKSPACE_ID}/runtime/resources/fetch"), format!("http://{addr}/api/runtime/v1/workspaces/{TEST_WORKSPACE_ID}/resources/fetch"),
None, None,
); )
.with_runtime_request_source(&identity, "server-test");
let response = client let response = client
.fetch_resource(worker_runtime::resource::BackendResourceFetchRequest { .fetch_resource(worker_runtime::resource::BackendResourceFetchRequest {
@@ -19049,7 +19607,7 @@ mod tests {
#[tokio::test] #[tokio::test]
async fn merge_request_reads_use_first_class_workspace_resources() { async fn merge_request_reads_use_first_class_workspace_resources() {
let dir = tempfile::tempdir().unwrap(); let dir = tempfile::tempdir().unwrap();
let app = build_router(test_api(dir.path()).await); let app = build_inner_router(test_api(dir.path()).await);
let collection = app let collection = app
.clone() .clone()
@@ -19112,7 +19670,7 @@ mod tests {
{ {
let dir = tempfile::tempdir().unwrap(); let dir = tempfile::tempdir().unwrap();
let api = test_api(dir.path()).await; let api = test_api(dir.path()).await;
let app = build_router(api); let app = build_inner_router(api);
let response = app let response = app
.clone() .clone()
@@ -19528,7 +20086,7 @@ mod tests {
) )
.await .await
.unwrap(); .unwrap();
let app = build_router(api); let app = build_inner_router(api);
let workspace = get_json(app.clone(), "/api/workspace").await; let workspace = get_json(app.clone(), "/api/workspace").await;
assert_eq!(workspace["workspace_id"], TEST_WORKSPACE_ID); assert_eq!(workspace["workspace_id"], TEST_WORKSPACE_ID);
@@ -19930,7 +20488,7 @@ mod tests {
) )
.await .await
.unwrap(); .unwrap();
let app = build_router(api); let app = build_inner_router(api);
let workspace = get_json(app.clone(), "/api/workspace").await; let workspace = get_json(app.clone(), "/api/workspace").await;
let workspace_companion = &workspace["extension_points"]["companion_console"]; let workspace_companion = &workspace["extension_points"]["companion_console"];
@@ -20119,7 +20677,7 @@ mod tests {
.with_embedded_runtime_store_root(default_root.clone()); .with_embedded_runtime_store_root(default_root.clone());
config.database_path = ServerConfig::server_database_path_for_data_dir(&data_dir); config.database_path = ServerConfig::server_database_path_for_data_dir(&data_dir);
let store = test_control_store(&config); let store = test_control_store(&config);
let app = build_router( let app = build_inner_router(
WorkspaceApi::new_with_execution_backend( WorkspaceApi::new_with_execution_backend(
config, config,
Arc::new(store), Arc::new(store),
@@ -20157,7 +20715,7 @@ mod tests {
) )
.await .await
.unwrap(); .unwrap();
let app = build_router(api); let app = build_inner_router(api);
let repositories = get_json(app, "/api/repositories").await; let repositories = get_json(app, "/api/repositories").await;
@@ -20188,7 +20746,7 @@ mod tests {
) )
.await .await
.unwrap(); .unwrap();
let app = build_router(api); let app = build_inner_router(api);
let unknown = request_json( let unknown = request_json(
app.clone(), app.clone(),
@@ -20229,7 +20787,7 @@ mod tests {
) )
.await .await
.unwrap(); .unwrap();
let app = build_router(api); let app = build_inner_router(api);
let runtimes = get_json(app.clone(), "/api/runtimes").await; let runtimes = get_json(app.clone(), "/api/runtimes").await;
let embedded_summary = runtimes["items"] let embedded_summary = runtimes["items"]
@@ -20497,7 +21055,11 @@ mod tests {
.unwrap(); .unwrap();
let app_listener = tokio::net::TcpListener::bind("127.0.0.1:0").await.unwrap(); let app_listener = tokio::net::TcpListener::bind("127.0.0.1:0").await.unwrap();
let app_addr = app_listener.local_addr().unwrap(); let app_addr = app_listener.local_addr().unwrap();
tokio::spawn(async move { axum::serve(app_listener, build_router(api)).await.unwrap() }); tokio::spawn(async move {
axum::serve(app_listener, build_inner_router(api))
.await
.unwrap()
});
( (
format!("ws://{app_addr}/api/runtimes/{runtime_id}/workers/{worker_id}/protocol/ws"), format!("ws://{app_addr}/api/runtimes/{runtime_id}/workers/{worker_id}/protocol/ws"),
dir, dir,
@@ -20505,11 +21067,11 @@ mod tests {
} }
#[tokio::test] #[tokio::test]
async fn workspace_subscription_uses_legacy_scoped_access_without_browser_session() { async fn workspace_subscription_inner_router_projects_snapshot() {
let dir = tempfile::tempdir().unwrap(); let dir = tempfile::tempdir().unwrap();
let listener = tokio::net::TcpListener::bind("127.0.0.1:0").await.unwrap(); let listener = tokio::net::TcpListener::bind("127.0.0.1:0").await.unwrap();
let address = listener.local_addr().unwrap(); let address = listener.local_addr().unwrap();
let app = build_router(test_api(dir.path()).await); let app = build_inner_router(test_api(dir.path()).await);
let server = tokio::spawn(async move { let server = tokio::spawn(async move {
let _ = axum::serve(listener, app).await; let _ = axum::serve(listener, app).await;
}); });
@@ -20557,7 +21119,7 @@ mod tests {
let listener = tokio::net::TcpListener::bind("127.0.0.1:0").await.unwrap(); let listener = tokio::net::TcpListener::bind("127.0.0.1:0").await.unwrap();
let address = listener.local_addr().unwrap(); let address = listener.local_addr().unwrap();
let app = build_router(api); let app = build_inner_router(api);
let server = tokio::spawn(async move { let server = tokio::spawn(async move {
let _ = axum::serve(listener, app).await; let _ = axum::serve(listener, app).await;
}); });
@@ -20954,7 +21516,7 @@ VALUES ('0192f0e8-4d84-7d6e-a000-000000000001', 'ticket', 3);
) )
.await .await
.unwrap(); .unwrap();
let app = build_router(api); let app = build_inner_router(api);
let objectives_path = format!("/api/w/{TEST_WORKSPACE_ID}/objectives"); let objectives_path = format!("/api/w/{TEST_WORKSPACE_ID}/objectives");
let created = request_json( let created = request_json(
@@ -21096,6 +21658,22 @@ VALUES ('0192f0e8-4d84-7d6e-a000-000000000001', 'ticket', 3);
); );
} }
async fn get_json_authenticated(app: Router, uri: &str, token: &str) -> Value {
let response = app
.oneshot(
Request::builder()
.uri(uri)
.header(axum::http::header::AUTHORIZATION, format!("Bearer {token}"))
.body(Body::empty())
.unwrap(),
)
.await
.unwrap();
assert_eq!(response.status(), StatusCode::OK, "{uri}");
let bytes = to_bytes(response.into_body(), usize::MAX).await.unwrap();
serde_json::from_slice(&bytes).unwrap()
}
async fn get_json(app: Router, uri: &str) -> Value { async fn get_json(app: Router, uri: &str) -> Value {
let response = app let response = app
.oneshot(Request::builder().uri(uri).body(Body::empty()).unwrap()) .oneshot(Request::builder().uri(uri).body(Body::empty()).unwrap())
+5
View File
@@ -730,6 +730,7 @@ pub trait ControlPlaneStore: Send + Sync {
record: &WorkspaceBootstrapRecord, record: &WorkspaceBootstrapRecord,
) -> Result<WorkspaceBootstrapResult>; ) -> Result<WorkspaceBootstrapResult>;
async fn get_trusted_runtime(&self, runtime_id: &str) -> Result<Option<TrustedRuntimeRecord>>; async fn get_trusted_runtime(&self, runtime_id: &str) -> Result<Option<TrustedRuntimeRecord>>;
async fn upsert_trusted_runtime_record(&self, record: &TrustedRuntimeRecord) -> Result<()>;
async fn consume_worker_mutation_source_jti( async fn consume_worker_mutation_source_jti(
&self, &self,
runtime_id: &str, runtime_id: &str,
@@ -1937,6 +1938,10 @@ impl ControlPlaneStore for SqliteWorkspaceStore {
}) })
} }
async fn upsert_trusted_runtime_record(&self, record: &TrustedRuntimeRecord) -> Result<()> {
SqliteWorkspaceStore::upsert_trusted_runtime(self, record)
}
async fn consume_worker_mutation_source_jti( async fn consume_worker_mutation_source_jti(
&self, &self,
runtime_id: &str, runtime_id: &str,
+111 -8
View File
@@ -3,14 +3,113 @@ use std::time::{SystemTime, UNIX_EPOCH};
use axum::http::HeaderMap; use axum::http::HeaderMap;
use worker_runtime::auth::{ use worker_runtime::auth::{
WorkerMutationActorKind, WorkerMutationOperation, WorkerMutationSourceClaims, RuntimeRequestSourceExpectation, WorkerMutationActorKind, WorkerMutationOperation,
WorkerMutationSourceExpectation, decode_worker_mutation_source_claims, WorkerMutationSourceClaims, WorkerMutationSourceExpectation,
verify_worker_mutation_source_proof, decode_runtime_request_source_claims, decode_worker_mutation_source_claims,
verify_runtime_request_source, verify_worker_mutation_source_proof,
}; };
use worker_runtime::worker_source::InProcessWorkerMutationProof; use worker_runtime::worker_source::InProcessWorkerMutationProof;
use crate::hosts::RemoteRuntimeConfig; use crate::hosts::RemoteRuntimeConfig;
use crate::server::WorkspaceApi; use crate::server::{ServerConfig, WorkspaceApi};
use crate::store::ControlPlaneStore;
#[derive(Clone, Debug, PartialEq, Eq)]
pub struct VerifiedRuntimeRequestSource {
pub runtime_id: String,
pub worker_id: Option<String>,
}
pub async fn verify_runtime_request_source_proof(
api: &WorkspaceApi,
proof: &str,
workspace_id: &str,
permission: &str,
method: &str,
path: &str,
body_digest: &str,
) -> Result<VerifiedRuntimeRequestSource, WorkerMutationSourceProofError> {
verify_runtime_request_source_proof_with_store(
api.store.as_ref(),
&api.config,
proof,
workspace_id,
permission,
method,
path,
body_digest,
)
.await
}
#[allow(clippy::too_many_arguments)]
pub async fn verify_runtime_request_source_proof_with_store(
store: &dyn ControlPlaneStore,
config: &ServerConfig,
proof: &str,
workspace_id: &str,
permission: &str,
method: &str,
path: &str,
body_digest: &str,
) -> Result<VerifiedRuntimeRequestSource, WorkerMutationSourceProofError> {
let unverified = decode_runtime_request_source_claims(proof)
.map_err(|_| WorkerMutationSourceProofError::Invalid)?;
let audience = remote_audience(config, &unverified.iss, workspace_id)?;
let trusted = store
.get_trusted_runtime(&unverified.iss)
.await
.map_err(|error| WorkerMutationSourceProofError::Authority(error.to_string()))?
.filter(|record| record.revoked_at.is_none())
.ok_or(WorkerMutationSourceProofError::RevokedRuntimeTrust)?;
let expected = RuntimeRequestSourceExpectation {
identity_id: &unverified.iss,
audience: audience.as_ref(),
workspace_id,
worker_id: unverified.worker_id.as_deref(),
permission,
method,
path,
body_digest,
now_unix: i64::try_from(unix_now_seconds()).unwrap_or(i64::MAX),
};
let claims = verify_runtime_request_source(proof, &trusted.public_key, &expected)
.map_err(map_auth_error)?;
let now_seconds = u64::try_from(expected.now_unix).unwrap_or(u64::MAX);
let expires_at = u64::try_from(claims.exp).unwrap_or(0);
let consumed_at = chrono::DateTime::from_timestamp(expected.now_unix, 0)
.ok_or(WorkerMutationSourceProofError::Expired)?
.to_rfc3339();
if !store
.consume_worker_mutation_source_jti(
&claims.iss,
&claims.jti,
expires_at,
now_seconds,
&consumed_at,
)
.await
.map_err(|error| WorkerMutationSourceProofError::Authority(error.to_string()))?
{
return Err(WorkerMutationSourceProofError::Replay);
}
if let Some(worker_id) = claims.worker_id.as_deref() {
let worker = worker_runtime::identity::RuntimeWorkerRef {
runtime_id: claims.iss.clone(),
worker_id: worker_id.to_owned(),
};
let member = store
.get_worker_registry(workspace_id, &worker)
.map_err(|error| WorkerMutationSourceProofError::Authority(error.to_string()))?;
if member.is_none() {
return Err(WorkerMutationSourceProofError::WorkerCatalogMembership);
}
}
Ok(VerifiedRuntimeRequestSource {
runtime_id: claims.iss,
worker_id: claims.worker_id,
})
}
#[derive(Clone, Debug, PartialEq, Eq)] #[derive(Clone, Debug, PartialEq, Eq)]
pub enum PresentedWorkerMutationSourceProof<'a> { pub enum PresentedWorkerMutationSourceProof<'a> {
@@ -97,7 +196,7 @@ async fn verify_worker_remove_source_with(
PresentedWorkerMutationSourceProof::Remote(token) => { PresentedWorkerMutationSourceProof::Remote(token) => {
let unverified = decode_worker_mutation_source_claims(token) let unverified = decode_worker_mutation_source_claims(token)
.map_err(|_| WorkerMutationSourceProofError::Invalid)?; .map_err(|_| WorkerMutationSourceProofError::Invalid)?;
let audience = remote_audience(config, &unverified.iss)?; let audience = remote_audience(config, &unverified.iss, &config.workspace_id)?;
let trusted = store let trusted = store
.get_trusted_runtime(&unverified.iss) .get_trusted_runtime(&unverified.iss)
.await .await
@@ -106,7 +205,7 @@ async fn verify_worker_remove_source_with(
.ok_or(WorkerMutationSourceProofError::RevokedRuntimeTrust)?; .ok_or(WorkerMutationSourceProofError::RevokedRuntimeTrust)?;
let expected = WorkerMutationSourceExpectation { let expected = WorkerMutationSourceExpectation {
runtime_id: &unverified.iss, runtime_id: &unverified.iss,
audience, audience: audience.as_ref(),
workspace_id: &config.workspace_id, workspace_id: &config.workspace_id,
worker_id: None, worker_id: None,
actor_kind: WorkerMutationActorKind::Worker, actor_kind: WorkerMutationActorKind::Worker,
@@ -247,13 +346,17 @@ impl worker_runtime::worker_source::EmbeddedWorkerMutationDispatcher
fn remote_audience<'a>( fn remote_audience<'a>(
config: &'a crate::server::ServerConfig, config: &'a crate::server::ServerConfig,
runtime_id: &str, runtime_id: &str,
) -> Result<&'a str, WorkerMutationSourceProofError> { workspace_id: &str,
) -> Result<std::borrow::Cow<'a, str>, WorkerMutationSourceProofError> {
if runtime_id == crate::hosts::EMBEDDED_RUNTIME_ID {
return Ok(std::borrow::Cow::Owned(format!("embedded:{workspace_id}")));
}
config config
.remote_runtime_sources .remote_runtime_sources
.iter() .iter()
.find(|runtime| runtime.runtime_id == runtime_id) .find(|runtime| runtime.runtime_id == runtime_id)
.and_then(|runtime: &RemoteRuntimeConfig| runtime.auth.as_ref()) .and_then(|runtime: &RemoteRuntimeConfig| runtime.auth.as_ref())
.map(|auth| auth.server_id.as_str()) .map(|auth| std::borrow::Cow::Borrowed(auth.server_id.as_str()))
.ok_or(WorkerMutationSourceProofError::RevokedRuntimeTrust) .ok_or(WorkerMutationSourceProofError::RevokedRuntimeTrust)
} }