Hare/yoi
1
1
Fork 0
Code Actions Packages Releases Activity

fix: reject duplicate backend selectors

Browse Source
This commit is contained in:
Hare
2026-08-30 21:57:50 +09:00
parent dfc48f7a05
commit 583c343d08
1 changed files with 41 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
crates/yoi/src/main.rs
+41
View File
@@ -270,6 +270,11 @@ fn parse_top_level_target_selection(
i += 1;
}
"--backend" => {
if selection.backend_url.is_some() {
return Err(ParseError(
"--backend must not be provided more than once".to_string(),
));
}
if selection.explicit_local {
return Err(ParseError(
"--local and --backend are mutually exclusive".to_string(),
@@ -295,6 +300,11 @@ fn parse_top_level_target_selection(
i += 2;
}
arg if arg.starts_with("--backend=") => {
if selection.backend_url.is_some() {
return Err(ParseError(
"--backend must not be provided more than once".to_string(),
));
}
if selection.explicit_local {
return Err(ParseError(
"--local and --backend are mutually exclusive".to_string(),
@@ -1289,6 +1299,11 @@ fn parse_login_args<R: CliConnectionResolver + ?Sized>(
while i < args.len() {
match args[i].as_str() {
"--backend" => {
if backend_url.is_some() {
return Err(ParseError(
"--backend must not be provided more than once".to_string(),
));
}
let value = args
.get(i + 1)
.ok_or_else(|| ParseError("--backend requires a URL".to_string()))?;
@@ -1299,6 +1314,11 @@ fn parse_login_args<R: CliConnectionResolver + ?Sized>(
i += 2;
}
arg if arg.starts_with("--backend=") => {
if backend_url.is_some() {
return Err(ParseError(
"--backend must not be provided more than once".to_string(),
));
}
let value = arg.trim_start_matches("--backend=");
if value.is_empty() {
return Err(ParseError("--backend requires a URL".to_string()));
@@ -2046,6 +2066,27 @@ backend = "shared"
}
}
#[test]
fn parse_login_rejects_repeated_backend_selectors_in_each_scope() {
for args in [
vec![
"--backend",
"http://127.0.0.1:8787",
"--backend=http://127.0.0.1:8788",
"login",
],
vec![
"login",
"--backend",
"http://127.0.0.1:8787",
"--backend=http://127.0.0.1:8788",
],
] {
let error = parse_args_from(args).unwrap_err().to_string();
assert!(error.contains("must not be provided more than once"));
}
}
#[test]
fn parse_login_rejects_non_backend_or_duplicate_target_selectors() {
assert!(