ticket: close planning workflow-state replacement

.yoi/tickets/closed/20260607-225448-replace-intake-state-with-planning/item.md

@@ -2,13 +2,13 @@
 id: 20260607-225448-replace-intake-state-with-planning
 slug: replace-intake-state-with-planning
 title: Replace Ticket intake state with planning state
-status: open
+status: 'closed'
 kind: task
 priority: P1
 labels: [ticket, workflow-state, orchestrator, panel, intake, planning]
-workflow_state: 'inprogress'
+workflow_state: 'done'
 created_at: 2026-06-07T22:54:48Z
-updated_at: '2026-06-08T09:17:24Z'
+updated_at: '2026-06-08T09:19:17Z'
 assignee: null
 legacy_ticket: null
 queued_by: 'workspace-panel'

.yoi/tickets/closed/20260607-225448-replace-intake-state-with-planning/resolution.md

@@ -0,0 +1,38 @@
+Merged and completed the workflow-state planning replacement.
+
+Summary:
+- Replaced user-facing/model-output `TicketWorkflowState::Intake` with `Planning`.
+- Legacy `workflow_state: intake` parses compatibly as `planning`; emitted/default state is `planning`.
+- Updated transition graph to `planning -> ready -> queued -> inprogress -> done`.
+- Added audited return-to-planning transitions from `ready` and `queued` with reason/body through typed state-change events.
+- Preserved Intake role/profile/persona/tool names where they refer to role identity, e.g. `TicketIntakeReady`.
+- Removed new `needs_preflight` tool input exposure; legacy metadata remains only for read/compatibility and is no longer a stop gate.
+- Updated Panel labels/actions and planning/clarification/preparation terminology.
+- Reworked active workflows/docs to fold old preflight language into planning/requirements sync. `ticket-preflight-workflow` remains only as compatibility slug with planning/requirements-sync content.
+
+Merged branch/worktree:
+- Branch: `replace-intake-state-with-planning`
+- Commits: `ada6db9`, `eddb33c`
+- Merge commit on `develop`: `64466f2 merge: replace intake state with planning`
+
+Validation passed after merge:
+- `cargo fmt --check`
+- `git diff --check`
+- `cargo test -p ticket --lib`
+- `cargo test -p ticket workflow_state --lib`
+- `cargo test -p ticket ticket_workflow_tool --lib`
+- `cargo test -p ticket ticket_intake_ready_tool --lib`
+- `cargo test -p tui workspace_panel --lib`
+- `cargo test -p yoi ticket_cli`
+- `cargo check --workspace`
+- `cargo run -q -p yoi -- ticket doctor`
+- `nix build .#yoi`
+
+Cleanup completed:
+- Stopped coder/reviewer Pods and reclaimed scope.
+- Removed `.worktree/replace-intake-state-with-planning`.
+- Deleted branch `replace-intake-state-with-planning`.
+
+Residual notes:
+- Historical `.yoi/tickets/**` records still contain old `Preflight`, `preflight_needed`, and `needs_preflight` text as durable audit/history artifacts; they were intentionally not rewritten.
+- `ticket-preflight-workflow` filename remains as a compatibility slug, but its content now explicitly describes planning/requirements sync rather than a separate workflow state/lane/long-lived operation.

.yoi/tickets/closed/20260607-225448-replace-intake-state-with-planning/thread.md

@@ -395,3 +395,73 @@ Parent/human decision needs:
 - User has authorized merge-completion and cleanup after approved work. Proceeding to merge-completion unless post-merge validation fails.
 
 ---
+
+<!-- event: review author: orchestrator at: 2026-06-08T09:19:00Z status: approve -->
+
+## Review: approve
+
+Final merge-completion approval after merge to `develop` and post-merge validation.
+
+Evidence:
+- Merged branch `replace-intake-state-with-planning` with `--no-ff`.
+- Reviewer `reviewer-replace-intake-planning` approved after fix-loop.
+- Post-merge validation passed: `cargo fmt --check`, `git diff --check`, `cargo test -p ticket --lib`, `cargo test -p ticket workflow_state --lib`, `cargo test -p ticket ticket_workflow_tool --lib`, `cargo test -p ticket ticket_intake_ready_tool --lib`, `cargo test -p tui workspace_panel --lib`, `cargo test -p yoi ticket_cli`, `cargo check --workspace`, `cargo run -q -p yoi -- ticket doctor`, and `nix build .#yoi`.
+- Coder/reviewer Pods stopped and delegated scope reclaimed.
+- Merged worktree removed and branch deleted.
+
+This approval is for the merged main-branch result, not merely the branch-local reviewer verdict.
+
+---
+
+<!-- event: state_changed author: orchestrator at: 2026-06-08T09:19:00Z from: inprogress to: done reason: merged_and_validated field: workflow_state -->
+
+## State changed
+
+Merged to `develop`, post-merge validation passed, final merge-completion approval recorded, and planning-state branch/worktree/Pods cleaned up.
+
+---
+
+<!-- event: close author: hare at: 2026-06-08T09:19:17Z status: closed -->
+
+## Closed
+
+Merged and completed the workflow-state planning replacement.
+
+Summary:
+- Replaced user-facing/model-output `TicketWorkflowState::Intake` with `Planning`.
+- Legacy `workflow_state: intake` parses compatibly as `planning`; emitted/default state is `planning`.
+- Updated transition graph to `planning -> ready -> queued -> inprogress -> done`.
+- Added audited return-to-planning transitions from `ready` and `queued` with reason/body through typed state-change events.
+- Preserved Intake role/profile/persona/tool names where they refer to role identity, e.g. `TicketIntakeReady`.
+- Removed new `needs_preflight` tool input exposure; legacy metadata remains only for read/compatibility and is no longer a stop gate.
+- Updated Panel labels/actions and planning/clarification/preparation terminology.
+- Reworked active workflows/docs to fold old preflight language into planning/requirements sync. `ticket-preflight-workflow` remains only as compatibility slug with planning/requirements-sync content.
+
+Merged branch/worktree:
+- Branch: `replace-intake-state-with-planning`
+- Commits: `ada6db9`, `eddb33c`
+- Merge commit on `develop`: `64466f2 merge: replace intake state with planning`
+
+Validation passed after merge:
+- `cargo fmt --check`
+- `git diff --check`
+- `cargo test -p ticket --lib`
+- `cargo test -p ticket workflow_state --lib`
+- `cargo test -p ticket ticket_workflow_tool --lib`
+- `cargo test -p ticket ticket_intake_ready_tool --lib`
+- `cargo test -p tui workspace_panel --lib`
+- `cargo test -p yoi ticket_cli`
+- `cargo check --workspace`
+- `cargo run -q -p yoi -- ticket doctor`
+- `nix build .#yoi`
+
+Cleanup completed:
+- Stopped coder/reviewer Pods and reclaimed scope.
+- Removed `.worktree/replace-intake-state-with-planning`.
+- Deleted branch `replace-intake-state-with-planning`.
+
+Residual notes:
+- Historical `.yoi/tickets/**` records still contain old `Preflight`, `preflight_needed`, and `needs_preflight` text as durable audit/history artifacts; they were intentionally not rewritten.
+- `ticket-preflight-workflow` filename remains as a compatibility slug, but its content now explicitly describes planning/requirements sync rather than a separate workflow state/lane/long-lived operation.
+
+---