From 638bd7bcd60b42b61ded8113800a4f2a4e5a67b6 Mon Sep 17 00:00:00 2001 From: Hare Date: Fri, 26 Jun 2026 00:46:49 +0900 Subject: [PATCH] ticket: request worker rename guidance fixes --- .yoi/tickets/00001KVZG9BMS/item.md | 2 +- .yoi/tickets/00001KVZG9BMS/thread.md | 44 ++++++++++++++++++++++++++++ 2 files changed, 45 insertions(+), 1 deletion(-) diff --git a/.yoi/tickets/00001KVZG9BMS/item.md b/.yoi/tickets/00001KVZG9BMS/item.md index 92802185..02490511 100644 --- a/.yoi/tickets/00001KVZG9BMS/item.md +++ b/.yoi/tickets/00001KVZG9BMS/item.md @@ -2,7 +2,7 @@ title: 'pod crateをworker crateへ改名する' state: 'inprogress' created_at: '2026-06-25T13:42:37Z' -updated_at: '2026-06-25T15:44:18Z' +updated_at: '2026-06-25T15:46:40Z' assignee: null queued_by: 'workspace-panel' queued_at: '2026-06-25T14:13:35Z' diff --git a/.yoi/tickets/00001KVZG9BMS/thread.md b/.yoi/tickets/00001KVZG9BMS/thread.md index f74b55ed..1219f646 100644 --- a/.yoi/tickets/00001KVZG9BMS/thread.md +++ b/.yoi/tickets/00001KVZG9BMS/thread.md @@ -411,3 +411,47 @@ Residual risks / notes: - child worktree は commit 後 clean。 --- + + + +## Review: request changes + +Review result: request_changes + +読取専用で `94c7aa79` を確認した。前回指摘分のうち、以下は解消済み。 + +- `crates/pod-registry/README.md` の `worker-session-state.md` link 更新。 +- `crates/protocol/src/lib.rs` の `List Workers...` comment 更新。 +- `AGENTS.md` / `docs/development/work-items.md:250` の前回 exact blocker 更新。 +- `SendToPeerPod` は `LEGACY_SEND_TO_PEER_POD_TOOL` として analytics-only legacy comment 付きで残り、現行 `SendToPeerWorker` 分類も追加済みなので、この残存は許容可能。 + +Remaining blockers: + +1. active E2E helper に旧 `--pod` CLI が残存。 + - `tests/e2e/src/lib.rs:1541` + - `config.command_args` がまだ `"--pod"` を渡している。 + - `yoi pod` / `--pod` alias を作らない方針なので、これは現行 CLI に対して壊れた active test/helper。`--worker` へ更新が必要。 + +2. active user-facing / developer-facing guidance に旧 Pod terminology が残存。 + 代表例: + - `crates/tui/src/dashboard/mod.rs:96` — `"no Tickets or Pods found ..."` + - `crates/tui/src/dashboard/mod.rs:2939` — `"spawning role Pods"` + - `crates/tui/src/dashboard/mod.rs:4951` — `"sibling coder/reviewer Pods"` + - `crates/tui/src/dashboard/tests.rs:837` — 旧文字列期待 + - `crates/client/README.md:5` — “talking to Pods” + - `crates/manifest/src/config.rs:43` — “spawned child Pods” + - `docs/design/overview.md:14` — “between clients and Pods” + - `docs/development/workflows.md` / `docs/development/dogfooding.md` / `docs/development/work-items.md` にも current guidance としての `Pods` が残存。 + +これらは `pod-store` / `pod-registry` crate 名や on-disk `pods` compatibility の説明ではなく、現在の実行単位・CLI・Dashboard guidance なので Worker terminology に寄せるべき。 + +Required verification after fixes: +```sh +rg -n -S --glob '!target' --glob '!docs/report/**' -- '--pod|yoi pod' . +rg -n -S --glob '!target' --glob '!docs/report/**' \ + 'sibling coder/reviewer Pods|role Pods|talking to Pods|between clients and Pods|Spawned Pods|child Pods|Pods found|Pod categories|Pod row' \ + crates docs tests resources AGENTS.md README.md KNOWN_ISSUES.md +``` +These should be empty or any remaining hit must be explicitly legacy/internal and justified. + +---