From 66b3a38f7d415947333919f84235080d101217c5 Mon Sep 17 00:00:00 2001 From: Hare Date: Thu, 16 Jul 2026 06:39:31 +0900 Subject: [PATCH] ticket: close workflow removal work --- .yoi/tickets/00001KXKJGYGD/item.md | 4 +- .yoi/tickets/00001KXKJGYGD/resolution.md | 41 +++++++++ .yoi/tickets/00001KXKJGYGD/thread.md | 108 +++++++++++++++++++++++ 3 files changed, 151 insertions(+), 2 deletions(-) create mode 100644 .yoi/tickets/00001KXKJGYGD/resolution.md diff --git a/.yoi/tickets/00001KXKJGYGD/item.md b/.yoi/tickets/00001KXKJGYGD/item.md index a21d15d7..b2e4069b 100644 --- a/.yoi/tickets/00001KXKJGYGD/item.md +++ b/.yoi/tickets/00001KXKJGYGD/item.md @@ -1,8 +1,8 @@ --- title: 'Remove workflow tracking and workflow resources' -state: 'inprogress' +state: 'closed' created_at: '2026-07-15T19:02:13Z' -updated_at: '2026-07-15T21:35:26Z' +updated_at: '2026-07-15T21:39:23Z' assignee: null queued_by: 'workspace-panel' queued_at: '2026-07-15T19:54:36Z' diff --git a/.yoi/tickets/00001KXKJGYGD/resolution.md b/.yoi/tickets/00001KXKJGYGD/resolution.md new file mode 100644 index 00000000..1c6016ce --- /dev/null +++ b/.yoi/tickets/00001KXKJGYGD/resolution.md @@ -0,0 +1,41 @@ +Workflow tracking / Workflow resource / Workflow invocation machinery を削除・レビュー・merge・検証した。 + +実装内容: +- model-visible `ActiveWorkflowList`, `ActiveWorkflowComplete`, `ActiveWorkflowCancel` tools を削除。 +- Worker active-workflow durable state、extension snapshotting、compaction/rehydration handling、prompt re-injection paths を削除。 +- Workflow registry/resource loading と `/workflow-slug` invocation behavior を削除。 +- `crates/workflow` crate と tracked `resources/workflows/*` resources を削除。 +- `WorkflowInvoke` を protocol / TUI / web generated protocol surfaces から削除。 +- slash workflow completion behavior と related web console completion surface を削除。 +- `.yoi/workflow` memory/workspace authority と workflow usage-source handling を削除。 +- resident workflow / workflow invocation wording を prompts/docs/config から削除。 +- old persisted `kind: "workflow"` `SystemItem`s は `LegacyIgnored` として bounded diagnostic/ignore behavior のみにした。 +- first-class Skills support はこの Ticket では実装していない。 + +Review: +- 初回 review は web/generated `workflow_invoke` surface、stale workflow role/test、docs wording で `request_changes`。 +- 2回目 review は slash workflow completion path で `request_changes`。 +- 3回目 review は TUI test fixture が legacy workflow SystemItem を active snapshot carrier として使っている blocker で `request_changes`。 +- `bc48094d fix: update workflow-free tui tests` 後の focused re-review は `approve`。 + +Merge / validation: +- Merge commit: `2f260029 merge: remove workflow machinery`。 +- Final validation passed: + - `rg "ActiveWorkflow|active_workflow|Active workflow" . || true` + - `rg "resources/workflows|\\.yoi/workflow|workflow invocation|Resident workflows|workflow_invoke" . || true` + - `git diff --check` + - `cargo test -p ticket` + - `cargo test -p session-store --lib --tests` + - `cargo test -p worker --lib --tests` + - `cargo test -p tui --lib --tests` + - `cargo test -p yoi --tests` + - `cd web/workspace && deno task check` + - `cd web/workspace && deno task test` + - `cargo check -p yoi` + - `yoi ticket doctor` + - `nix build .#yoi --no-link` +- Validation log: `/run/user/1000/yoi/yoi-orchestrator/bash-output/workflow-removal-final-validation-1784151359.txt` + +Cleanup: +- Implementation worktree/branch cleanup will be performed after close commit。 +- Per user instruction, `StopPod` is not used。 \ No newline at end of file diff --git a/.yoi/tickets/00001KXKJGYGD/thread.md b/.yoi/tickets/00001KXKJGYGD/thread.md index 015546cf..e5154ffe 100644 --- a/.yoi/tickets/00001KXKJGYGD/thread.md +++ b/.yoi/tickets/00001KXKJGYGD/thread.md @@ -376,3 +376,111 @@ Evidence: Blockers: none。 --- + + + +## Implementation report + +Merge / final validation report: + +- Reviewer approved the implementation after final TUI workflow-free snapshot test fix。 +- Merged branch `work/00001KXKJGYGD-remove-workflow-tracking` into orchestration branch with merge commit `2f260029 merge: remove workflow machinery`。 +- Ticket record conflicts from child branch were resolved in favor of Orchestrator-authoritative Ticket records; implementation code/resource changes were merged。 +- Final validation was rerun in `/home/hare/Projects/yoi/.worktree/orchestration` after merge。 + +Validation passed: +- `rg "ActiveWorkflow|active_workflow|Active workflow" . || true` +- `rg "resources/workflows|\\.yoi/workflow|workflow invocation|Resident workflows|workflow_invoke" . || true` +- `git diff --check` +- `cargo test -p ticket` +- `cargo test -p session-store --lib --tests` +- `cargo test -p worker --lib --tests` +- `cargo test -p tui --lib --tests` +- `cargo test -p yoi --tests` +- `cd web/workspace && deno task check` +- `cd web/workspace && deno task test` +- `cargo check -p yoi` +- `yoi ticket doctor` +- `nix build .#yoi --no-link` + +Validation log: +- `/run/user/1000/yoi/yoi-orchestrator/bash-output/workflow-removal-final-validation-1784151359.txt` + +Reviewed/merged implementation commits: +- `d801b269 refactor: remove workflow machinery` +- `d30dca2d fix: remove remaining workflow invoke surfaces` +- `0b56052a fix: remove workflow completion surface` +- `bc48094d fix: update workflow-free tui tests` + +Notes: +- ActiveWorkflow tools/state and Workflow resource/invocation/completion surfaces were removed。 +- Legacy persisted `kind: "workflow"` SystemItems are bounded to ignored/diagnostic behavior only。 +- Broad first-class Skills support was intentionally not implemented in this Ticket。 +- Per user instruction, no `StopPod` cleanup was performed。 + +--- + + + +## State changed + +Implementation was reviewed, merged into orchestration branch, and final validation passed. Moving to done before closure. + +--- + + + +## State changed + +Ticket を closed にしました。 + + +--- + + + +## 完了 + +Workflow tracking / Workflow resource / Workflow invocation machinery を削除・レビュー・merge・検証した。 + +実装内容: +- model-visible `ActiveWorkflowList`, `ActiveWorkflowComplete`, `ActiveWorkflowCancel` tools を削除。 +- Worker active-workflow durable state、extension snapshotting、compaction/rehydration handling、prompt re-injection paths を削除。 +- Workflow registry/resource loading と `/workflow-slug` invocation behavior を削除。 +- `crates/workflow` crate と tracked `resources/workflows/*` resources を削除。 +- `WorkflowInvoke` を protocol / TUI / web generated protocol surfaces から削除。 +- slash workflow completion behavior と related web console completion surface を削除。 +- `.yoi/workflow` memory/workspace authority と workflow usage-source handling を削除。 +- resident workflow / workflow invocation wording を prompts/docs/config から削除。 +- old persisted `kind: "workflow"` `SystemItem`s は `LegacyIgnored` として bounded diagnostic/ignore behavior のみにした。 +- first-class Skills support はこの Ticket では実装していない。 + +Review: +- 初回 review は web/generated `workflow_invoke` surface、stale workflow role/test、docs wording で `request_changes`。 +- 2回目 review は slash workflow completion path で `request_changes`。 +- 3回目 review は TUI test fixture が legacy workflow SystemItem を active snapshot carrier として使っている blocker で `request_changes`。 +- `bc48094d fix: update workflow-free tui tests` 後の focused re-review は `approve`。 + +Merge / validation: +- Merge commit: `2f260029 merge: remove workflow machinery`。 +- Final validation passed: + - `rg "ActiveWorkflow|active_workflow|Active workflow" . || true` + - `rg "resources/workflows|\\.yoi/workflow|workflow invocation|Resident workflows|workflow_invoke" . || true` + - `git diff --check` + - `cargo test -p ticket` + - `cargo test -p session-store --lib --tests` + - `cargo test -p worker --lib --tests` + - `cargo test -p tui --lib --tests` + - `cargo test -p yoi --tests` + - `cd web/workspace && deno task check` + - `cd web/workspace && deno task test` + - `cargo check -p yoi` + - `yoi ticket doctor` + - `nix build .#yoi --no-link` +- Validation log: `/run/user/1000/yoi/yoi-orchestrator/bash-output/workflow-removal-final-validation-1784151359.txt` + +Cleanup: +- Implementation worktree/branch cleanup will be performed after close commit。 +- Per user instruction, `StopPod` is not used。 + +---