Hare/yoi
1
1
Fork 0
Code Actions Packages Releases Activity

review: approve spawnpod profile tool

Browse Source
This commit is contained in:
Keisuke Hirata 2026-05-30 14:18:48 +09:00
parent 2acc72ca5e
commit 68fda050de
No known key found for this signature in database
2 changed files with 32 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
work-items/open/20260529-205540-spawnpod-profile-tool-description/item.md
View File

@ -7,7 +7,7 @@ kind: feature
priority: P2 priority: P2
labels: [pod, manifest, tools, workflow] labels: [pod, manifest, tools, workflow]
created_at: 2026-05-29T20:55:40Z created_at: 2026-05-29T20:55:40Z
updated_at: 2026-05-30T05:11:43Z updated_at: 2026-05-30T05:18:48Z
assignee: null assignee: null
legacy_ticket: null legacy_ticket: null
--- ---

31
work-items/open/20260529-205540-spawnpod-profile-tool-description/thread.md
View File

@ -96,4 +96,35 @@ Validation note:
- `cargo test -p pod spawn_profile --no-default-features` currently only proves parser behavior, not profile resolution or child config construction. - `cargo test -p pod spawn_profile --no-default-features` currently only proves parser behavior, not profile resolution or child config construction.
---
<!-- event: review author: hare at: 2026-05-30T05:18:48Z status: approve -->
## Review: approve
Approve.
The requested test coverage gaps are satisfied by `b94891e`. The new tests directly cover the previously missing SpawnPod profile/config-building behaviors, and the added seam remains private to the module/test context rather than exposing a new production API.
Coverage verified:
- Omitted/default selector resolves the effective registry default.
- Source-qualified `project:reviewer` role config reaches generated hidden spawn config / child config.
- `inherit` copies reusable parent fields while replacing `pod.name`, `scope.allow`, and `scope.deny`.
- Explicit `instruction` override changes only `worker.instruction` while preserving other selected role fields.
- Invalid / ambiguous / no-default diagnostics include available-selector guidance.
- Profile and inherited scope are replaced by delegated scope and cannot expand child authority.
Remaining blockers: none.
Non-blocking follow-ups:
- Default-selector coverage exercises `SpawnProfileSelector::Default` directly while omitted parse coverage is separate; acceptable.
- Diagnostics parser test manually composes the invalid-selector suffix instead of going through full `execute`; acceptable because production append logic is simple and builder diagnostics are covered directly.
Validation reviewed:
- Coder: `cargo fmt --check`, `cargo test -p manifest profile`, `cargo test -p pod`, `cargo test -p pod --no-default-features` passed.
- Reviewer spot-ran: `cargo test -p pod profile`, `cargo test -p manifest profile`, `cargo test -p pod --no-default-features` passed.
Final verdict: approve.
--- ---