From 69fc3675f02b24f69ee1bc6dd9511f0a451277a2 Mon Sep 17 00:00:00 2001 From: Hare Date: Sun, 14 Jun 2026 15:34:47 +0900 Subject: [PATCH] ticket: complete profile extend removal --- .yoi/tickets/00001KTZY8HK2/item.md | 4 +-- .yoi/tickets/00001KTZY8HK2/thread.md | 43 ++++++++++++++++++++++++++++ 2 files changed, 45 insertions(+), 2 deletions(-) diff --git a/.yoi/tickets/00001KTZY8HK2/item.md b/.yoi/tickets/00001KTZY8HK2/item.md index 17f83f82..eec9a6dd 100644 --- a/.yoi/tickets/00001KTZY8HK2/item.md +++ b/.yoi/tickets/00001KTZY8HK2/item.md @@ -1,8 +1,8 @@ --- title: 'Profile extend API を廃止して import + Lua 代入に寄せる' -state: 'inprogress' +state: 'done' created_at: '2026-06-13T07:31:09Z' -updated_at: '2026-06-14T06:29:17Z' +updated_at: '2026-06-14T06:34:34Z' assignee: null readiness: 'implementation_ready' risk_flags: ['profiles', 'lua-api', 'builtin-resources', 'migration'] diff --git a/.yoi/tickets/00001KTZY8HK2/thread.md b/.yoi/tickets/00001KTZY8HK2/thread.md index 18928a9a..22d92fc3 100644 --- a/.yoi/tickets/00001KTZY8HK2/thread.md +++ b/.yoi/tickets/00001KTZY8HK2/thread.md @@ -136,4 +136,47 @@ Risks / notes: - Existing callers of `yoi.profile.extend` now fail intentionally; this is the requested break. The retained stub is a diagnostic compatibility trap, not a merge API. +--- + + + +## Implementation report + +Integration outcome: merged and validated. + +- Implementation branch: `ticket-00001KTZY8HK2-profile-extend-removal` +- Implementation commit: `7c6070ef profile: remove extend profile composition` +- Review commit: `c12fbd8e ticket: approve profile extend removal` +- Orchestrator merge commit: `58b15ee6 merge: profile extend removal` + +Reviewer result: +- `approve`。`yoi.profile.extend` deep-merge composition is removed, builtin role profiles use `yoi.profile.import("builtin:default")` plus explicit Lua assignment, and no scope/delegation authority semantics were expanded into this Ticket. + +Orchestrator validation after merge: +- `cargo fmt --check`: PASS +- `git diff --check`: PASS +- `cargo test -p manifest profile::tests:: -- --nocapture`: PASS +- `cargo build -p yoi`: first attempt failed due to disk full during Rust metadata output; after stopping/removing profile child Pods/worktree/target, rerun PASS +- `nix build .#yoi`: PASS (result symlink produced) + +Cleanup already performed before rerun validation to free disk: +- stopped `coder-00001KTZY8HK2-profile-extend` and `reviewer-00001KTZY8HK2-profile-extend` +- removed child worktree `/home/hare/Projects/yoi/.worktree/profile-extend-removal` +- deleted branch `ticket-00001KTZY8HK2-profile-extend-removal` + +Residual notes: +- Existing users of `yoi.profile.extend` will now get the intended removed-API diagnostic and must migrate to import + explicit Lua assignment. + +Next: +- Mark Ticket done. Closure remains separate. +- Re-evaluate queued `00001KV11DHGZ` because its profile-surface conflict wait on this Ticket is now resolved. + +--- + + + +## State changed + +Implementation branch was reviewed, approved, merged into the Orchestrator branch as `58b15ee6`, and validated in the Orchestrator worktree. Focused manifest profile tests, formatting, diff check, `cargo build -p yoi`, and `nix build .#yoi` passed after cleanup freed disk space. Ticket implementation work is done; closure remains separate. + ---