flow: require coder work branch commits

crates/flow/src/builtin.rs

@@ -24,7 +24,7 @@ pub fn builtin_flow_source(slug: &str) -> Option<BuiltinFlowSource> {
     match slug {
         CODER_REVIEW_FLOW_SLUG => Some(BuiltinFlowSource {
             slug: CODER_REVIEW_FLOW_SLUG,
-            revision: 1,
+            revision: 2,
             path: "builtin/flows/coder-review.dcdl",
             content: CODER_REVIEW_FLOW_SOURCE,
         }),
@@ -35,7 +35,7 @@ pub fn builtin_flow_source(slug: &str) -> Option<BuiltinFlowSource> {
 pub fn builtin_flow_sources() -> &'static [BuiltinFlowSource] {
     const SOURCES: &[BuiltinFlowSource] = &[BuiltinFlowSource {
         slug: CODER_REVIEW_FLOW_SLUG,
-        revision: 1,
+        revision: 2,
         path: "builtin/flows/coder-review.dcdl",
         content: CODER_REVIEW_FLOW_SOURCE,
     }];
@@ -61,9 +61,32 @@ mod tests {
                 )
             });
             assert_eq!(definition.name, source.slug);
-            assert_eq!(
-                builtin_flow_source(source.slug).map(|item| item.content),
-                Some(source.content)
+            let selected =
+                builtin_flow_source(source.slug).expect("builtin Flow must be selectable");
+            assert_eq!(selected.content, source.content);
+            assert_eq!(selected.revision, source.revision);
+        }
+    }
+
+    #[test]
+    fn coder_review_starts_on_a_ticket_branch_and_requires_committed_review_evidence() {
+        let source =
+            builtin_flow_source(CODER_REVIEW_FLOW_SLUG).expect("coder-review Flow must exist");
+
+        for required in [
+            "detached HEAD",
+            "work/<ticket-id>-<slug>",
+            "explicitly authorized",
+            "git add",
+            "git commit",
+            "Workdir is clean",
+            "current head commit",
+            "same Ticket work branch",
+            "new revision",
+        ] {
+            assert!(
+                source.content.contains(required),
+                "coder-review Flow must preserve branch/commit policy token {required:?}"
             );
         }
     }

crates/worker/src/worker.rs

@@ -6389,7 +6389,10 @@ mod build_summary_prompt_tests {
             .lock()
             .expect("flow runtime state lock") = Some(state.clone());
 
-        assert!(matches!(segments[0], Segment::Text { .. }));
+        assert_eq!(
+            segments[0],
+            Segment::text("Implement the Ticket and request review.")
+        );
         assert_eq!(segments[1], Segment::text("Implement Ticket 00001"));
         assert_eq!(state.instance.definition_revision, 3);
         assert_eq!(state.instance.current_state.as_str(), "implement");

crates/workspace-server/src/server.rs

@@ -10281,7 +10281,7 @@ mod tests {
         assert_eq!(builtin.definition.name, "coder-review");
         assert_eq!(builtin.selector.to_string(), "builtin:coder-review");
         assert_eq!(builtin.flow_id, "builtin:coder-review");
-        assert_eq!(builtin.revision, 1);
+        assert_eq!(builtin.revision, 2);
         assert_eq!(
             api.store
                 .list_flow_sources(&api.config.workspace_id)