From 72d6ac8719befed4dd43b3f939fae1ec09fa5891 Mon Sep 17 00:00:00 2001 From: Hare Date: Sun, 31 May 2026 22:45:04 +0900 Subject: [PATCH] review: approve tui view mode move --- .../item.md | 2 +- .../thread.md | 31 +++++++++++++++++++ 2 files changed, 32 insertions(+), 1 deletion(-) diff --git a/work-items/open/20260531-074258-tui-move-view-mode-state/item.md b/work-items/open/20260531-074258-tui-move-view-mode-state/item.md index bc5b3a3a..8523a95a 100644 --- a/work-items/open/20260531-074258-tui-move-view-mode-state/item.md +++ b/work-items/open/20260531-074258-tui-move-view-mode-state/item.md @@ -7,7 +7,7 @@ kind: task priority: P2 labels: [tui, cleanup] created_at: 2026-05-31T07:42:58Z -updated_at: 2026-05-31T07:42:58Z +updated_at: 2026-05-31T13:45:04Z assignee: null legacy_ticket: null --- diff --git a/work-items/open/20260531-074258-tui-move-view-mode-state/thread.md b/work-items/open/20260531-074258-tui-move-view-mode-state/thread.md index 0a95f1aa..45b3b35f 100644 --- a/work-items/open/20260531-074258-tui-move-view-mode-state/thread.md +++ b/work-items/open/20260531-074258-tui-move-view-mode-state/thread.md @@ -4,4 +4,35 @@ Created by tickets.sh create. +--- + + + +## Review: approve + +External reviewer: `tui-view-mode-reviewer-20260531` +Reviewed implementation commit: `bc31bfa` (`tui: move view mode state`) +Verdict: approve + +Summary: +- Moved the single-Pod history display mode type from `ui.rs` to `view_mode.rs`. +- Kept the type name `Mode` and preserved variants/methods (`Detail`, `Normal`, `Overview`, `cycle()`, `label()`). +- Updated `app.rs`, `ui.rs`, and `tool.rs` to import `crate::view_mode::Mode`. +- Removed the state-model dependency from `app.rs` to the render module for this type. + +Requirements mapping: +- `Mode` now lives in a focused state-oriented module. +- `app.rs -> ui.rs` dependency caused by `Mode` is removed. +- Rendering/key/command behavior is unchanged by inspection because the enum and methods are a straight move. +- No broad `App` privatization, render-tree move, app split, crate/package rename, or unrelated runtime extraction was introduced. +- No active `crate::ui::Mode` / `ui::Mode` references remain under `crates/tui/src`. + +Blockers: none. +Non-blocking follow-ups: none. + +Validation adequacy: +- Coder validation covered fmt, focused/full TUI tests, TUI check, doctor, diff-check, and `ui::Mode` grep. +- Reviewer additionally performed read-only diff/reference checks and found no issues. + + ---