fix: require exact attachment acceptance

This commit is contained in:
2026-09-03 08:38:15 +09:00
parent 36cfbbe6d2
commit 7ee6c307fc
3 changed files with 67 additions and 11 deletions
+1
View File
@@ -987,6 +987,7 @@ mod tests {
"safe\u{180e}name.txt", "safe\u{180e}name.txt",
"safe\u{e0001}name.txt", "safe\u{e0001}name.txt",
"p\u{0430}ypal.txt", "p\u{0430}ypal.txt",
"report.\u{03c1}df",
"\u{0440}\u{0430}\u{0443}\u{0440}\u{0430}\u{04cf}.txt", "\u{0440}\u{0430}\u{0443}\u{0440}\u{0430}\u{04cf}.txt",
"\u{ff26}\u{ff49}\u{ff4c}\u{ff45}.txt", "\u{ff26}\u{ff49}\u{ff4c}\u{ff45}.txt",
"re\u{0301}sume\u{0301}.txt", "re\u{0301}sume\u{0301}.txt",
+10 -8
View File
@@ -65,21 +65,23 @@ struct StoredUploadedFile {
pub(crate) fn validate_file_name(file_name: &str) -> Result<()> { pub(crate) fn validate_file_name(file_name: &str) -> Result<()> {
let normalized: String = file_name.nfkc().collect(); let normalized: String = file_name.nfkc().collect();
let stem = file_name let has_unsafe_component = file_name
.rsplit_once('.') .split('.')
.map_or(file_name, |(stem, _)| stem); .filter(|part| !part.is_empty())
let confusable_skeleton: String = skeleton(stem).collect(); .any(|part| {
let ascii_confusable = stem.chars().any(|ch| !ch.is_ascii()) let confusable_skeleton: String = skeleton(part).collect();
let ascii_confusable = part.chars().any(|ch| !ch.is_ascii())
&& confusable_skeleton.is_ascii() && confusable_skeleton.is_ascii()
&& !confusable_skeleton.eq_ignore_ascii_case(stem); && !confusable_skeleton.eq_ignore_ascii_case(part);
!part.is_single_script() || ascii_confusable
});
if file_name.is_empty() if file_name.is_empty()
|| file_name.chars().count() > MAX_FILE_NAME_CHARS || file_name.chars().count() > MAX_FILE_NAME_CHARS
|| file_name == "." || file_name == "."
|| file_name == ".." || file_name == ".."
|| normalized != file_name || normalized != file_name
|| !stem.is_single_script() || has_unsafe_component
|| ascii_confusable
|| file_name.chars().any(|ch| { || file_name.chars().any(|ch| {
ch.is_control() ch.is_control()
|| ch.general_category() == GeneralCategory::Format || ch.general_category() == GeneralCategory::Format
+55 -2
View File
@@ -145,8 +145,15 @@ fn reconcile_attachment_submission(
_ => None, _ => None,
}) })
.collect::<Vec<_>>(); .collect::<Vec<_>>();
awaiting_acceptance.retain(|file| !accepted_ids.contains(&file.artifact_id.as_str())); let accepts_exact_submission = had_awaiting
had_awaiting && awaiting_acceptance.is_empty() && accepted_ids.len() == awaiting_acceptance.len()
&& awaiting_acceptance
.iter()
.all(|file| accepted_ids.contains(&file.artifact_id.as_str()));
if accepts_exact_submission {
awaiting_acceptance.clear();
}
accepts_exact_submission
} }
Event::Error { .. } if !awaiting_acceptance.is_empty() => { Event::Error { .. } if !awaiting_acceptance.is_empty() => {
pending.append(awaiting_acceptance); pending.append(awaiting_acceptance);
@@ -1523,6 +1530,52 @@ mod tests {
assert!(connection.awaiting_attachment_acceptance.is_empty()); assert!(connection.awaiting_attachment_acceptance.is_empty());
} }
#[test]
fn partial_attachment_echo_does_not_acknowledge_an_atomic_submission() {
let first = UploadedFileRef {
artifact_id: "artifact-1".into(),
file_name: "one.txt".into(),
media_type: "text/plain".into(),
created_at_ms: 1,
availability: UploadedFileAvailability::Available,
byte_len: 1,
sha256: "a".repeat(64),
source_entry_id: None,
};
let second = UploadedFileRef {
artifact_id: "artifact-2".into(),
file_name: "two.txt".into(),
..first.clone()
};
let mut pending = Vec::new();
let mut awaiting = vec![first.clone(), second.clone()];
assert!(!reconcile_attachment_submission(
&mut pending,
&mut awaiting,
&Event::UserMessage {
segments: vec![Segment::UploadedFile { file: first }],
},
));
assert_eq!(
awaiting,
vec![
UploadedFileRef {
artifact_id: "artifact-1".into(),
file_name: "one.txt".into(),
media_type: "text/plain".into(),
created_at_ms: 1,
availability: UploadedFileAvailability::Available,
byte_len: 1,
sha256: "a".repeat(64),
source_entry_id: None,
},
second,
]
);
assert!(pending.is_empty());
}
#[test] #[test]
fn single_worker_mouse_capture_avoids_drag_and_all_motion_modes() { fn single_worker_mouse_capture_avoids_drag_and_all_motion_modes() {
let mut ansi = String::new(); let mut ansi = String::new();