From 7f81c6cdf4b0cb3e6302afe92a4017073d936e40 Mon Sep 17 00:00:00 2001 From: Hare Date: Wed, 8 Jul 2026 19:23:18 +0900 Subject: [PATCH] ticket: record decodal profile archive review fixes --- .yoi/tickets/00001KWZ5KERY/item.md | 2 +- .yoi/tickets/00001KWZ5KERY/thread.md | 27 +++++++++++++++++++++++++++ 2 files changed, 28 insertions(+), 1 deletion(-) diff --git a/.yoi/tickets/00001KWZ5KERY/item.md b/.yoi/tickets/00001KWZ5KERY/item.md index b42238ac..94da123b 100644 --- a/.yoi/tickets/00001KWZ5KERY/item.md +++ b/.yoi/tickets/00001KWZ5KERY/item.md @@ -2,7 +2,7 @@ title: 'Migrate Profiles to Decodal ProfileSourceArchive for Runtime launch' state: 'inprogress' created_at: '2026-07-07T20:51:35Z' -updated_at: '2026-07-08T10:07:07Z' +updated_at: '2026-07-08T10:23:11Z' assignee: null queued_by: 'workspace-panel' queued_at: '2026-07-08T09:11:22Z' diff --git a/.yoi/tickets/00001KWZ5KERY/thread.md b/.yoi/tickets/00001KWZ5KERY/thread.md index 4800c196..f6a1336a 100644 --- a/.yoi/tickets/00001KWZ5KERY/thread.md +++ b/.yoi/tickets/00001KWZ5KERY/thread.md @@ -239,3 +239,30 @@ Non-blocking follow-ups: - supported profile registry boundary をより明確にするとよい。現状 Backend archive construction は embedded builtins hardcode で、Ticket は workspace/project/builtin profile registry discovery を記述している。 --- + + + +## Implementation report + +Review-fix implementation report: + +- Coder Pod completed requested changes and committed follow-up `a2833dad fix: reject unknown profile archive selectors` on branch `work/00001KWZ5KERY-decodal-profile-archive`. +- Worktree status was clean after commit. +- Fix summary: + - Embedded Decodal profiles no longer use unsupported `tool_enabled`; they now use existing typed `ProfileConfig` fields such as `feature` plus existing model/session/engine/memory/web fields as applicable。 + - Archive selector fallback to `default` was removed; missing selector now returns `ProfileArchiveError::MissingEntrypoint`。 + - Backend embedded archive construction rejects unknown `Builtin` and unknown `Named` selectors instead of mapping them to default。 + - Added focused tests proving every embedded builtin `.dcdl` resolves through real Backend-built `ProfileSourceArchive` + Decodal + `ProfileConfig` path。 + - Added tests for unknown Builtin/Named selector rejection and no default fallback for missing selectors。 +- Orchestrator reran validation in the implementation worktree: + - `git diff --check`: pass + - `cargo test -p worker-runtime --features ws-server,fs-store`: pass（41 lib tests + 5 main tests + doc tests） + - `cargo test -p yoi-workspace-server`: pass（69 lib tests + 2 main tests） + - `cargo check -p yoi`: pass + - `cd web/workspace && deno task check`: pass（0 errors / 0 warnings） + - `cd web/workspace && deno task test`: pass（17 tests） + - `yoi ticket doctor`: ok + - `nix build .#yoi --no-link`: pass +- Requesting follow-up external review against `a823d414..a2833dad` and full combined implementation。 + +---