From 856de91c51f01d89bfc78add08eab0524d744fb4 Mon Sep 17 00:00:00 2001 From: Hare Date: Mon, 8 Jun 2026 12:33:01 +0900 Subject: [PATCH] ticket: close intake claim timing fix --- .../artifacts/.gitkeep | 0 .../item.md | 6 +- .../resolution.md | 31 +++++++++ .../thread.md | 63 +++++++++++++++++++ 4 files changed, 97 insertions(+), 3 deletions(-) rename .yoi/tickets/{open => closed}/20260607-220225-commit-intake-claims-after-launch-success/artifacts/.gitkeep (100%) rename .yoi/tickets/{open => closed}/20260607-220225-commit-intake-claims-after-launch-success/item.md (97%) create mode 100644 .yoi/tickets/closed/20260607-220225-commit-intake-claims-after-launch-success/resolution.md rename .yoi/tickets/{open => closed}/20260607-220225-commit-intake-claims-after-launch-success/thread.md (84%) diff --git a/.yoi/tickets/open/20260607-220225-commit-intake-claims-after-launch-success/artifacts/.gitkeep b/.yoi/tickets/closed/20260607-220225-commit-intake-claims-after-launch-success/artifacts/.gitkeep similarity index 100% rename from .yoi/tickets/open/20260607-220225-commit-intake-claims-after-launch-success/artifacts/.gitkeep rename to .yoi/tickets/closed/20260607-220225-commit-intake-claims-after-launch-success/artifacts/.gitkeep diff --git a/.yoi/tickets/open/20260607-220225-commit-intake-claims-after-launch-success/item.md b/.yoi/tickets/closed/20260607-220225-commit-intake-claims-after-launch-success/item.md similarity index 97% rename from .yoi/tickets/open/20260607-220225-commit-intake-claims-after-launch-success/item.md rename to .yoi/tickets/closed/20260607-220225-commit-intake-claims-after-launch-success/item.md index ea437274..94cc3866 100644 --- a/.yoi/tickets/open/20260607-220225-commit-intake-claims-after-launch-success/item.md +++ b/.yoi/tickets/closed/20260607-220225-commit-intake-claims-after-launch-success/item.md @@ -2,13 +2,13 @@ id: 20260607-220225-commit-intake-claims-after-launch-success slug: commit-intake-claims-after-launch-success title: Commit Intake ticket claims only after successful launch -status: open +status: 'closed' kind: task priority: P1 labels: [tui, panel, ticket, intake, bug] -workflow_state: 'inprogress' +workflow_state: 'done' created_at: 2026-06-07T22:02:25Z -updated_at: '2026-06-08T03:31:31Z' +updated_at: '2026-06-08T03:32:46Z' assignee: null legacy_ticket: null queued_by: 'workspace-panel' diff --git a/.yoi/tickets/closed/20260607-220225-commit-intake-claims-after-launch-success/resolution.md b/.yoi/tickets/closed/20260607-220225-commit-intake-claims-after-launch-success/resolution.md new file mode 100644 index 00000000..9b92c54f --- /dev/null +++ b/.yoi/tickets/closed/20260607-220225-commit-intake-claims-after-launch-success/resolution.md @@ -0,0 +1,31 @@ +Merged and completed the Intake claim commit timing fix. + +Summary: +- Existing-Ticket Intake durable claim persistence now happens only after `launch_ticket_role_pod_with_options(...).await?` returns successfully with launch/run acceptance evidence. +- Pre-launch durable `claim_ticket(...)` was removed from `prepare_existing_ticket_intake_launch`. +- Deferred `IntakeRegistryUpdate::ClaimTicket` is committed by `commit_intake_registry_update(...)` after launch success. +- Existing live/restorable claims still block duplicate Intake launch before launch preparation. +- In-flight duplicate protection remains transient via `self.sending`; it is not a durable claim. +- Peer registration/handoff ordering is preserved. + +Merged branch/worktree: +- Branch: `commit-intake-claims-after-launch-success` +- Commit: `6797be3 fix: defer intake claim until launch acceptance` +- Merge commit on `develop`: `3bc4ab2 merge: defer intake claims until launch success` + +Validation passed after merge: +- `cargo test -p tui role_session_registry --lib` +- `cargo test -p tui multi_pod --lib` +- `cargo check -q` +- `cargo fmt --check` +- `git diff --check` +- `cargo run -q -p yoi -- ticket doctor` +- `nix build .#yoi` + +Cleanup completed: +- Stopped coder/reviewer Pods and reclaimed scope. +- Removed `.worktree/commit-intake-claims-after-launch-success`. +- Deleted branch `commit-intake-claims-after-launch-success`. + +Residual note: +- There is still no full mocked/integration test that drives spawn/connect/run-acceptance failure through `launch_intake_with_handoff` and then asserts registry emptiness. Reviewer accepted the explicit `await?` before registry commit and focused tests as sufficient for this Ticket. \ No newline at end of file diff --git a/.yoi/tickets/open/20260607-220225-commit-intake-claims-after-launch-success/thread.md b/.yoi/tickets/closed/20260607-220225-commit-intake-claims-after-launch-success/thread.md similarity index 84% rename from .yoi/tickets/open/20260607-220225-commit-intake-claims-after-launch-success/thread.md rename to .yoi/tickets/closed/20260607-220225-commit-intake-claims-after-launch-success/thread.md index c93db118..b32b5be5 100644 --- a/.yoi/tickets/open/20260607-220225-commit-intake-claims-after-launch-success/thread.md +++ b/.yoi/tickets/closed/20260607-220225-commit-intake-claims-after-launch-success/thread.md @@ -272,3 +272,66 @@ Parent/human decision needs: - User has authorized merge-completion and cleanup after approved work. Proceeding to merge-completion unless post-merge validation fails. --- + + + +## Review: approve + +Final merge-completion approval after merge to `develop` and post-merge validation. + +Evidence: +- Merged branch `commit-intake-claims-after-launch-success` with `--no-ff`. +- Reviewer `reviewer-commit-intake-claims` approved the branch-local implementation. +- Post-merge validation passed: `cargo test -p tui role_session_registry --lib`, `cargo test -p tui multi_pod --lib`, `cargo check -q`, `cargo fmt --check`, `git diff --check`, `cargo run -q -p yoi -- ticket doctor`, and `nix build .#yoi`. +- Coder/reviewer Pods stopped and delegated scope reclaimed. +- Merged worktree removed and branch deleted. + +This approval is for the merged main-branch result, not merely the branch-local reviewer verdict. + +--- + + + +## State changed + +Merged to `develop`, post-merge validation passed, final merge-completion approval recorded, and Intake claim branch/worktree/Pods cleaned up. + +--- + + + +## Closed + +Merged and completed the Intake claim commit timing fix. + +Summary: +- Existing-Ticket Intake durable claim persistence now happens only after `launch_ticket_role_pod_with_options(...).await?` returns successfully with launch/run acceptance evidence. +- Pre-launch durable `claim_ticket(...)` was removed from `prepare_existing_ticket_intake_launch`. +- Deferred `IntakeRegistryUpdate::ClaimTicket` is committed by `commit_intake_registry_update(...)` after launch success. +- Existing live/restorable claims still block duplicate Intake launch before launch preparation. +- In-flight duplicate protection remains transient via `self.sending`; it is not a durable claim. +- Peer registration/handoff ordering is preserved. + +Merged branch/worktree: +- Branch: `commit-intake-claims-after-launch-success` +- Commit: `6797be3 fix: defer intake claim until launch acceptance` +- Merge commit on `develop`: `3bc4ab2 merge: defer intake claims until launch success` + +Validation passed after merge: +- `cargo test -p tui role_session_registry --lib` +- `cargo test -p tui multi_pod --lib` +- `cargo check -q` +- `cargo fmt --check` +- `git diff --check` +- `cargo run -q -p yoi -- ticket doctor` +- `nix build .#yoi` + +Cleanup completed: +- Stopped coder/reviewer Pods and reclaimed scope. +- Removed `.worktree/commit-intake-claims-after-launch-success`. +- Deleted branch `commit-intake-claims-after-launch-success`. + +Residual note: +- There is still no full mocked/integration test that drives spawn/connect/run-acceptance failure through `launch_intake_with_handoff` and then asserts registry emptiness. Reviewer accepted the explicit `await?` before registry commit and focused tests as sufficient for this Ticket. + +---