From 885e493ba23fa43c7b5e4caa63c837a044ee9cb7 Mon Sep 17 00:00:00 2001 From: Hare Date: Mon, 8 Jun 2026 17:08:21 +0900 Subject: [PATCH] ticket: record spawnpod cwd re-review --- .../item.md | 2 +- .../thread.md | 33 +++++++++++++++++++ 2 files changed, 34 insertions(+), 1 deletion(-) diff --git a/.yoi/tickets/open/20260608-011036-allow-spawnpod-child-workspace-cwd/item.md b/.yoi/tickets/open/20260608-011036-allow-spawnpod-child-workspace-cwd/item.md index a7027318..ca5adc6f 100644 --- a/.yoi/tickets/open/20260608-011036-allow-spawnpod-child-workspace-cwd/item.md +++ b/.yoi/tickets/open/20260608-011036-allow-spawnpod-child-workspace-cwd/item.md @@ -8,7 +8,7 @@ priority: 'P2' labels: ['pod', 'spawn', 'cwd', 'worktree', 'orchestration'] workflow_state: 'inprogress' created_at: '2026-06-08T01:10:36Z' -updated_at: '2026-06-08T07:32:03Z' +updated_at: '2026-06-08T08:08:10Z' assignee: null legacy_ticket: null queued_by: 'workspace-panel' diff --git a/.yoi/tickets/open/20260608-011036-allow-spawnpod-child-workspace-cwd/thread.md b/.yoi/tickets/open/20260608-011036-allow-spawnpod-child-workspace-cwd/thread.md index 8bd40d0f..c918137a 100644 --- a/.yoi/tickets/open/20260608-011036-allow-spawnpod-child-workspace-cwd/thread.md +++ b/.yoi/tickets/open/20260608-011036-allow-spawnpod-child-workspace-cwd/thread.md @@ -268,3 +268,36 @@ Pending: - No merge, close, final approval, or cleanup has occurred. --- + + + +## Implementation report + +Coder fix-loop completed and reviewer re-review delegated. + +Coder follow-up: +- Commit: `248744f fix: keep SpawnPod cwd separate` +- Worktree: clean on branch `allow-spawnpod-child-workspace-cwd`. +- Fixes claimed: + - `SpawnPod.cwd` is passed as hidden `--tool-cwd`, while child runtime still receives inherited `--workspace `. + - Child process launch current_dir is workspace root, not tool cwd, preventing runtime context from being derived from the tool cwd. + - Adopted child startup separates runtime workspace context from tool cwd. + - `Pod` stores `workspace_root` and `pwd` separately; memory/Ticket/workflow/Profile context uses `workspace_root`, while Bash/tools/ScopedFs use `pwd`. + - Ticket role coder guidance no longer assumes mandatory `cd ` when SpawnPod cwd is available. + - Added tests proving runtime workspace and tool cwd stay separate, omitted cwd preserves prior pwd behavior, and memory layout derives from workspace root rather than tool cwd. + +Coder validation reported: +- `cargo test -p pod spawn_pod` +- `cargo fmt --check` +- `git diff --check` +- `cargo run -q -p yoi -- ticket doctor` +- `nix build .#yoi` + +Action taken: +- Sent updated commits and prior blocker checklist to `reviewer-spawnpod-child-cwd` for read-only re-review. + +Pending: +- Await reviewer verdict before merge-ready dossier / merge-completion. +- No merge, close, final approval, or cleanup has occurred. + +---