From 8db3ff5de7be5d8afca1ec78735edb92d776ebe1 Mon Sep 17 00:00:00 2001 From: Hare Date: Sat, 30 May 2026 02:26:20 +0900 Subject: [PATCH] review: approve pod socket disconnect noise fix --- .../item.md | 2 +- .../thread.md | 33 +++++++++++++++++++ 2 files changed, 34 insertions(+), 1 deletion(-) diff --git a/work-items/open/20260529-171326-pod-socket-peer-disconnect-noise/item.md b/work-items/open/20260529-171326-pod-socket-peer-disconnect-noise/item.md index 0d41147b..83961473 100644 --- a/work-items/open/20260529-171326-pod-socket-peer-disconnect-noise/item.md +++ b/work-items/open/20260529-171326-pod-socket-peer-disconnect-noise/item.md @@ -7,7 +7,7 @@ kind: bug priority: P1 labels: [pod, ipc, tui, noise] created_at: 2026-05-29T17:13:26Z -updated_at: 2026-05-29T17:13:26Z +updated_at: 2026-05-29T17:26:19Z assignee: null legacy_ticket: null --- diff --git a/work-items/open/20260529-171326-pod-socket-peer-disconnect-noise/thread.md b/work-items/open/20260529-171326-pod-socket-peer-disconnect-noise/thread.md index f8b95b36..f1697b17 100644 --- a/work-items/open/20260529-171326-pod-socket-peer-disconnect-noise/thread.md +++ b/work-items/open/20260529-171326-pod-socket-peer-disconnect-noise/thread.md @@ -4,4 +4,37 @@ Created by tickets.sh create. +--- + + + +## Review: approve + +Reviewed implementation commit `d5d50a3 fix: suppress pod socket peer disconnect noise` from branch `work/pod-socket-peer-disconnect-noise`. + +Result: approved. + +The implementation correctly separates normal peer disconnect read errors from invalid method payloads in `crates/pod/src/ipc/server.rs`: + +- `ConnectionReset`, `ConnectionAborted`, `BrokenPipe`, and `UnexpectedEof` now close only the affected connection. +- Those peer disconnects no longer broadcast `Event::Error` to unrelated clients. +- malformed/schema-invalid Method lines still return a clear `InvalidRequest` error to the offending connection. + +Focused tests cover both paths: + +- `peer_disconnect_read_errors_are_connection_close` +- `invalid_data_is_not_peer_disconnect` +- `socket_schema_invalid_method_returns_error` +- `socket_malformed_method_returns_error` +- `socket_peer_close_without_method_does_not_broadcast_error` + +Validation reported by implementer: + +- `cargo fmt --check` passed +- `cargo test -p pod ipc::server -- --nocapture` passed +- `cargo test -p pod --test controller_test socket_ -- --nocapture` passed + +Full `cargo test -p pod --test controller_test -- --nocapture` still has unrelated empty-turn rollback failures; the new socket tests passed within that run and the failing area is unrelated to this IPC disconnect change. + + ---