From 93265ae65cbe9b8ffead3fe78064b14e1e52b1fe Mon Sep 17 00:00:00 2001 From: Hare Date: Sat, 20 Jun 2026 15:46:18 +0900 Subject: [PATCH] ticket: record plugin authoring cli hardening fix --- .yoi/tickets/00001KVHKWNQS/item.md | 2 +- .yoi/tickets/00001KVHKWNQS/thread.md | 49 ++++++++++++++++++++++++++++ 2 files changed, 50 insertions(+), 1 deletion(-) diff --git a/.yoi/tickets/00001KVHKWNQS/item.md b/.yoi/tickets/00001KVHKWNQS/item.md index a136b751..4b76fa6e 100644 --- a/.yoi/tickets/00001KVHKWNQS/item.md +++ b/.yoi/tickets/00001KVHKWNQS/item.md @@ -2,7 +2,7 @@ title: 'Plugin: add authoring CLI new/check/pack' state: 'inprogress' created_at: '2026-06-20T04:16:14Z' -updated_at: '2026-06-20T06:36:52Z' +updated_at: '2026-06-20T06:46:09Z' assignee: null readiness: 'implementation_ready' risk_flags: ['plugin', 'cli', 'authoring', 'templates', 'package-validation', 'packaging', 'read-only-check'] diff --git a/.yoi/tickets/00001KVHKWNQS/thread.md b/.yoi/tickets/00001KVHKWNQS/thread.md index 8308c013..96846a8d 100644 --- a/.yoi/tickets/00001KVHKWNQS/thread.md +++ b/.yoi/tickets/00001KVHKWNQS/thread.md @@ -231,3 +231,52 @@ Reviewer validation: Worktree status at review end: clean。 --- + + + +## Implementation report + +Coder r1-fix report received from `yoi-coder-00001KVHKWNQS`. + +New fix commit: +- `699db538 plugin: harden authoring checks` + +Branch commits now: +- `699db538 plugin: harden authoring checks` +- `945ecdf6 plugin: add authoring cli` + +Fix summary: +- `plugin new` rejects an existing destination symlink via `symlink_metadata` before writes。 +- Added regression test ensuring symlink destination is refused and target is not written。 +- `plugin check` detects embedded generated placeholder `plugin.component.wasm`。 +- Fresh generated templates report `status: "partial"` instead of `active`。 +- JSON/human diagnostics include bounded placeholder warning。 +- Enablement guidance no longer says a package is ready to enable while placeholder artifact remains。 +- `partial` checks exit successfully; `rejected` checks remain non-zero。 +- Docs updated for symlink refusal and placeholder/partial behavior。 + +Coder validation reported as passing: +- `cargo fmt --check` +- `git diff --check d1095f85..HEAD` +- `cargo check -p yoi` +- `cargo test -p yoi plugin_cli` +- `cargo test -p yoi-plugin-pdk template` +- CLI smoke: + - `plugin new ... --json` + - `plugin check --json` => `partial` with placeholder diagnostic。 + - `plugin pack ... --json` => `packed`。 + - `plugin check --json` => `partial`。 + - copied packed archive into `.yoi/plugins` and confirmed `plugin list --workspace ... --json` discovers it。 + - invalid check after removing runtime artifact => `rejected` and non-zero。 +- Freed only child-worktree Cargo build artifacts with `cargo clean` and reran `nix build .#yoi --no-link`; it completed successfully。 + +Orchestrator evidence checked before r2 review: +- Implementation worktree is clean。 +- HEAD is `699db538`。 +- Fix diff from `945ecdf6..HEAD` touches `crates/yoi/src/plugin_cli.rs` and `docs/development/plugin-development.md`, about 124 insertions / 34 deletions。 +- Overall `git diff --check d1095f85..HEAD` produced no diagnostics。 + +Next action: +- Route back to Reviewer for r2 verification of symlink destination refusal, placeholder partial/check behavior, and final acceptance criteria。 + +---