From 9753b34fb9dfa450d1fc87aa60591f20d8deff21 Mon Sep 17 00:00:00 2001 From: Hare Date: Thu, 4 Jun 2026 02:07:47 +0900 Subject: [PATCH] ticket: close hook api hardening --- .../artifacts/.gitkeep | 0 .../artifacts/delegation-intent.md | 0 .../artifacts/rereview.md | 0 .../artifacts/review.md | 0 .../item.md | 4 ++-- .../resolution.md | 1 + .../thread.md | 9 +++++++++ 7 files changed, 12 insertions(+), 2 deletions(-) rename work-items/{open => closed}/20260603-122317-hook-public-surface-hardening/artifacts/.gitkeep (100%) rename work-items/{open => closed}/20260603-122317-hook-public-surface-hardening/artifacts/delegation-intent.md (100%) rename work-items/{open => closed}/20260603-122317-hook-public-surface-hardening/artifacts/rereview.md (100%) rename work-items/{open => closed}/20260603-122317-hook-public-surface-hardening/artifacts/review.md (100%) rename work-items/{open => closed}/20260603-122317-hook-public-surface-hardening/item.md (98%) create mode 100644 work-items/closed/20260603-122317-hook-public-surface-hardening/resolution.md rename work-items/{open => closed}/20260603-122317-hook-public-surface-hardening/thread.md (95%) diff --git a/work-items/open/20260603-122317-hook-public-surface-hardening/artifacts/.gitkeep b/work-items/closed/20260603-122317-hook-public-surface-hardening/artifacts/.gitkeep similarity index 100% rename from work-items/open/20260603-122317-hook-public-surface-hardening/artifacts/.gitkeep rename to work-items/closed/20260603-122317-hook-public-surface-hardening/artifacts/.gitkeep diff --git a/work-items/open/20260603-122317-hook-public-surface-hardening/artifacts/delegation-intent.md b/work-items/closed/20260603-122317-hook-public-surface-hardening/artifacts/delegation-intent.md similarity index 100% rename from work-items/open/20260603-122317-hook-public-surface-hardening/artifacts/delegation-intent.md rename to work-items/closed/20260603-122317-hook-public-surface-hardening/artifacts/delegation-intent.md diff --git a/work-items/open/20260603-122317-hook-public-surface-hardening/artifacts/rereview.md b/work-items/closed/20260603-122317-hook-public-surface-hardening/artifacts/rereview.md similarity index 100% rename from work-items/open/20260603-122317-hook-public-surface-hardening/artifacts/rereview.md rename to work-items/closed/20260603-122317-hook-public-surface-hardening/artifacts/rereview.md diff --git a/work-items/open/20260603-122317-hook-public-surface-hardening/artifacts/review.md b/work-items/closed/20260603-122317-hook-public-surface-hardening/artifacts/review.md similarity index 100% rename from work-items/open/20260603-122317-hook-public-surface-hardening/artifacts/review.md rename to work-items/closed/20260603-122317-hook-public-surface-hardening/artifacts/review.md diff --git a/work-items/open/20260603-122317-hook-public-surface-hardening/item.md b/work-items/closed/20260603-122317-hook-public-surface-hardening/item.md similarity index 98% rename from work-items/open/20260603-122317-hook-public-surface-hardening/item.md rename to work-items/closed/20260603-122317-hook-public-surface-hardening/item.md index 2da66029..de954073 100644 --- a/work-items/open/20260603-122317-hook-public-surface-hardening/item.md +++ b/work-items/closed/20260603-122317-hook-public-surface-hardening/item.md @@ -2,12 +2,12 @@ id: 20260603-122317-hook-public-surface-hardening slug: hook-public-surface-hardening title: Hook: harden public hook surface before plugin exposure -status: open +status: closed kind: task priority: P1 labels: [hooks, plugin, safety, tests] created_at: 2026-06-03T12:23:17Z -updated_at: 2026-06-03T17:05:43Z +updated_at: 2026-06-03T17:07:44Z assignee: null legacy_ticket: null --- diff --git a/work-items/closed/20260603-122317-hook-public-surface-hardening/resolution.md b/work-items/closed/20260603-122317-hook-public-surface-hardening/resolution.md new file mode 100644 index 00000000..934bb5f8 --- /dev/null +++ b/work-items/closed/20260603-122317-hook-public-surface-hardening/resolution.md @@ -0,0 +1 @@ +Hardened public pod::hook actions for plugin/feature exposure. Public hooks no longer expose raw Item injection or no-result pre-tool skip; public pre-tool deny maps to synthetic error results; internal interceptor capabilities remain internal. Added focused Pod-layer hook tests; reviewer blocker fixed and rereview approved. Validation passed: cargo test -p pod hook --lib, cargo test -p pod --lib, cargo test -p llm-worker --lib, cargo fmt --check, cargo check --workspace --all-targets, ./tickets.sh doctor, git diff --check, nix build .#yoi, ./result/bin/yoi pod --help. diff --git a/work-items/open/20260603-122317-hook-public-surface-hardening/thread.md b/work-items/closed/20260603-122317-hook-public-surface-hardening/thread.md similarity index 95% rename from work-items/open/20260603-122317-hook-public-surface-hardening/thread.md rename to work-items/closed/20260603-122317-hook-public-surface-hardening/thread.md index 5fdea1a3..4a523c90 100644 --- a/work-items/open/20260603-122317-hook-public-surface-hardening/thread.md +++ b/work-items/closed/20260603-122317-hook-public-surface-hardening/thread.md @@ -229,4 +229,13 @@ I did not run `cargo test`, `cargo check`, or `nix build`; those commands would No merge-blocking residual risk found. The remaining risk is API polish for the future feature/plugin registry, especially whether all hook input summary types should become Pod-owned wrapper types before being treated as a stable plugin boundary. +--- + + + +## Closed + +Hardened public pod::hook actions for plugin/feature exposure. Public hooks no longer expose raw Item injection or no-result pre-tool skip; public pre-tool deny maps to synthetic error results; internal interceptor capabilities remain internal. Added focused Pod-layer hook tests; reviewer blocker fixed and rereview approved. Validation passed: cargo test -p pod hook --lib, cargo test -p pod --lib, cargo test -p llm-worker --lib, cargo fmt --check, cargo check --workspace --all-targets, ./tickets.sh doctor, git diff --check, nix build .#yoi, ./result/bin/yoi pod --help. + + ---