diff --git a/.yoi/tickets/open/20260608-000047-introduce-runtime-workspace-root-context/item.md b/.yoi/tickets/open/20260608-000047-introduce-runtime-workspace-root-context/item.md index 50869201..1bbfa653 100644 --- a/.yoi/tickets/open/20260608-000047-introduce-runtime-workspace-root-context/item.md +++ b/.yoi/tickets/open/20260608-000047-introduce-runtime-workspace-root-context/item.md @@ -8,7 +8,7 @@ priority: 'P1' labels: ['workspace', 'pod', 'profile', 'cli', 'panel', 'memory'] workflow_state: 'inprogress' created_at: '2026-06-08T00:00:47Z' -updated_at: '2026-06-08T01:36:01Z' +updated_at: '2026-06-08T01:43:05Z' assignee: null legacy_ticket: null queued_by: 'workspace-panel' diff --git a/.yoi/tickets/open/20260608-000047-introduce-runtime-workspace-root-context/thread.md b/.yoi/tickets/open/20260608-000047-introduce-runtime-workspace-root-context/thread.md index cf7a6b7a..16f63f77 100644 --- a/.yoi/tickets/open/20260608-000047-introduce-runtime-workspace-root-context/thread.md +++ b/.yoi/tickets/open/20260608-000047-introduce-runtime-workspace-root-context/thread.md @@ -333,3 +333,36 @@ Pending: - No merge, close, final approval, or cleanup has occurred. --- + + + +## Implementation report + +Reviewer returned `request_changes`; coder fix-loop delegated. + +Reviewer verdict: +- `request_changes` + +Blockers: +1. Client spawn emits `--session ... --pod ...`, but `crates/pod/src/entrypoint.rs` still rejects `--session` with `--pod`. +2. Top-level `yoi --session ... --pod ...` is still rejected in `crates/yoi/src/main.rs`, contradicting the binding decision that `--pod` is runtime identity for restore and fresh create. +3. Hidden `--session-pod-name` remains in `crates/pod/src/entrypoint.rs` as a session-specific identity path, preserving the old split this bundle is meant to remove/collapse. + +Reviewer evidence: +- Reviewed diff `develop...b6af761`. +- Ran focused tests for client/pod/yoi/tui/manifest/memory paths. +- Focused CLI probes showed both top-level and `yoi pod` restore forms reject `--session ... --pod ...`. + +Non-blocking reviewer observations: +- Profile-derived identity removal looked aligned. +- Panel Companion/Orchestrator naming looked aligned. +- Ticket role explicit names looked aligned. +- Memory-root behavior did not appear conflated. + +Action taken: +- Sent fix-loop instructions to `coder-runtime-workspace-context-2` with the three blockers and required focused tests. +- Reviewer approval is pending after coder fix report and re-review. + +No merge, close, final approval, or cleanup has occurred. + +---