From 9d030fbbc931cbcf8c254ae2ec27ffb8e8be9070 Mon Sep 17 00:00:00 2001 From: Hare Date: Mon, 8 Jun 2026 05:45:05 +0900 Subject: [PATCH] ticket: approve companion pod lifecycle --- .../item.md | 2 +- .../thread.md | 33 +++++++++++++++++++ 2 files changed, 34 insertions(+), 1 deletion(-) diff --git a/.yoi/tickets/open/20260607-001651-workspace-panel-companion-pod-lifecycle/item.md b/.yoi/tickets/open/20260607-001651-workspace-panel-companion-pod-lifecycle/item.md index d88f4a61..06e80671 100644 --- a/.yoi/tickets/open/20260607-001651-workspace-panel-companion-pod-lifecycle/item.md +++ b/.yoi/tickets/open/20260607-001651-workspace-panel-companion-pod-lifecycle/item.md @@ -8,7 +8,7 @@ priority: P2 labels: [tui, panel, companion, pod] workflow_state: ready created_at: 2026-06-07T00:16:51Z -updated_at: 2026-06-07T10:40:36Z +updated_at: 2026-06-07T20:45:05Z assignee: null legacy_ticket: null --- diff --git a/.yoi/tickets/open/20260607-001651-workspace-panel-companion-pod-lifecycle/thread.md b/.yoi/tickets/open/20260607-001651-workspace-panel-companion-pod-lifecycle/thread.md index 0bbdb00d..b30edea6 100644 --- a/.yoi/tickets/open/20260607-001651-workspace-panel-companion-pod-lifecycle/thread.md +++ b/.yoi/tickets/open/20260607-001651-workspace-panel-companion-pod-lifecycle/thread.md @@ -162,4 +162,37 @@ Caveat: External review will be delegated before merge. +--- + + + +## Review: approve + +Approved by `companion-lifecycle-reviewer-20260607`. + +No review-blocking issues were found in `ba0c9d5` against `develop`. + +Evidence: +- Companion naming is the workspace basename, with no `-companion` suffix; this repository resolves to `yoi`. +- Live/restorable/missing Companion lifecycle is distinct from Orchestrator lifecycle and does not depend on Ticket config gating. +- Missing Companion spawn/restore uses ordinary Pod startup rather than Ticket role launch; Orchestrator remains the only changed path using `TicketRole::Orchestrator`. +- Panel close does not stop Companion. +- Non-empty Companion composer submit targets the workspace Companion Pod from panel header state, not the selected Pod. +- Ticket Intake remains separate and builds an Intake launch request with `TicketRole::Intake`; it does not send to Companion history. +- Companion is not modeled as a Ticket role. +- No `--multi`, `:ticket`, or selected-Pod direct-send route was reintroduced. + +Reviewer validation: +- `cargo test -p tui companion --lib` +- `cargo test -p tui multi_pod --lib` +- `cargo test -p tui workspace_panel --lib` +- `cargo test -p tui --lib` +- `cargo fmt --check` +- `git diff --check develop...HEAD` +- `nix build .#yoi` +- `result/bin/yoi ticket doctor` + +Worktree status was clean after validation, and the diff is limited to `crates/tui/src/multi_pod.rs` and `crates/tui/src/workspace_panel.rs`. + + ---