From a0c14082796071a6a2784b33a4d3e3d8897787d8 Mon Sep 17 00:00:00 2001 From: Hare Date: Sun, 7 Jun 2026 13:04:23 +0900 Subject: [PATCH] ticket: approve ticket init scaffold --- .../item.md | 2 +- .../thread.md | 32 +++++++++++++++++++ 2 files changed, 33 insertions(+), 1 deletion(-) diff --git a/.yoi/tickets/open/20260607-031439-ticket-init-role-profile-scaffold/item.md b/.yoi/tickets/open/20260607-031439-ticket-init-role-profile-scaffold/item.md index 4ec98bb4..1a5e7cd3 100644 --- a/.yoi/tickets/open/20260607-031439-ticket-init-role-profile-scaffold/item.md +++ b/.yoi/tickets/open/20260607-031439-ticket-init-role-profile-scaffold/item.md @@ -8,7 +8,7 @@ priority: P1 labels: [ticket, config, init, profiles, panel] workflow_state: ready created_at: 2026-06-07T03:14:39Z -updated_at: 2026-06-07T03:58:12Z +updated_at: 2026-06-07T04:04:17Z assignee: null legacy_ticket: null --- diff --git a/.yoi/tickets/open/20260607-031439-ticket-init-role-profile-scaffold/thread.md b/.yoi/tickets/open/20260607-031439-ticket-init-role-profile-scaffold/thread.md index 878cc33a..d27c2b98 100644 --- a/.yoi/tickets/open/20260607-031439-ticket-init-role-profile-scaffold/thread.md +++ b/.yoi/tickets/open/20260607-031439-ticket-init-role-profile-scaffold/thread.md @@ -126,3 +126,35 @@ Reported validation: External review will be delegated before merge. --- + + + +## Review: approve + +Approved. + +Evidence: +- Runtime fallback was not loosened. Strict role launch validation still requires configured role table/profile and rejects top-level `inherit` before launch. +- `ticket_config_scaffold()` writes explicit backend config and all fixed role tables: intake, orchestrator, coder, reviewer, investigator. +- Each generated role has explicit `profile = "builtin:default"` and explicit default `workflow`. +- Launch validation coverage plans both Intake and Orchestrator from the scaffolded config. +- `yoi ticket init` refuses to overwrite existing `.yoi/ticket.config.toml`, uses create-new behavior, and reports an actionable diagnostic. +- Command shape is scoped to `yoi ticket init`; no broad product init or runtime implicit fallback was introduced. + +Reviewer validation: +- `cargo test -p ticket config --lib` +- `cargo test -p client ticket_role --lib` +- `cargo test -p yoi ticket` +- `cargo fmt --check` +- `git diff --check develop...HEAD` +- `nix build --no-link .#yoi` + +Merge readiness: +- Branch is behind current `develop` only by Ticket metadata changes. +- Implementation changes are limited to `crates/client/src/ticket_role.rs`, `crates/ticket/src/config.rs`, and `crates/yoi/src/ticket_cli.rs`. +- `git merge-tree` showed no conflicts. + +Dogfooding note: +- The main workspace's existing `.yoi/ticket.config.toml` remains backend-only, so a separate main-workspace config update is needed after merge if this workspace should use explicit Ticket role profiles. + +---