From a59e5c1ed3fee2b935fdefc64ad2becc6e440b2e Mon Sep 17 00:00:00 2001 From: Hare Date: Sat, 20 Jun 2026 17:00:59 +0900 Subject: [PATCH] ticket: accept mcp tool registration --- .../artifacts/orchestration-plan.jsonl | 1 + .yoi/tickets/00001KVHR3WS6/item.md | 4 +- .yoi/tickets/00001KVHR3WS6/thread.md | 66 +++++++++++++++++++ 3 files changed, 69 insertions(+), 2 deletions(-) diff --git a/.yoi/tickets/00001KVHR3WS6/artifacts/orchestration-plan.jsonl b/.yoi/tickets/00001KVHR3WS6/artifacts/orchestration-plan.jsonl index d7f603ba..2d13b84e 100644 --- a/.yoi/tickets/00001KVHR3WS6/artifacts/orchestration-plan.jsonl +++ b/.yoi/tickets/00001KVHR3WS6/artifacts/orchestration-plan.jsonl @@ -1 +1,2 @@ {"id":"orch-plan-20260620-060022-1","ticket_id":"00001KVHR3WS6","kind":"blocked_by","related_ticket":"00001KVHR3WRY","note":"Tool registration requires initialized MCP stdio lifecycle. `00001KVHR3WRY` is queued and depends on `00001KVHR3WRF`; leave this Ticket queued until lifecycle is closed.","author":"yoi-orchestrator","at":"2026-06-20T06:00:22Z"} +{"id":"orch-plan-20260620-080022-2","ticket_id":"00001KVHR3WS6","kind":"accepted_plan","accepted_plan":{"summary":"Initialized MCP stdio lifecycle clientを使って `tools/list` を実行し、server-provided tool metadataを untrusted dataとして検証・正規化し、既存 `pod::feature` / ToolRegistry path経由で namespaced Yoi tools として登録する。This Ticket does not implement `tools/call` execution or resources/prompts.","branch":"impl/00001KVHR3WS6-mcp-tool-registration","worktree":"/home/hare/Projects/yoi/.worktree/00001KVHR3WS6-mcp-tool-registration","role_plan":"Orchestrator は acceptance records を commit 後、専用 implementation worktree `.worktree/00001KVHR3WS6-mcp-tool-registration` を作成し、Coder をその child worktree への narrow write scope で起動する。Coder 実装後、Reviewer が tools/list pagination/bounds、untrusted metadata/schema normalization、namespaced ToolRegistry registration、no tools/call execution、no resources/prompts registration を確認する。"},"author":"yoi-orchestrator","at":"2026-06-20T08:00:22Z"} diff --git a/.yoi/tickets/00001KVHR3WS6/item.md b/.yoi/tickets/00001KVHR3WS6/item.md index 46d709eb..3f244ee7 100644 --- a/.yoi/tickets/00001KVHR3WS6/item.md +++ b/.yoi/tickets/00001KVHR3WS6/item.md @@ -1,8 +1,8 @@ --- title: 'MCP: register server tools into ToolRegistry' -state: 'queued' +state: 'inprogress' created_at: '2026-06-20T05:30:04Z' -updated_at: '2026-06-20T06:00:44Z' +updated_at: '2026-06-20T08:00:53Z' assignee: null readiness: 'implementation_ready' risk_flags: ['mcp', 'tools-list', 'tool-registry', 'schema', 'untrusted-metadata'] diff --git a/.yoi/tickets/00001KVHR3WS6/thread.md b/.yoi/tickets/00001KVHR3WS6/thread.md index e93479b5..4a88c73f 100644 --- a/.yoi/tickets/00001KVHR3WS6/thread.md +++ b/.yoi/tickets/00001KVHR3WS6/thread.md @@ -27,3 +27,69 @@ Next: - `00001KVHR3WRY` が closed になった後、改めて reroute する。 --- + + + +## Decision + +Routing decision: implementation_ready + +Reason: +- Panel Queue により、この Ticket は Orchestrator routing 対象として明示許可された。 +- 前回は `00001KVHR3WRY` stdio JSON-RPC lifecycle が未完了だったため blocked/queued hold としたが、現在 `00001KVHR3WRY` は closed。 +- Ticket body は `tools/list` による registration scope、metadata/schema normalization、ToolRegistry integration、no `tools/call` execution、no resources/prompts を明確に分離している。 +- 現在 inprogress は 0 件、child implementation Pods はなし、matching branch/worktree はなし、Orchestrator worktree は clean。 +- Risk domain は mcp / tools-list / ToolRegistry / schema / untrusted metadata だが、Ticket は server metadata を untrusted data として扱い、invalid schema / duplicate / collision を fail-closed、normal ToolRegistry pathを使い、no private MCP bypass / no `tools/call` during registration などの invariants を明示している。bounded context check 後も implementation 前に必要な追加 human decision は見つからなかった。 + +Evidence checked: +- Ticket `00001KVHR3WS6` body / thread / relations / artifacts。 +- `TicketRelationQuery(00001KVHR3WS6)`: outgoing `depends_on 00001KVHR3WRY` is now closed。Incoming `00001KVHR3WSD` / `00001KVHR3WSW` are downstream and not blockers。 +- `TicketOrchestrationPlanQuery(00001KVHR3WS6)`: previous `blocked_by 00001KVHR3WRY` is resolved; accepted plan recorded now。 +- Workspace state: + - Orchestrator worktree clean at `68a8fc97`。 + - queued: `00001KVHR3WS6`, `00001KVHR3WSD`, `00001KVHR3WSN`, `00001KVHR3WSW`。 + - inprogress: 0。 + - visible Pods: self + peers only; spawned children 0。 + - no matching MCP tool-registration branch/worktree。 + +IntentPacket: + +Intent: +- Use the stdio MCP lifecycle client to call `tools/list` and register discovered MCP tools as ordinary Yoi model-visible tools through existing `pod::feature` / ToolRegistry contribution paths。 +- This Ticket implements registration/discovery only. It must not send `tools/call`, execute MCP tools, or expose resources/prompts。 + +Binding decisions / invariants: +- Server-provided tool names, descriptions, schemas, annotations, and metadata are untrusted data。 +- Normalize MCP tool names into stable namespaced Yoi tool names that include server namespace and avoid collisions。 +- Validate/normalize descriptions and JSON schemas before ToolRegistry registration; invalid schemas/duplicates/collisions fail closed with bounded diagnostics。 +- No server metadata may weaken Yoi instructions, scope, permissions, tool permissions, or system/developer instructions。 +- Registration must go through normal ToolRegistry / `pod::feature` dynamic contribution path; no private MCP bypass。 +- Do not send `tools/call` during registration。 +- Do not register resources/prompts in this Ticket。 +- Preserve lifecycle safety/redaction from `00001KVHR3WRY`。 + +Requirements / acceptance criteria: +- MCP mock server tool appears as model-visible Yoi tool with stable namespaced name。 +- Invalid schema is rejected with bounded diagnostic。 +- Duplicate/colliding names are rejected fail-closed。 +- Server metadata cannot weaken Yoi instructions/scope/permissions。 +- No `tools/call` request is sent during registration。 +- Tests cover valid registration, pagination/bounds, invalid schema, duplicate/collision, and untrusted metadata normalization。 + +Escalate if: +- Existing `pod::feature` dynamic contribution API cannot register MCP tools without broader provider-substrate changes。 +- Schema normalization requires product decisions beyond safe JSON schema subset / bounded diagnostics。 +- ToolRegistry registration would force `tools/call` execution into this Ticket。 + +Next action: +- Record `queued -> inprogress` and commit Ticket records before creating the implementation worktree and spawning Coder。 + +--- + + + +## State changed + +Ticket body/thread, relation metadata, closed MCP lifecycle dependency, Orchestrator worktree state, visible Pods, existing branch/worktree, and bounded ToolRegistry/schema context were checked. Dependency `00001KVHR3WRY` is closed, no inprogress/capacity blocker exists, and no missing planning decision was found. Accepting this queued Ticket for implementation before worktree/Pod side effects. + +---