Hare/yoi
1
1
Fork 0
Code Actions Packages Releases Activity

ticket: approve execution workspace materializer

Browse Source
This commit is contained in:
Keisuke Hirata 2026-07-07 04:23:08 +09:00
parent 673fbeed09
commit ab19882b8e
No known key found for this signature in database
2 changed files with 40 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.yoi/tickets/00001KWW9DYH4/item.md
View File

@ -2,7 +2,7 @@
title: 'Add local Git worktree Execution Workspace materializer' title: 'Add local Git worktree Execution Workspace materializer'
state: 'inprogress' state: 'inprogress'
created_at: '2026-07-06T18:00:46Z' created_at: '2026-07-06T18:00:46Z'
updated_at: '2026-07-06T19:17:17Z' updated_at: '2026-07-06T19:23:01Z'
assignee: null assignee: null
queued_by: 'workspace-panel' queued_by: 'workspace-panel'
queued_at: '2026-07-06T18:28:26Z' queued_at: '2026-07-06T18:28:26Z'

39
.yoi/tickets/00001KWW9DYH4/thread.md
View File

@ -249,3 +249,42 @@ Review-fix implementation report:
- Requesting follow-up external review against `8b7a5da0..c90ebf24` and full combined implementation。 - Requesting follow-up external review against `8b7a5da0..c90ebf24` and full combined implementation。
--- ---
<!-- event: review author: reviewer at: 2026-07-06T19:23:01Z status: approve -->
## Review: approve
External follow-up review result: approve
Blockers: none.
Evidence reviewed:
- Ticket / Objective context, combined diff, fix diff, and relevant runtime/workspace-server files in the implementation worktree。
- Fix commit `c90ebf24` and combined implementation after `8b7a5da0`。
Findings:
- Prior blocker is resolved. Browser/API `WorkerSpawnRequest` now exposes only `execution_workspace: { repository_id, selector? }` via `WorkerSpawnExecutionWorkspaceRequest` with `deny_unknown_fields`; internal `resolved_execution_workspace` is `#[serde(skip, default)]`。
- `/api/runtimes/{runtime_id}/workers` resolves safe repository id/selector server-side from configured repositories into an internal `ExecutionWorkspaceRequest`。
- `/api/workers` remains safe: `BrowserCreateWorkerRequest` only accepts optional `repository_id`; server-side code builds the internal request。
- Fix tests explicitly reject caller-supplied `local_path` and accept safe `repository_id`/`selector`, with response path redaction asserted。
- Response/status projections remain browser-safe: execution workspace summaries carry ids/commit/tree/cleanup metadata, not raw workspace/source paths。
- Original materializer acceptance remains satisfied:
- local Git only, remote/non-Git/dirty source rejected with typed diagnostics。
- selector resolves to commit/tree。
- detached `git worktree add --detach` is created under Runtime root `execution-workspaces/<allocation-id>/root/<repository-id>`。
- worker factory uses materialized workspace root/cwd instead of source root。
- allocation evidence and cleanup target are recorded。
- cleanup hook removes worktree and updates record。
- tests cover detached worktree, distinct paths, dirty rejection, unsupported diagnostics, cleanup, and materialized cwd。
Validation reviewed:
- Reviewer inspected requested fix diff and combined implementation diff。
- Reviewer ran read-only `git diff --check 50c80e77..HEAD` in the implementation worktree; no whitespace errors。
- Reviewer accepted Orchestrator-reported full validation suite as passing。
Non-blocking note:
- Runtime HTTP `/v1/workers` remains an internal/trusted backend-to-runtime API carrying `CreateWorkerRequest`; this matches the current trusted-runtime boundary and is not browser-facing。
No merge-blocking issues found.
---